@shopify/app-bridge - npm Package Compare versions

Comparing version 2.0.7 to 2.0.8

actions/AuthCode/index.d.ts

@@ -30,3 +30,3 @@ import { Group, MetaAction } from '../types';
 export interface RespondWithAuthCodeAction extends ActionBase {
-    readonly type: typeof Action.REQUEST;
+    readonly type: typeof Action.RESPOND;
     payload?: ResponsePayload;
@@ -33,0 +33,0 @@ }

actions/Navigation/Redirect/index.js

@@ -124,15 +124,17 @@ "use strict";
 function isAppPayload(payload) {
-    return typeof payload === 'object' && payload.path;
+    return typeof payload === 'object' && Object.prototype.hasOwnProperty.call(payload, 'path');
 }
 exports.isAppPayload = isAppPayload;
 function isAdminPathPayload(payload) {
-    return typeof payload === 'object' && payload.path;
+    return typeof payload === 'object' && Object.prototype.hasOwnProperty.call(payload, 'path');
 }
 exports.isAdminPathPayload = isAdminPathPayload;
 function isAdminSectionPayload(payload) {
-    return typeof payload === 'object' && typeof payload.section === 'object' && payload.section.name;
+    return (typeof payload === 'object' &&
+        typeof payload.section === 'object' &&
+        Object.prototype.hasOwnProperty.call(payload.section, 'name'));
 }
 exports.isAdminSectionPayload = isAdminSectionPayload;
 function isRemotePayload(payload) {
-    return typeof payload === 'object' && payload.url;
+    return typeof payload === 'object' && Object.prototype.hasOwnProperty.call(payload, 'url');
 }
@@ -139,0 +141,0 @@ exports.isRemotePayload = isRemotePayload;

actions/validator.js

@@ -12,3 +12,5 @@ "use strict";
 function isAppBridgeAction(action) {
-    return (action instanceof Object && Boolean(action.type) && action.type.toString().startsWith(constants_1.PREFIX));
+    return (action instanceof Object &&
+        Object.prototype.hasOwnProperty.call(action, 'type') &&
+        action.type.toString().startsWith(constants_1.PREFIX));
 }
@@ -41,3 +43,3 @@ exports.isAppBridgeAction = isAppBridgeAction;
     var group = _a.group, type = _a.type;
-    if (!group) {
+    if (!group || !Object.prototype.hasOwnProperty.call(features, group)) {
         return false;
@@ -62,4 +64,5 @@ }
     var data = event.data;
-    return data.type && helper_1.findMatchInEnum(types_1.MessageType, data.type) !== undefined;
+    return (Object.prototype.hasOwnProperty.call(data, 'type') &&
+        helper_1.findMatchInEnum(types_1.MessageType, data.type) !== undefined);
 }
 exports.isAppMessage = isAppMessage;

CHANGELOG.md

@@ -6,2 +6,13 @@ # Change Log
 
+## [2.0.8](https://github.com/Shopify/app-bridge/compare/v2.0.7...v2.0.8) (2022-02-09)
+
+
+### Bug Fixes
+
+* revert incorrect comparison and import changes causing broken features ([bb89d2c](https://github.com/Shopify/app-bridge/commit/bb89d2ce5acf5e70cf971e2f450d9b46392a7109))
+
+
+
+
+
 ## [2.0.7](https://github.com/Shopify/app-bridge/compare/v2.0.6...v2.0.7) (2022-01-26)
@@ -8,0 +19,0 @@

client/Hooks.js

@@ -51,3 +51,3 @@ "use strict";
     Hooks.prototype.set = function (hook, handler) {
-        if (!this.map[hook]) {
+        if (!Object.prototype.hasOwnProperty.call(this.map, hook)) {
             this.map[hook] = [];
@@ -54,0 +54,0 @@ }

MessageTransport.js

@@ -128,3 +128,3 @@ "use strict";
             var payload = { type: type, id: id };
-            if (!actionListeners[type]) {
+            if (!Object.prototype.hasOwnProperty.call(actionListeners, type)) {
                 actionListeners[type] = [];
@@ -151,3 +151,3 @@ }
             var hasCallback = false;
-            if (actionListeners[type]) {
+            if (Object.prototype.hasOwnProperty.call(actionListeners, type)) {
                 for (var _i = 0, _b = actionListeners[type]; _i < _b.length; _i++) {
@@ -154,0 +154,0 @@ var listener = _b[_i];

package.json

 {
   "name": "@shopify/app-bridge",
-  "version": "2.0.7",
+  "version": "2.0.8",
   "types": "index.d.ts",
@@ -56,3 +56,3 @@ "main": "index.js",
   },
-  "gitHead": "3cde60126a8047e32e51c6c2c4438a631ac6406a"
+  "gitHead": "cfb675676e9e74126f1221cf88864579a2dc63b1"
 }

validate/actions/share.js

@@ -15,3 +15,3 @@ "use strict";
     }
-    return action.payload.url ? urlError : textError;
+    return Object.prototype.hasOwnProperty.call(action.payload, 'url') ? urlError : textError;
 }
@@ -18,0 +18,0 @@ exports.validateAction = validateAction;

validate/utils.js

@@ -45,3 +45,3 @@ "use strict";
     window.addEventListener('DOMContentLoaded', function () {
-        if (!window.ShopifyApp) {
+        if (!Object.prototype.hasOwnProperty.call(window, 'ShopifyApp')) {
             return;
@@ -48,0 +48,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

865067

increased by0.2%

Lines of code

18266

increased by0.07%

No dependency changes