@shopify/theme-language-server-common - npm Package Compare versions

Comparing version 2.3.1 to 2.3.2

CHANGELOG.md

 # @shopify/theme-language-server-common
 
+## 2.3.2
+
+### Patch Changes
+
+- 2bd19d66: Fixed bug where filter completions wouldn't work on Liquid assignments
+
 ## 2.3.1
@@ -4,0 +10,0 @@

dist/completions/providers/FilterCompletionProvider.js

@@ -77,3 +77,3 @@ "use strict";
         // ignore the pipe and any spaces for our starting position.
-        const pipeRegex = new RegExp(`(\\s*\\|\\s*)(?:${node.name}\\}\\})`);
+        const pipeRegex = new RegExp(`(\\s*\\|\\s*)(?:${node.name}(?:\\}|\\%)\\})`);
         const matchFilterPipe = node.source.match(pipeRegex);
@@ -80,0 +80,0 @@ const startOffet = matchFilterPipe ? matchFilterPipe[1].length : 0;

package.json

 {
   "name": "@shopify/theme-language-server-common",
-  "version": "2.3.1",
+  "version": "2.3.2",
   "main": "dist/index.js",
@@ -5,0 +5,0 @@ "types": "dist/index.d.ts",

src/completions/providers/FilterCompletionProvider.spec.ts

@@ -175,2 +175,29 @@ import { FilterEntry, MetafieldDefinitionMap, ObjectEntry } from '@shopify/theme-check-common';
 
+  it('handles assignment the same way as output', async () => {
+    //                                     char 31 ⌄ ⌄ char 33
+    const liquid = '{% assign imageUrl = product | de█ %}';
+
+    const textEdit: TextEdit = {
+      newText: 'default',
+      range: {
+        end: { line: 0, character: 33 },
+        start: { line: 0, character: 31 },
+      },
+    };
+
+    await expect(provider).to.complete(liquid, [
+      expect.objectContaining({
+        label: 'default',
+        insertTextFormat: InsertTextFormat.PlainText,
+        textEdit,
+      }),
+    ]);
+
+    const textDocument = TextDocument.create('', 'liquid', 0, liquid.replace(CURSOR, ''));
+
+    expect(TextDocument.applyEdits(textDocument, [textEdit])).toBe(
+      '{% assign imageUrl = product | default %}',
+    );
+  });
+
   describe('when there are no required parameters', () => {
@@ -177,0 +204,0 @@ it('should not include parameters in the insertText of the completion', async () => {

src/completions/providers/FilterCompletionProvider.ts

@@ -86,3 +86,3 @@ import { LiquidFilter, NodeTypes } from '@shopify/liquid-html-parser';
     // ignore the pipe and any spaces for our starting position.
-    const pipeRegex = new RegExp(`(\\s*\\|\\s*)(?:${node.name}\\}\\})`);
+    const pipeRegex = new RegExp(`(\\s*\\|\\s*)(?:${node.name}(?:\\}|\\%)\\})`);
     const matchFilterPipe = node.source.match(pipeRegex);
@@ -89,0 +89,0 @@ const startOffet = matchFilterPipe ? matchFilterPipe[1].length : 0;

No alert changes

Improved metrics

Total package byte prevSize

1351822

increased by0.07%

Lines of code

22681

increased by0.1%

No dependency changes