@signalwire/js - npm Package Compare versions

Comparing version 1.3.0-cantina.13 to 1.3.0-cantina.14

dist/esm/common/src/BaseSession.js

@@ -133,2 +133,5 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
             this._detachListeners();
+            this.off(SwEvent.Ready);
+            this.off(SwEvent.Notification);
+            this.off(SwEvent.Error);
         });
@@ -135,0 +138,0 @@ }

dist/esm/common/src/BrowserSession.d.ts

@@ -79,3 +79,5 @@ import BaseSession from './BaseSession';
     watchVertoConferences: (showLayouts?: boolean, showMembers?: boolean) => Promise<IConferenceInfo[]>;
+    _watchRoomsNotificationHandler: (event: any) => void;
     unwatchVertoConferences: () => Promise<void>;
+    private _detachChannels;
     dispatchConferenceUpdate(params: any): void;
@@ -82,0 +84,0 @@ _jsApi(params?: {}): any;

dist/esm/common/src/BrowserSession.js

@@ -22,3 +22,3 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
 import BaseSession from './BaseSession';
-import { registerOnce, trigger } from './services/Handler';
+import { deRegister, registerOnce, trigger } from './services/Handler';
 import { SwEvent, SESSION_ID } from './util/constants';
@@ -61,5 +61,7 @@ import { State, DeviceType, Notification } from './webrtc/constants';
             const modChannel = 'conference-mod';
+            const channels = [infoChannel, laChannel, modChannel];
+            this._detachChannels(channels);
             const result = yield this.vertoSubscribe({
                 nodeId: this.nodeid,
-                channels: [infoChannel, laChannel, modChannel],
+                channels,
             });
@@ -72,26 +74,4 @@ const { subscribed = [], alreadySubscribed = [] } = destructSubscribeResponse(result);
             if (all.includes(infoChannel)) {
-                this.on('signalwire.notification', (event) => {
-                    if (event.type !== 'conferenceUpdate') {
-                        return;
-                    }
-                    switch (event.action) {
-                        case 'clear':
-                            Object.keys(this.conferences).forEach(uuid => {
-                                if (this.conferences[uuid].confName === event.confName) {
-                                    delete this.conferences[uuid];
-                                }
-                            });
-                            break;
-                        case 'conferenceInfo':
-                            const conferenceState = event.conferenceState;
-                            const { uuid, running } = conferenceState;
-                            if (running) {
-                                this.conferences[uuid] = new Conference(this, conferenceState);
-                            }
-                            else {
-                                delete this.conferences[uuid];
-                            }
-                            break;
-                    }
-                });
+                this.off('signalwire.notification', this._watchRoomsNotificationHandler);
+                this.on('signalwire.notification', this._watchRoomsNotificationHandler);
                 this._addSubscription(this.relayProtocol, infoChannelHandler.bind(this, this), infoChannel);
@@ -104,2 +84,26 @@ }
         });
+        this._watchRoomsNotificationHandler = (event) => {
+            if (event.type !== 'conferenceUpdate') {
+                return;
+            }
+            switch (event.action) {
+                case 'clear':
+                    Object.keys(this.conferences).forEach(uuid => {
+                        if (this.conferences[uuid].confName === event.confName) {
+                            delete this.conferences[uuid];
+                        }
+                    });
+                    break;
+                case 'conferenceInfo':
+                    const conferenceState = event.conferenceState;
+                    const { uuid, running } = conferenceState;
+                    if (running) {
+                        this.conferences[uuid] = new Conference(this, conferenceState);
+                    }
+                    else {
+                        delete this.conferences[uuid];
+                    }
+                    break;
+            }
+        };
         this.unwatchVertoConferences = () => __awaiter(this, void 0, void 0, function* () {
@@ -111,5 +115,3 @@ this.conferences = {};
             const channels = [infoChannel, laChannel, modChannel];
-            channels.forEach(channel => {
-                this._removeSubscription(this.relayProtocol, channel);
-            });
+            this._detachChannels(channels);
             yield this.vertoUnsubscribe({
@@ -120,2 +122,8 @@ nodeId: this.nodeid,
         });
+        this._detachChannels = (channels) => {
+            channels.forEach(channel => {
+                deRegister(this.relayProtocol, null, channel);
+                this._removeSubscription(this.relayProtocol, channel);
+            });
+        };
     }
@@ -454,4 +462,6 @@ get callIds() {
         this.purge();
+        const channels = ['conference-info', 'conference-liveArray', 'conference-mod'];
+        this._detachChannels(channels);
         super._onSocketCloseOrError(event);
     }
 }

dist/esm/js/index.d.ts

 import Relay from './src/SignalWire';
 import Verto from './src/Verto';
 import CantinaAuth from '../common/src/webrtc/CantinaAuth';
-export declare const VERSION = "1.3.0-cantina.13";
+export declare const VERSION = "1.3.0-cantina.14";
 export { Relay, Verto, CantinaAuth };
@@ -6,0 +6,0 @@ export * from '../common/src/webrtc/deviceHelpers';

dist/esm/js/index.js

@@ -5,5 +5,5 @@ import Relay from './src/SignalWire';
 import CantinaAuth from '../common/src/webrtc/CantinaAuth';
-export const VERSION = '1.3.0-cantina.13';
+export const VERSION = '1.3.0-cantina.14';
 setAgentName(`JavaScript SDK/${VERSION}`);
 export { Relay, Verto, CantinaAuth };
 export * from '../common/src/webrtc/deviceHelpers';

package.json

 {
   "name": "@signalwire/js",
-  "version": "1.3.0-cantina.13",
+  "version": "1.3.0-cantina.14",
   "description": "Relay SDK for JavaScript to connect to SignalWire.",
@@ -5,0 +5,0 @@ "author": "SignalWire Team <[e-mail]>",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

380869

increased by0.26%

Lines of code

5503

increased by0.27%

No dependency changes