@spectrum-css/combobox
Advanced tools
Comparing version 1.0.16 to 2.0.0
@@ -6,2 +6,54 @@ # Change Log | ||
<a name="2.0.0"></a> | ||
# 2.0.0 | ||
🗓 2023-05-02 • 📝 [Commits](https://github.com/adobe/spectrum-css/compare/@spectrum-css/combobox@1.0.16...@spectrum-css/combobox@2.0.0) | ||
* fix(textfield, combobox)!: adjust padding calculations (#1803) ([09c1bdc](https://github.com/adobe/spectrum-css/commit/09c1bdc)), closes [#1803](https://github.com/adobe/spectrum-css/issues/1803) | ||
### 🛑 BREAKING CHANGES | ||
* removes `--mod-combobox-icon-size`, `--mod-combobox-spacing-block-start-to-border`, `--mod-combobox-spacing-inline-start-to-textfield`, `--mod-combobox-spacing-block-start-edge-to-textfield`, `--mod-combobox-spacing-block-end-edge-to-textfield`, and `--mod-combobox-spacing-inline-start-edge-to-textfield`. | ||
Additionally: | ||
* fix: exclude border width from padding with text inputs + more fixes | ||
- Textfield and Combobox: exclude border width from padding calculations | ||
because most of the to-edge tokens include the border, and the values | ||
were 1px larger than they should have been. | ||
- Textfield and Combobox: fix corner radius of focus indicator when | ||
using a larger border radius (e.g. try setting a --mod border width | ||
of 5px; the calculation adding the border width was incorrect) | ||
- Combobox: adjust styles so custom property for border width is | ||
correctly overriding everything from its sub-components. Previously | ||
using --mod-combobox-border-width had no effect. | ||
- Combobox: simplify/remove some custom properties related to those | ||
fixes and quiet variant. | ||
* fix(combobox): border-radius should not increase for t-shirt sizes | ||
Per design feedback, the border-radius value should not be increasing | ||
for these t-shirt sizes. | ||
* fix(combobox): calculate the button x-offset on quiet | ||
Use a corrected calculation of the x-offset for the picker button on the | ||
quiet variant. Based on design feedback for the component: "The point is | ||
to line up the chevron icon with the end of the component so those | ||
elements are flushed". | ||
* fix(combobox): mods update after changes | ||
Regenerate mods after fixes that have removed and renamed some | ||
properties. | ||
* feat(textfield): add 'size' control to storybook | ||
Add "t-shirt" size control to Textfield stories. The arg was already | ||
there, but it was missing a control for testing. | ||
<a name="1.0.16"></a> | ||
@@ -8,0 +60,0 @@ ## 1.0.16 |
| Modifiable Custom Properties | | ||
| --- | | ||
|`--mod-combobox-block-size`| | ||
|`--mod-combobox-icon-size`| | ||
|`--mod-combobox-inline-size`| | ||
|`--mod-combobox-min-inline-size`| | ||
|`--mod-combobox-block-size`| | ||
|`--mod-combobox-spacing-label-to-combobox`| | ||
|`--mod-combobox-border-radius`| | ||
|`--mod-combobox-border-width`| | ||
|`--mod-combobox-spacing-edge-to-menu`| | ||
@@ -16,2 +16,3 @@ |`--mod-combobox-spacing-inline-icon-to-button`| | ||
|`--mod-combobox-font-color-default`| | ||
|`--mod-combobox-border-width`| | ||
|`--mod-combobox-border-color-default`| | ||
@@ -36,5 +37,6 @@ |`--mod-combobox-font-color-focus`| | ||
|`--mod-combobox-focus-indicator-color`| | ||
|`--mod-combobox-spacing-block-start-edge-to-textfield`| | ||
|`--mod-combobox-spacing-block-end-edge-to-textfield`| | ||
|`--mod-combobox-spacing-inline-start-edge-to-textfield`| | ||
|`--mod-combobox-spacing-block-start-edge-to-text`| | ||
|`--mod-combobox-spacing-block-end-edge-to-text`| | ||
|`--mod-combobox-spacing-inline-start-edge-to-text`| | ||
|`--mod-combobox-spacing-inline-end-edge-to-text`| | ||
|`--mod-combobox-background-color-default`| | ||
@@ -51,7 +53,3 @@ |`--mod-combobox-font-size`| | ||
|`--mod-combobox-background-color-key-focus`| | ||
|`--mod-combobox-icon-size`| | ||
|`--mod-spectrum-combobox-spacing-inline-end-edge-to-text`| | ||
|`--mod-combobox-alert-icon-color`| | ||
|`--mod-combobox-spacing-block-start-to-border`| | ||
|`--mod-combobox-spacing-inline-start-to-textfield`| | ||
|`--mod-combobox-border-color-disabled`| |
{ | ||
"name": "@spectrum-css/combobox", | ||
"version": "1.0.16", | ||
"version": "2.0.0", | ||
"description": "The Spectrum CSS combobox component", | ||
@@ -27,8 +27,8 @@ "license": "Apache-2.0", | ||
"@spectrum-css/component-builder-simple": "^2.0.10", | ||
"@spectrum-css/menu": "^4.0.26", | ||
"@spectrum-css/pickerbutton": "^3.0.11", | ||
"@spectrum-css/popover": "^6.0.38", | ||
"@spectrum-css/progresscircle": "^2.0.34", | ||
"@spectrum-css/textfield": "^4.1.15", | ||
"@spectrum-css/tokens": "^9.0.4", | ||
"@spectrum-css/menu": "^4.0.27", | ||
"@spectrum-css/pickerbutton": "^3.0.12", | ||
"@spectrum-css/popover": "^6.0.39", | ||
"@spectrum-css/progresscircle": "^2.0.35", | ||
"@spectrum-css/textfield": "^5.0.0", | ||
"@spectrum-css/tokens": "^9.1.0", | ||
"gulp": "^4.0.0" | ||
@@ -39,3 +39,3 @@ }, | ||
}, | ||
"gitHead": "a90d7639920369c1fc5757325b409cfc3329edc9" | ||
"gitHead": "41919d2f9ed7ed534a862192895b82c90f3910f8" | ||
} |
Sorry, the diff of this file is not supported yet
Sorry, the diff of this file is not supported yet
Sorry, the diff of this file is not supported yet
Sorry, the diff of this file is not supported yet
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
189841
2084