@spectrum-web-components/dropdown - npm Package Compare versions

Comparing version 0.3.1 to 0.3.2

CHANGELOG.md

@@ -6,2 +6,8 @@ # Change Log
 
+## [0.3.2](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/dropdown@0.3.1...@spectrum-web-components/dropdown@0.3.2) (2019-12-02)
+
+### Bug Fixes
+
+-   normalize "event" and "error" argument names ([8d382cd](https://github.com/adobe/spectrum-web-components/commit/8d382cd))
+
 ## [0.3.1](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/dropdown@0.3.0...@spectrum-web-components/dropdown@0.3.1) (2019-11-27)
@@ -8,0 +14,0 @@

lib/dropdown.d.ts

@@ -32,4 +32,4 @@ import { PropertyValues, CSSResultArray, TemplateResult } from 'lit-element';
     onButtonFocus(): void;
-    onClick(ev: Event): void;
-    onKeydown(ev: KeyboardEvent): void;
+    onClick(event: Event): void;
+    onKeydown(event: KeyboardEvent): void;
     setValueFromItem(item: MenuItem): void;
@@ -36,0 +36,0 @@ toggle(): void;

lib/dropdown.js

@@ -97,4 +97,4 @@ /*
     }
-    onClick(ev) {
-        const path = ev.composedPath();
+    onClick(event) {
+        const path = event.composedPath();
         const target = path.find((el) => {
@@ -111,4 +111,4 @@ if (!(el instanceof Element) || this.optionsMenu === null) {
     }
-    onKeydown(ev) {
-        if (ev.code !== 'ArrowDown') {
+    onKeydown(event) {
+        if (event.code !== 'ArrowDown') {
             return;
@@ -115,0 +115,0 @@ }

package.json

@@ -21,3 +21,3 @@ {
     ],
-    "version": "0.3.1",
+    "version": "0.3.2",
     "description": "",
@@ -45,12 +45,12 @@ "main": "lib/index.js",
     "dependencies": {
-        "@spectrum-web-components/button": "^0.3.1",
-        "@spectrum-web-components/icon": "^0.4.1",
-        "@spectrum-web-components/icons": "^0.2.1",
-        "@spectrum-web-components/menu": "^0.2.1",
-        "@spectrum-web-components/menu-item": "^0.3.1",
+        "@spectrum-web-components/button": "^0.3.2",
+        "@spectrum-web-components/icon": "^0.4.2",
+        "@spectrum-web-components/icons": "^0.2.2",
+        "@spectrum-web-components/menu": "^0.2.2",
+        "@spectrum-web-components/menu-item": "^0.3.2",
         "@spectrum-web-components/popover": "^0.2.1",
-        "@spectrum-web-components/shared": "^0.3.1",
+        "@spectrum-web-components/shared": "^0.3.2",
         "tslib": "^1.10.0"
     },
-    "gitHead": "b81218bc84e60248f14a1aee7e58ade0030e52dc"
+    "gitHead": "b3bff461b5e5cac7211dba5a54dae4c82d809a85"
 }

src/dropdown.ts

@@ -146,4 +146,4 @@ /*
 
-    public onClick(ev: Event): void {
-        const path = ev.composedPath();
+    public onClick(event: Event): void {
+        const path = event.composedPath();
         const target = path.find((el) => {
@@ -161,4 +161,4 @@ if (!(el instanceof Element) || this.optionsMenu === null) {
 
-    public onKeydown(ev: KeyboardEvent): void {
-        if (ev.code !== 'ArrowDown') {
+    public onKeydown(event: KeyboardEvent): void {
+        if (event.code !== 'ArrowDown') {
             return;
@@ -165,0 +165,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

108547

increased by0.32%

Dependency changes

• Updated@spectrum-web-components/button@^0.3.2

• Updated@spectrum-web-components/icon@^0.4.2

• Updated@spectrum-web-components/icons@^0.2.2

• Updated@spectrum-web-components/menu@^0.2.2

• Updated@spectrum-web-components/menu-item@^0.3.2

• Updated@spectrum-web-components/shared@^0.3.2