@spectrum-web-components/dropdown - npm Package Compare versions

Comparing version 0.4.5-alpha.1 to 0.5.0

CHANGELOG.md

@@ -6,2 +6,16 @@ # Change Log
 
+# [0.5.0](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/dropdown@0.4.4...@spectrum-web-components/dropdown@0.5.0) (2020-04-16)
+
+### Bug Fixes
+
+-   **button:** add excludeSourceSelector to reduce duplication of styles ([683e88e](https://github.com/adobe/spectrum-web-components/commit/683e88e8ac659e789c20d77bf0af602a305b54f9))
+
+### Features
+
+-   add and use icons-ui package ([d9c3ab2](https://github.com/adobe/spectrum-web-components/commit/d9c3ab212b4f756334e857fc513ccbf0a4dff9cc))
+
+### Performance Improvements
+
+-   use "sideEffects" listing in package.json ([7271614](https://github.com/adobe/spectrum-web-components/commit/7271614c0ca3ccf3566583bb59467eb15a6199cd))
+
 ## [0.4.4](https://github.com/adobe/spectrum-web-components/compare/@spectrum-web-components/dropdown@0.4.3...@spectrum-web-components/dropdown@0.4.4) (2020-04-10)
@@ -8,0 +22,0 @@

lib/dropdown.d.ts

 import { PropertyValues, CSSResultArray, TemplateResult } from 'lit-element';
 import { Focusable } from '@spectrum-web-components/shared/lib/focusable.js';
 import '@spectrum-web-components/icon';
-import '@spectrum-web-components/icons';
 import { Menu } from '@spectrum-web-components/menu';
@@ -6,0 +5,0 @@ import '@spectrum-web-components/menu-item';

lib/dropdown.js

@@ -17,2 +17,3 @@ /*
 import dropdownStyles from './dropdown.css.js';
+import buttonBaseStyles from '@spectrum-web-components/button/lib/button-base.css.js';
 import actionButtonStyles from '@spectrum-web-components/button/lib/action-button.css.js';
@@ -24,3 +25,3 @@ import fieldButtonStyles from '@spectrum-web-components/button/lib/field-button.css.js';
 import '@spectrum-web-components/icon';
-import '@spectrum-web-components/icons';
+import { AlertSmallIcon, ChevronDownMediumIcon, } from '@spectrum-web-components/icons-ui';
 import '@spectrum-web-components/menu-item';
@@ -58,2 +59,3 @@ import '@spectrum-web-components/popover';
             ...super.styles,
+            buttonBaseStyles,
             actionButtonStyles,
@@ -202,14 +204,10 @@ dropdownStyles,
                 ? html `
-                          <sp-icon
-                              class="icon alert-small"
-                              name="ui:AlertSmall"
-                              size="s"
-                          ></sp-icon>
+                          <sp-icon class="icon alert-small" size="s">
+                              ${AlertSmallIcon({ hidden: true })}
+                          </sp-icon>
                       `
                 : nothing}
-                <sp-icon
-                    class="icon dropdown chevron-down-medium"
-                    name="ui:ChevronDownMedium"
-                    size="s"
-                ></sp-icon>
+                <sp-icon class="icon dropdown chevron-down-medium" size="s">
+                    ${ChevronDownMediumIcon({ hidden: true })}
+                </sp-icon>
             `,
@@ -220,3 +218,2 @@ ];
         return html `
-            <sp-icons-medium></sp-icons-medium>
             <button
@@ -223,0 +220,0 @@ aria-haspopup="true"

package.json

@@ -21,3 +21,3 @@ {
     ],
-    "version": "0.4.5-alpha.1+e39e02a1",
+    "version": "0.5.0",
     "description": "",
@@ -49,13 +49,13 @@ "main": "lib/index.js",
     "dependencies": {
-        "@spectrum-web-components/button": "^0.4.9-alpha.1+e39e02a1",
-        "@spectrum-web-components/icon": "^0.4.6-alpha.11+e39e02a1",
-        "@spectrum-web-components/icons": "^0.3.1-alpha.11+e39e02a1",
-        "@spectrum-web-components/menu": "^0.2.6-alpha.11+e39e02a1",
-        "@spectrum-web-components/menu-item": "^0.4.4-alpha.1+e39e02a1",
-        "@spectrum-web-components/overlay": "^0.3.5-alpha.1+e39e02a1",
-        "@spectrum-web-components/popover": "^0.3.7-alpha.1+e39e02a1",
-        "@spectrum-web-components/shared": "^0.4.6-alpha.1+e39e02a1",
+        "@spectrum-web-components/button": "^0.5.0",
+        "@spectrum-web-components/icon": "^0.4.6",
+        "@spectrum-web-components/icons-ui": "^0.1.0",
+        "@spectrum-web-components/menu": "^0.2.6",
+        "@spectrum-web-components/menu-item": "^0.5.0",
+        "@spectrum-web-components/overlay": "^0.3.5",
+        "@spectrum-web-components/popover": "^0.3.7",
+        "@spectrum-web-components/shared": "^0.4.6",
         "tslib": "^1.10.0"
     },
-    "gitHead": "e39e02a1cbe36c4512a18fa8622a8861f2509629"
+    "gitHead": "c8a769e3b24974f722054bc121f9a896d66e0bf1"
 }

src/dropdown.ts

@@ -25,2 +25,3 @@ /*
 import dropdownStyles from './dropdown.css.js';
+import buttonBaseStyles from '@spectrum-web-components/button/lib/button-base.css.js';
 import actionButtonStyles from '@spectrum-web-components/button/lib/action-button.css.js';
@@ -33,3 +34,6 @@ import fieldButtonStyles from '@spectrum-web-components/button/lib/field-button.css.js';
 import '@spectrum-web-components/icon';
-import '@spectrum-web-components/icons';
+import {
+    AlertSmallIcon,
+    ChevronDownMediumIcon,
+} from '@spectrum-web-components/icons-ui';
 import { Menu, MenuQueryRoleEventDetail } from '@spectrum-web-components/menu';
@@ -52,2 +56,3 @@ import '@spectrum-web-components/menu-item';
             ...super.styles,
+            buttonBaseStyles,
             actionButtonStyles,
@@ -284,14 +289,10 @@ dropdownStyles,
                     ? html`
-                          <sp-icon
-                              class="icon alert-small"
-                              name="ui:AlertSmall"
-                              size="s"
-                          ></sp-icon>
+                          <sp-icon class="icon alert-small" size="s">
+                              ${AlertSmallIcon({ hidden: true })}
+                          </sp-icon>
                       `
                     : nothing}
-                <sp-icon
-                    class="icon dropdown chevron-down-medium"
-                    name="ui:ChevronDownMedium"
-                    size="s"
-                ></sp-icon>
+                <sp-icon class="icon dropdown chevron-down-medium" size="s">
+                    ${ChevronDownMediumIcon({ hidden: true })}
+                </sp-icon>
             `,
@@ -303,3 +304,2 @@ ];
         return html`
-            <sp-icons-medium></sp-icons-medium>
             <button
@@ -306,0 +306,0 @@ aria-haspopup="true"

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Manifest confusion

Supply chain risk

This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

133693

increased by10.08%

Number of package files

26

increased by8.33%

Lines of code

1558

increased by5.7%

Number of medium supply chain risk alerts

0

decreased by-100%

Dependency changes

• + Added@spectrum-web-components/icons-ui@^0.1.0

• + Added@spectrum-web-components/button@0.5.20.7.0(transitive)

• + Added@spectrum-web-components/icons-ui@0.1.2(transitive)

• + Added@spectrum-web-components/menu-item@0.5.4(transitive)

• - Removed@spectrum-web-components/icons@^0.3.1-alpha.11+e39e02a1

• - Removed@spectrum-web-components/button@0.4.9-alpha.1(transitive)

• - Removed@spectrum-web-components/icons@0.3.3(transitive)

• - Removed@spectrum-web-components/menu-item@0.4.4-alpha.1(transitive)

• Updated@spectrum-web-components/button@^0.5.0

• Updated@spectrum-web-components/icon@^0.4.6

• Updated@spectrum-web-components/menu@^0.2.6

• Updated@spectrum-web-components/menu-item@^0.5.0

• Updated@spectrum-web-components/overlay@^0.3.5

• Updated@spectrum-web-components/popover@^0.3.7

• Updated@spectrum-web-components/shared@^0.4.6