@studyportals/sp-lurch-interface - npm Package Compare versions

Comparing version 2.8.2 to 2.9.0

index.d.ts

@@ -14,4 +14,3 @@ import { InputBatchDto } from './src/input-batches/input-batch-dto.class';
 import { SubmitMatchesResult } from './src/results/submit-matches-result.class';
-import { DiscardInputBatchresult } from './src/results/discard-input-batch-result.class';
 import { LurchClient } from './src/lurch-client';
-export { IIntake, IMatch, IInputBatch, IntakeDto, MatchDto, InputBatchDto, SubmitMatchesResult, DiscardInputBatchresult, RetrieveIntakesResult, RetrieveIntakeResult, RetrieveInputBatchResult, RetrieveInputBatchesResult, InputBatchStatus, IntakeStageType, LurchClient, };
+export { IIntake, IMatch, IInputBatch, IntakeDto, MatchDto, InputBatchDto, SubmitMatchesResult, RetrieveIntakesResult, RetrieveIntakeResult, RetrieveInputBatchResult, RetrieveInputBatchesResult, InputBatchStatus, IntakeStageType, LurchClient, };

index.js

@@ -23,6 +23,4 @@ "use strict";
 exports.SubmitMatchesResult = submit_matches_result_class_1.SubmitMatchesResult;
-const discard_input_batch_result_class_1 = require("./src/results/discard-input-batch-result.class");
-exports.DiscardInputBatchresult = discard_input_batch_result_class_1.DiscardInputBatchresult;
 const lurch_client_1 = require("./src/lurch-client");
 exports.LurchClient = lurch_client_1.LurchClient;
 //# sourceMappingURL=index.js.map

package.json

 {
     "name": "@studyportals/sp-lurch-interface",
-    "version": "2.8.2",
+    "version": "2.9.0",
     "description": "Contains Data Transfer Objects required or provided by Lurch through its interface.",
@@ -8,3 +8,3 @@ "scripts": {
         "test-u": "tsc && npm run test-u-o",
-        "test-u-o": "nyc --all --silent mocha \"bin/tests-u/**/*.test.js\"",
+        "test-u-o": "npx --all --silent mocha \"bin/tests-u/**/*.test.js\"",
         "prepare-deployment": "cp package.json bin/package.json",
@@ -15,5 +15,5 @@ "deploy": "npm test && npm run prepare-deployment && npm publish bin",
         "coverage": "nyc report --reporter=lcov",
-        "deploy-patch": "npm run prepare-deployment && npm version patch && npm run deploy",
-        "deploy-minor": "npm run prepare-deployment && npm version minor && npm run deploy",
-        "deploy-major": "npm run prepare-deployment && npm version major && npm run deploy"
+        "deploy-patch": "npm version patch && npm run deploy",
+        "deploy-minor": "npm version minor && npm run deploy",
+        "deploy-major": "npm version major && npm run deploy"
     },
@@ -24,11 +24,11 @@ "author": "SPAF",
         "@types/chai": "^4.0.4",
+        "@types/superagent": "^3.8.7",
         "chai": "^4.1.2",
         "mocha": "4.0.1",
         "mocha-typescript": "1.1.10",
-        "nyc": "15.0.0",
-        "ts-node": "^6.0.3",
+        "nyc": "11.4.1",
+        "ts-node": "^9.0.0",
         "tslint": "^5.9.1",
         "typemoq": "2.1.0",
-        "typescript": "^2.5.3",
-        "@types/superagent": "^3.8.7"
+        "typescript": "^2.5.3"
     },
@@ -35,0 +35,0 @@ "dependencies": {

src/lurch-client.d.ts

@@ -11,3 +11,2 @@ import { IRequestSender, ISuperAgentRequestFactory } from "@studyportals/mb-platform-http-requests";
     approveInputBatch(inputBatchIdentity: string): Promise<void>;
-    discardInputBatch(inputBatchIdentity: string): Promise<void>;
     private createGetRequest;
@@ -14,0 +13,0 @@ private createPostRequest;

src/lurch-client.js

@@ -34,9 +34,2 @@ "use strict";
     }
-    discardInputBatch(inputBatchIdentity) {
-        return __awaiter(this, void 0, void 0, function* () {
-            const request = this.createPostRequest('/input-batch/discard');
-            request.send({ inputBatchIdentity });
-            yield this.requestSender.send(request);
-        });
-    }
     createGetRequest(relative = '') {
@@ -43,0 +36,0 @@ return this.superAgentRequestFactory.get(this.buildUrl(relative));

tests-u/lurch-client.test.js

@@ -88,2 +88,3 @@ "use strict";
             const inputBatchIdentity = "InputBatchIdentity";
+            const representativeIdentity = "RepresentativeIdentity";
             yield this.testInstance.approveInputBatch(inputBatchIdentity);
@@ -104,26 +105,2 @@ this.mockedRequest.verify(_ => _.send(typemoq_1.It.isObjectWith({ inputBatchIdentity: inputBatchIdentity })), typemoq_1.Times.once());
     }
-    discardInputBatch__PostRequestCreatedForCorrectPath() {
-        return __awaiter(this, void 0, void 0, function* () {
-            yield this.testInstance.discardInputBatch(typemoq_1.It.isAny());
-            this.mockedTestInstance.verify(_ => _["createPostRequest"]("/input-batch/discard"), typemoq_1.Times.once());
-        });
-    }
-    discardInputBatch__InputBatchIdentitySpecified() {
-        return __awaiter(this, void 0, void 0, function* () {
-            const inputBatchIdentity = "InputBatchIdentity";
-            yield this.testInstance.discardInputBatch(inputBatchIdentity);
-            this.mockedRequest.verify(_ => _.send(typemoq_1.It.isObjectWith({ inputBatchIdentity: inputBatchIdentity })), typemoq_1.Times.once());
-        });
-    }
-    discardInputBatch__RequestSent() {
-        return __awaiter(this, void 0, void 0, function* () {
-            let awaited = false;
-            this.mockedRequestSender.setup(_ => _.send(typemoq_1.It.isAny()))
-                .returns(() => new Promise(_ => setImmediate(() => { awaited = true; _(); })));
-            ;
-            yield this.testInstance.discardInputBatch(typemoq_1.It.isAny());
-            this.mockedRequestSender.verify(_ => _.send(this.request), typemoq_1.Times.once());
-            chai_1.assert.isTrue(awaited);
-        });
-    }
     createGetRequest__UrlCorrectlyBuilt() {
@@ -220,20 +197,2 @@ const { mockedTestInstance, testInstance } = this.createTestInstance();
     __metadata("design:paramtypes", []),
-    __metadata("design:returntype", Promise)
-], LurchClientTest.prototype, "discardInputBatch__PostRequestCreatedForCorrectPath", null);
-__decorate([
-    mocha_typescript_1.test,
-    __metadata("design:type", Function),
-    __metadata("design:paramtypes", []),
-    __metadata("design:returntype", Promise)
-], LurchClientTest.prototype, "discardInputBatch__InputBatchIdentitySpecified", null);
-__decorate([
-    mocha_typescript_1.test,
-    __metadata("design:type", Function),
-    __metadata("design:paramtypes", []),
-    __metadata("design:returntype", Promise)
-], LurchClientTest.prototype, "discardInputBatch__RequestSent", null);
-__decorate([
-    mocha_typescript_1.test,
-    __metadata("design:type", Function),
-    __metadata("design:paramtypes", []),
     __metadata("design:returntype", void 0)
@@ -240,0 +199,0 @@ ], LurchClientTest.prototype, "createGetRequest__UrlCorrectlyBuilt", null);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

93824

decreased by-5.99%

Lines of code

1280

decreased by-5.67%

No dependency changes