@syncfusion/ej2-spreadsheet - npm Package Compare versions

Comparing version 24.2.4 to 24.2.5

CHANGELOG.md

@@ -5,2 +5,10 @@ # Changelog
 
+## 24.2.4 (2024-02-06)
+
+### Spreadsheet
+
+#### Bug Fixes
+
+- Issue with "formula returns the wrong result when performing an arithmetic expression with a negative sign" has been resolved.
+
 ## 24.1.41 (2023-12-18)
@@ -7,0 +15,0 @@

dist/global/index.d.ts

 /*!
 *  filename: index.d.ts
-*  version : 24.2.4
+*  version : 24.2.5
 *  Copyright Syncfusion Inc. 2001 - 2023. All rights reserved.
@@ -5,0 +5,0 @@ *  Use of this code is subject to the terms of our license.

package.json

 {
   "_from": "@syncfusion/ej2-spreadsheet@*",
-  "_id": "@syncfusion/ej2-spreadsheet@24.2.3",
+  "_id": "@syncfusion/ej2-spreadsheet@24.2.4",
   "_inBundle": false,
-  "_integrity": "sha512-a8f3FXw09EsPNENoJWT19epbXO8kyr17QzXBZVbvaevhPen+Qt3yD8YOkoNPE7HYMiVyJQT+qBPIK+uZ1m1R7A==",
+  "_integrity": "sha512-ZrsgHMN0CzpFEjfb+yGudVvUH7SL25uJqqoQNSUEbXbmeY2nlpoxW76FncHKfnqChi0LhvFTq+t0lNeO2lBnag==",
   "_location": "/@syncfusion/ej2-spreadsheet",
@@ -26,4 +26,4 @@ "_phantomChildren": {},
   ],
-  "_resolved": "https://nexus.syncfusion.com/repository/ej2-hotfix-new/@syncfusion/ej2-spreadsheet/-/ej2-spreadsheet-24.2.3.tgz",
-  "_shasum": "37cdaafb9db696905674365e3056c6420876bb26",
+  "_resolved": "https://nexus.syncfusioninternal.com/repository/ej2-hotfix-new/@syncfusion/ej2-spreadsheet/-/ej2-spreadsheet-24.2.4.tgz",
+  "_shasum": "fcb5689095f81ac70cb5496219a5fc90e326bee6",
   "_spec": "@syncfusion/ej2-spreadsheet@*",
@@ -36,6 +36,6 @@ "_where": "/jenkins/workspace/elease-automation_release_24.1.1/packages/included",
   "dependencies": {
-    "@syncfusion/ej2-base": "~24.2.3",
-    "@syncfusion/ej2-charts": "~24.2.4",
-    "@syncfusion/ej2-dropdowns": "~24.2.4",
-    "@syncfusion/ej2-grids": "~24.2.4",
+    "@syncfusion/ej2-base": "~24.2.5",
+    "@syncfusion/ej2-charts": "~24.2.5",
+    "@syncfusion/ej2-dropdowns": "~24.2.5",
+    "@syncfusion/ej2-grids": "~24.2.5",
     "@syncfusion/ej2-navigations": "~24.2.4"
@@ -84,5 +84,5 @@ },
   "typings": "index.d.ts",
-  "version": "24.2.4",
+  "version": "24.2.5",
   "sideEffects": true,
   "homepage": "https://www.syncfusion.com/javascript-ui-controls"
 }

src/ribbon/ribbon.js

@@ -134,4 +134,8 @@ var __extends = (this && this.__extends) || (function () {
         }
-        this.toolbarObj.destroy();
-        this.tabObj.destroy();
+        if (this.toolbarObj) {
+            this.toolbarObj.destroy();
+        }
+        if (this.tabObj) {
+            this.tabObj.destroy();
+        }
         this.element.innerHTML = '';
@@ -138,0 +142,0 @@ this.toolbarObj = null;

src/spreadsheet/actions/edit.d.ts

@@ -76,3 +76,3 @@ import { Spreadsheet } from '../index';
     endEdit(refreshFormulaBar?: boolean, event?: MouseEvent & TouchEvent | KeyboardEventArgs, isPublic?: boolean): void;
-    cancelEdit(refreshFormulaBar?: boolean, trigEvent?: boolean, event?: MouseEvent & TouchEvent | KeyboardEventArgs): void;
+    cancelEdit(refreshFormulaBar?: boolean, trigEvent?: boolean, event?: MouseEvent & TouchEvent | KeyboardEventArgs, isInternal?: boolean): void;
     private focusElement;
@@ -79,0 +79,0 @@ private triggerEvent;

src/spreadsheet/actions/resize.js

@@ -8,3 +8,3 @@ import { getDPRValue, hideAutoFillElement, hideAutoFillOptions, positionAutoFillElement } from '../index';
 import { getColumn, setRow, getCell } from '../../workbook/base/index';
-import { getRangeIndexes, getSwapRange, getCellIndexes, setMerge, isRowSelected } from '../../workbook/common/index';
+import { getRangeIndexes, getSwapRange, getCellIndexes, setMerge, isRowSelected, beginAction } from '../../workbook/common/index';
 import { getFormattedCellObject, hideShow } from '../../workbook/common/index';
@@ -98,3 +98,3 @@ /**
     Resize.prototype.mouseDownHandler = function (e) {
-        if (!closest(e.target, '.e-header-cell')) {
+        if (!closest(e.target, '.e-header-cell') || e.target.className.includes('e-filter-icon')) {
             return;
@@ -142,3 +142,3 @@ }
     Resize.prototype.dblClickHandler = function (e) {
-        if (!closest(e.target, '.e-header-cell')) {
+        if (!closest(e.target, '.e-header-cell') || e.target.className.includes('e-filter-icon')) {
             return;
@@ -155,3 +155,3 @@ }
             else {
-                this.setAutofit(colIndx, true, prevWidth);
+                this.setAutofit(colIndx, true, prevWidth, this.trgtEle);
             }
@@ -167,3 +167,3 @@ }
     Resize.prototype.setTarget = function (e) {
-        if (!closest(e.target, '.e-header-cell')) {
+        if (!closest(e.target, '.e-header-cell') || e.target.className.includes('e-filter-icon')) {
             return;
@@ -341,6 +341,24 @@ }
     };
-    Resize.prototype.setAutofit = function (idx, isCol, prevData) {
+    Resize.prototype.setAutofit = function (idx, isCol, prevData, hdrCell) {
+        var _this = this;
         var sheet = this.parent.getActiveSheet();
+        var includeHeader;
+        if (hdrCell) {
+            var eventArgs = { cancel: false, index: idx, isCol: isCol,
+                sheetIndex: this.parent.activeSheetIndex };
+            if (isCol) {
+                eventArgs.oldWidth = prevData;
+                eventArgs.includeHeader = false;
+            }
+            else {
+                eventArgs.oldHeight = prevData;
+            }
+            this.parent.notify(beginAction, { eventArgs: eventArgs, action: 'resizeToFit' });
+            if (eventArgs.cancel) {
+                return;
+            }
+            includeHeader = eventArgs.includeHeader;
+        }
         var oldValue;
-        var cell;
+        var cell = {};
         var cellEle;
@@ -354,20 +372,26 @@ var colGrp;
         if (isCol) {
-            var row = void 0;
+            var row_1;
             table.style.width = 'auto';
+            var appendRow = function (content) {
+                cellEle = tdEle.cloneNode();
+                cellEle.textContent = content;
+                cellEle.style.fontFamily = (cell.style && cell.style.fontFamily) || _this.parent.cellStyle.fontFamily;
+                cellEle.style.fontSize = (cell.style && cell.style.fontSize) || _this.parent.cellStyle.fontSize;
+                row_1 = rowEle.cloneNode();
+                row_1.appendChild(cellEle);
+                tBody.appendChild(row_1);
+            };
+            if (includeHeader) {
+                appendRow(hdrCell.textContent);
+            }
             for (var rowIdx = 0, len = sheet.rows.length; rowIdx < len; rowIdx++) {
                 cell = getCell(rowIdx, idx, sheet);
                 if (cell) {
-                    cellEle = tdEle.cloneNode();
                     if (cell.wrap) {
                         wrapCell = true;
-                        cellEle.textContent = this.getWrapText(this.parent.getDisplayText(cell), getExcludedColumnWidth(sheet, idx, idx, cell.colSpan > 1 ? idx + cell.colSpan - 1 : idx), cell.style);
+                        appendRow(this.getWrapText(this.parent.getDisplayText(cell), getExcludedColumnWidth(sheet, idx, idx, cell.colSpan > 1 ? idx + cell.colSpan - 1 : idx), cell.style));
                     }
                     else {
-                        cellEle.textContent = this.parent.getDisplayText(cell);
+                        appendRow(this.parent.getDisplayText(cell));
                     }
-                    cellEle.style.fontFamily = (cell.style && cell.style.fontFamily) || this.parent.cellStyle.fontFamily;
-                    cellEle.style.fontSize = (cell.style && cell.style.fontSize) || this.parent.cellStyle.fontSize;
-                    row = rowEle.cloneNode();
-                    row.appendChild(cellEle);
-                    tBody.appendChild(row);
                 }
@@ -374,0 +398,0 @@ }

src/spreadsheet/base/spreadsheet-model.d.ts

@@ -350,2 +350,19 @@ import { Property, NotifyPropertyChanges, INotifyPropertyChanged, ModuleDeclaration, Event, isUndefined, attributes } from '@syncfusion/ej2-base';import { addClass, removeClass, EmitType, Complex, formatUnit, L10n, isNullOrUndefined, Browser } from '@syncfusion/ej2-base';import { detach, select, closest, setStyleAttribute, EventHandler, getComponent } from '@syncfusion/ej2-base';import { MenuItemModel, BeforeOpenCloseMenuEventArgs, ItemModel } from '@syncfusion/ej2-navigations';import { mouseDown, spreadsheetDestroyed, keyUp, BeforeOpenEventArgs, clearViewer, refreshSheetTabs, positionAutoFillElement } from '../common/index';import { performUndoRedo, overlay, DialogBeforeOpenEventArgs, createImageElement, deleteImage, removeHyperlink } from '../common/index';import { HideShowEventArgs, sheetNameUpdate, updateUndoRedoCollection, getUpdateUsingRaf, setAutoFit } from '../common/index';import { actionEvents, CollaborativeEditArgs, keyDown, enableFileMenuItems, hideToolbarItems, updateAction } from '../common/index';import { ICellRenderer, colWidthChanged, rowHeightChanged, hideRibbonTabs, addFileMenuItems, getSiblingsHeight } from '../common/index';import { defaultLocale, locale, setResize, initiateFilterUI, clearFilter, focus, removeDesignChart } from '../common/index';import { CellEditEventArgs, CellSaveEventArgs, ribbon, formulaBar, sheetTabs, formulaOperation, addRibbonTabs } from '../common/index';import { addContextMenuItems, removeContextMenuItems, enableContextMenuItems, selectRange, addToolbarItems } from '../common/index';import { cut, copy, paste, PasteSpecialType, dialog, editOperation, activeSheetChanged, refreshFormulaDatasource } from '../common/index';import { Render } from '../renderer/render';import { Scroll, VirtualScroll, Edit, CellFormat, Selection, KeyboardNavigation, KeyboardShortcut, WrapText } from '../actions/index';import { Clipboard, ShowHide, UndoRedo, SpreadsheetHyperlink, Resize, Insert, Delete, FindAndReplace, Merge, AutoFill } from '../actions/index';import { ProtectSheet } from '../actions/index';import { CellRenderEventArgs, IRenderer, IViewport, OpenOptions, MenuSelectEventArgs, click, hideFileMenuItems } from '../common/index';import { Dialog, ActionEvents, Overlay } from '../services/index';import { ServiceLocator } from '../../workbook/services/index';import { SheetModel, getColumnsWidth, getSheetIndex, WorkbookHyperlink, HyperlinkModel, DefineNameModel } from './../../workbook/index';import { BeforeHyperlinkArgs, AfterHyperlinkArgs, FindOptions, ValidationModel, getCellAddress, getColumnHeaderText } from './../../workbook/common/index';import { BeforeCellFormatArgs, afterHyperlinkCreate, getColIndex, CellStyleModel, setLinkModel } from './../../workbook/index';import { BeforeSaveEventArgs, SaveCompleteEventArgs, WorkbookInsert, WorkbookDelete, WorkbookMerge } from './../../workbook/index';import { getSheetNameFromAddress, DataBind, CellModel, beforeHyperlinkCreate, DataSourceChangedEventArgs } from './../../workbook/index';import { BeforeSortEventArgs, SortOptions, sortComplete, SortEventArgs, dataSourceChanged, isHiddenRow, isHiddenCol } from './../../workbook/index';import { getSheetIndexFromId, WorkbookEdit, WorkbookOpen, WorkbookSave, WorkbookCellFormat, WorkbookSort, getSheet } from './../../workbook/index';import { FilterOptions, FilterEventArgs, ProtectSettingsModel, findKeyUp, refreshRibbonIcons, hideShow } from './../../workbook/index';import { Workbook } from '../../workbook/base/workbook';import { getRequiredModules, ScrollSettings, ScrollSettingsModel, SelectionSettingsModel, enableToolbarItems } from '../common/index';import { SelectionSettings, BeforeSelectEventArgs, SelectEventArgs, getStartEvent, enableRibbonTabs, getDPRValue } from '../common/index';import { createSpinner, showSpinner, hideSpinner } from '@syncfusion/ej2-popups';import { setRowHeight, getRowsHeight, getColumnWidth, getRowHeight, getCell } from './../../workbook/base/index';import { getRangeIndexes, getIndexesFromAddress, getCellIndexes, WorkbookNumberFormat, WorkbookFormula } from '../../workbook/index';import { RefreshValueArgs, Ribbon, FormulaBar, SheetTabs, Open, ContextMenu, Save, NumberFormat, Formula } from '../integrations/index';import { Sort, Filter, SpreadsheetImage, SpreadsheetChart } from '../integrations/index';import { isNumber, getColumn, WorkbookFilter, refreshInsertDelete, InsertDeleteEventArgs, RangeModel } from '../../workbook/index';import { PredicateModel } from '@syncfusion/ej2-grids';import { RibbonItemModel } from '../../ribbon/index';import { DataValidation } from '../actions/index';import { WorkbookDataValidation, WorkbookConditionalFormat, WorkbookFindAndReplace, WorkbookAutoFill } from '../../workbook/actions/index';import { FindAllArgs, findAllValues, ClearOptions, ConditionalFormatModel, ImageModel, getFormattedCellObject } from './../../workbook/common/index';import { ConditionalFormatting } from '../actions/conditional-formatting';import { WorkbookImage, WorkbookChart, updateView, focusChartBorder } from '../../workbook/index';import { WorkbookProtectSheet } from '../../workbook/actions/index';import { contentLoaded, completeAction, freeze, ConditionalFormatEventArgs, refreshOverlayElem, insertDesignChart } from '../common/index';import { beginAction, sheetsDestroyed, workbookFormulaOperation, getRangeAddress, cellValidation } from './../../workbook/common/index';import { updateScroll, SelectionMode, clearCopy, isImported, clearUndoRedoCollection, clearChartBorder } from '../common/index';
     /**
+     * Triggers when the cell has been edited.
+     * ```html
+     * <div id='Spreadsheet'></div>
+     * ```
+     * ```typescript
+     * new Spreadsheet({
+     *       cellEdited: (args: CellEditEventArgs) => {
+     *       }
+     *      ...
+     *  }, '#Spreadsheet');
+     * ```
+     *
+     * @event cellEdited
+     */
+    cellEdited?: EmitType<CellEditEventArgs>;
+
+    /**
      * Triggers every time a request is made to access cell information.
@@ -352,0 +369,0 @@ * This will be triggered when editing a cell.

src/spreadsheet/base/spreadsheet.d.ts

@@ -357,2 +357,18 @@ /// <reference path="../../workbook/base/workbook-model.d.ts" />
     /**
+     * Triggers when the cell has been edited.
+     * ```html
+     * <div id='Spreadsheet'></div>
+     * ```
+     * ```typescript
+     * new Spreadsheet({
+     *       cellEdited: (args: CellEditEventArgs) => {
+     *       }
+     *      ...
+     *  }, '#Spreadsheet');
+     * ```
+     *
+     * @event cellEdited
+     */
+    cellEdited: EmitType<CellEditEventArgs>;
+    /**
      * Triggers every time a request is made to access cell information.
@@ -359,0 +375,0 @@ * This will be triggered when editing a cell.

src/spreadsheet/common/interface.d.ts

@@ -70,2 +70,3 @@ import { CellModel, BeforeSortEventArgs, SheetModel, ImageModel, ChartType, ConditionalFormatModel, AutoFillDirection, AutoFillType, ChartModel, MarkerSettingsModel } from './../../workbook/index';
     criteria?: string[];
+    enableColumnHeaderFiltering?: boolean;
 }
@@ -72,0 +73,0 @@ /**

src/spreadsheet/common/util.d.ts

@@ -437,1 +437,5 @@ import { StyleType, CollaborativeEditArgs, IAriaOptions } from './index';
 export declare function addDPRValue(size: number): number;
+/**
+ * @hidden
+ */
+export declare function getSheetProperties(context: Spreadsheet, keys?: string[]): string;

src/spreadsheet/integrations/color-picker.js

@@ -139,5 +139,7 @@ import { ColorPicker as ColorPickerComponent } from '@syncfusion/ej2-inputs';
     ColorPicker.prototype.removeEventListener = function () {
-        this.parent.off(beforeRibbonCreate, this.render);
-        this.parent.off('destroyRibbonComponents', this.destroy);
-        this.parent.on(spreadsheetDestroyed, this.destroy, this);
+        if (!this.parent.isDestroyed) {
+            this.parent.off(beforeRibbonCreate, this.render);
+            this.parent.off('destroyRibbonComponents', this.destroy);
+            this.parent.off(spreadsheetDestroyed, this.destroy);
+        }
     };
@@ -144,0 +146,0 @@ return ColorPicker;

src/spreadsheet/integrations/filter.d.ts

@@ -86,2 +86,3 @@ import { Spreadsheet } from '../index';
      * @param {boolean} useFilterRange - Specifies whether to consider filtering range or used range during filering.
+     * @param {boolean} enableColumnHeaderFiltering - Specifies whether to consider first row during filtering.
      * @returns {void} - Processes the range if no filter applied.
@@ -117,3 +118,2 @@ */
     private renderFilterCellHandler;
-    private getFilterSortClassName;
     /**
@@ -125,2 +125,3 @@ * Refreshes the filter header range.
      * @param {number} sIdx - Specify the index.
+     * @param {boolean} enableColumnHeaderFiltering - Specifies whether to consider first row during filtering.
      * @returns {void} - Refreshes the filter header range.
@@ -127,0 +128,0 @@ */

src/spreadsheet/integrations/sort.js

@@ -533,3 +533,3 @@ import { initiateCustomSort, locale, dialog, getFilterRange } from '../index';
             range[3] = sheet.usedRange.colIndex;
-            sortOptions.containsHeader = true;
+            sortOptions.containsHeader = !eventArgs.enableColumnHeaderFiltering;
             isSingle = false;
@@ -536,0 +536,0 @@ }

src/spreadsheet/renderer/cell.js

@@ -44,2 +44,3 @@ import { inView, renderFilterCell } from '../common/index';
         this.parent.trigger('beforeCellRender', { cell: null, element: headerCell, address: headerText, colIndex: index });
+        this.parent.notify(renderFilterCell, { td: headerCell, rowIndex: 0, colIndex: index });
         attributes(headerCell, { 'aria-colindex': (index + 1).toString(), 'tabindex': '-1' });
@@ -46,0 +47,0 @@ };

src/spreadsheet/services/overlay.js

@@ -451,8 +451,15 @@ import { removeDesignChart, clearChartBorder } from '../index';
         }
-        EventHandler.remove(this.parent.element.querySelector('#' + this.parent.element.id + '_sheet'), getMoveEvent(), this.overlayMouseMoveHandler);
-        EventHandler.remove(document, getEndEvent(), this.overlayMouseUpHandler);
-        this.parent.off(overlayEleSize, this.setOriginalSize);
-        this.parent.off(selectionStatus, this.isOverlaySelected);
-        this.parent.off(refreshOverlayElem, this.refreshOverlayElem);
-        this.parent.off(spreadsheetDestroyed, this.destroy);
+        var ele = this.parent.element.querySelector('#' + this.parent.element.id + '_sheet');
+        if (ele) {
+            EventHandler.remove(ele, getMoveEvent(), this.overlayMouseMoveHandler);
+        }
+        if (document) {
+            EventHandler.remove(document, getEndEvent(), this.overlayMouseUpHandler);
+        }
+        if (!this.parent.isDestroyed) {
+            this.parent.off(overlayEleSize, this.setOriginalSize);
+            this.parent.off(selectionStatus, this.isOverlaySelected);
+            this.parent.off(refreshOverlayElem, this.refreshOverlayElem);
+            this.parent.off(spreadsheetDestroyed, this.destroy);
+        }
     };
@@ -459,0 +466,0 @@ /**

src/workbook/integrations/save.d.ts

@@ -96,2 +96,3 @@ import { Workbook } from '../base/index';
     private initiateFullPostSave;
+    private performStringifyAction;
     /**
@@ -98,0 +99,0 @@ * Get stringified workbook object.

src/workbook/integrations/save.js

@@ -80,2 +80,3 @@ var __extends = (this && this.__extends) || (function () {
         this.parent.on(events.beginSave, this.initiateSave, this);
+        this.parent.on('getStringifyObject', this.performStringifyAction, this);
     };
@@ -89,2 +90,3 @@ /**
             this.parent.off(events.beginSave, this.initiateSave);
+            this.parent.off('getStringifyObject', this.performStringifyAction);
         }
@@ -301,2 +303,9 @@ };
     };
+    WorkbookSave.prototype.performStringifyAction = function (args) {
+        args.model = '{"jsonObject":{"Workbook":{"sheets":[';
+        for (var sheetIdx = 0, sheetCount = this.parent.sheets.length - 1; sheetIdx <= sheetCount; sheetIdx++) {
+            args.model += this.getStringifyObject(this.parent.sheets[sheetIdx], args.skipProps, sheetIdx) +
+                (sheetIdx < sheetCount ? ',' : ']}}}');
+        }
+    };
     /**
@@ -303,0 +312,0 @@ * Get stringified workbook object.

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

45245903

increased by0.22%

Lines of code

376204

increased by0.17%

Dependency changes

• Updated@syncfusion/ej2-base@~24.2.5

• Updated@syncfusion/ej2-charts@~24.2.5

• Updated@syncfusion/ej2-dropdowns@~24.2.5

• Updated@syncfusion/ej2-grids@~24.2.5