@the-convocation/venat-module-xiv-market - npm Package Compare versions

Comparing version 0.1.6 to 0.1.7

CHANGELOG.md

@@ -6,2 +6,6 @@ # Change Log
 
+## [0.1.7](https://github.com/the-convocation/venat/compare/v0.1.6...v0.1.7) (2022-05-16)
+
+**Note:** Version bump only for package @the-convocation/venat-module-xiv-market
+
 ## [0.1.6](https://github.com/the-convocation/venat/compare/v0.1.5...v0.1.6) (2022-05-16)
@@ -8,0 +12,0 @@

dist/src/data/listings.js

@@ -7,3 +7,3 @@ "use strict";
         const itemLookup = await getItemIdByName(itemName);
-        if (itemLookup.err != null) {
+        if (!itemLookup.success) {
             logError(itemLookup.err.message, itemLookup.err.stack);
@@ -17,3 +17,3 @@ return 'Failed to access XIVAPI; please try again later.';
         const marketLookup = await getMarketInfo(item.ID, server);
-        if (marketLookup.err != null) {
+        if (!marketLookup.success) {
             logError(marketLookup.err.message, marketLookup.err.stack);
@@ -20,0 +20,0 @@ return 'The item could not be found; please check your spelling of the server and try again.';

dist/src/data/universalis.js

@@ -11,3 +11,6 @@ "use strict";
     catch (err) {
-        return { value: null, success: false, err };
+        if (!(err instanceof Error)) {
+            throw err;
+        }
+        return { success: false, err };
     }
@@ -14,0 +17,0 @@ return { value: res.data, success: true };

dist/src/data/xivapi.js

@@ -11,3 +11,6 @@ "use strict";
     catch (err) {
-        return { value: null, success: false, err };
+        if (!(err instanceof Error)) {
+            throw err;
+        }
+        return { success: false, err };
     }
@@ -20,5 +23,8 @@ const nameLower = name.toLowerCase();
     }
-    return { value: null, success: false };
+    return {
+        err: new Error(`The item ${name} could not be found.`),
+        success: false,
+    };
 }
 exports.getItemIdByName = getItemIdByName;
 //# sourceMappingURL=xivapi.js.map

package.json

 {
   "name": "@the-convocation/venat-module-xiv-market",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "packageManager": "yarn@3.2.1",
@@ -11,3 +11,3 @@ "main": "dist/src/module.js",
   "dependencies": {
-    "@the-convocation/venat-core": "^0.1.4"
+    "@the-convocation/venat-core": "^0.1.7"
   },
@@ -17,3 +17,3 @@ "publishConfig": {
   },
-  "gitHead": "c0fec7a7f89105922c97330ec52bfb3a7f6ed91e"
+  "gitHead": "ed5d2c3f91ee44b382ee41aac4a774cfcefc5c62"
 }

src/data/listings.ts

@@ -35,3 +35,3 @@ import { LookupResult } from '@the-convocation/venat-core';
     const itemLookup = await getItemIdByName(itemName);
-    if (itemLookup.err != null) {
+    if (!itemLookup.success) {
       logError(itemLookup.err.message, itemLookup.err.stack);
@@ -47,3 +47,3 @@ return 'Failed to access XIVAPI; please try again later.';
     const marketLookup = await getMarketInfo(item.ID, server);
-    if (marketLookup.err != null) {
+    if (!marketLookup.success) {
       logError(marketLookup.err.message, marketLookup.err.stack);
@@ -50,0 +50,0 @@ return 'The item could not be found; please check your spelling of the server and try again.';

src/data/universalis.ts

@@ -28,3 +28,6 @@ import axios, { AxiosResponse } from 'axios';
   } catch (err) {
-    return { value: null, success: false, err };
+    if (!(err instanceof Error)) {
+      throw err;
+    }
+    return { success: false, err };
   }
@@ -31,0 +34,0 @@

src/data/xivapi.ts

@@ -22,3 +22,6 @@ import axios, { AxiosResponse } from 'axios';
   } catch (err) {
-    return { value: null, success: false, err };
+    if (!(err instanceof Error)) {
+      throw err;
+    }
+    return { success: false, err };
   }
@@ -33,3 +36,6 @@
 
-  return { value: null, success: false };
+  return {
+    err: new Error(`The item ${name} could not be found.`),
+    success: false,
+  };
 }

src/dto/market.dto.ts

@@ -12,3 +12,3 @@ import { Param } from '@discord-nestjs/core';
   })
-  public item: string;
+  public item!: string;
 
@@ -21,3 +21,3 @@ @Transform(cleanText)
   })
-  public server: string;
+  public server!: string;
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

237165

increased by0.25%

Lines of code

506

increased by3.69%

Dependency changes

• Updated@the-convocation/venat-core@^0.1.7