@twilio/rtc-diagnostics - npm Package Compare versions

Comparing version 1.0.0 to 1.0.1

CHANGELOG.md

@@ -0,1 +1,9 @@
+1.0.1 (Jan 30, 2023)
+====================
+
+Bug Fixes
+---------
+
+* Fixed a bug on iOS 16 Safari where the user could not play back the audio recorded during an audio output test. This is due to the following [WebKit bug](https://bugs.webkit.org/show_bug.cgi?id=249250). (VIDEO-11571)
+
 1.0.0 (Nov 3, 2020)
@@ -2,0 +10,0 @@ ===================

es5/lib/AudioInputTest.js

@@ -350,2 +350,5 @@ "use strict";
                         }
+                        else if (typeof Error !== 'undefined' && error_1 instanceof Error) {
+                            this._onError(new errors_1.DiagnosticError(error_1, 'An error has occurred.'));
+                        }
                         else {
@@ -352,0 +355,0 @@ this._onError(new errors_1.DiagnosticError(undefined, 'Unknown error occurred.'));

es5/lib/AudioOutputTest.js

@@ -299,2 +299,5 @@ "use strict";
                         }
+                        else if (typeof Error !== 'undefined' && error_1 instanceof Error) {
+                            this._onError(new errors_1.DiagnosticError(error_1, 'An error has occurred.'));
+                        }
                         else {
@@ -301,0 +304,0 @@ this._onError(new errors_1.DiagnosticError(undefined, 'Unknown error occurred.'));

es5/lib/recorder/audio.js

@@ -67,4 +67,6 @@ "use strict";
     AudioRecorder.prototype._generateObjectUrl = function () {
-        // Use wav for faster and simple encoding
-        var blob = new Blob(this._audioData, { type: 'audio/wav' });
+        // Select default browser mime type if it exists.
+        // Otherwise, use wav for faster and simple encoding.
+        var type = this._mediaRecorder && this._mediaRecorder.mimeType ? this._mediaRecorder.mimeType : 'audio/wav';
+        var blob = new Blob(this._audioData, { type: type });
         this._url = URL.createObjectURL(blob);
@@ -71,0 +73,0 @@ this._audioData = [];

es5/lib/types.d.ts

@@ -65,2 +65,3 @@ /**
     interface MediaRecorder {
+        mimeType?: string;
         ondataavailable: Function;
@@ -67,0 +68,0 @@ onstop: Function;

es5/lib/VideoInputTest.js

@@ -232,2 +232,5 @@ "use strict";
                         }
+                        else if (typeof Error !== 'undefined' && error_1 instanceof Error) {
+                            this._onError(new errors_1.DiagnosticError(error_1, 'An error has occurred.'));
+                        }
                         else {
@@ -234,0 +237,0 @@ this._onError(new errors_1.DiagnosticError(undefined, 'Unknown error occurred.'));

es5/package.d.ts

@@ -30,2 +30,3 @@ export declare const name: string;
 export declare const devDependencies: {
+    "@types/mime": string;
     "@types/mocha": string;
@@ -32,0 +33,0 @@ "@types/request": string;

es5/package.json

 {
     "name": "@twilio/rtc-diagnostics",
-    "version": "1.0.0",
+    "version": "1.0.1",
     "description": "Various diagnostics functions to help analyze connections to Twilio",
@@ -42,2 +42,3 @@ "main": "./es5/lib/diagnostics.js",
     "devDependencies": {
+        "@types/mime": "2.0.2",
         "@types/mocha": "5.2.7",
@@ -68,5 +69,5 @@ "@types/request": "^2.48.5",
         "typedoc-plugin-as-member-of": "1.0.2",
-        "typedoc-plugin-external-module-name": "3.0.0",
+        "typedoc-plugin-external-module-name": "4.0.6",
         "typedoc-plugin-internal-external": "2.1.1",
-        "typedoc-twilio-theme": "github:charliesantos/typedoc-twilio-theme#1.0.1",
+        "typedoc-twilio-theme": "1.0.1",
         "typescript": "3.7.2",
@@ -73,0 +74,0 @@ "vinyl-fs": "3.0.3",

lib/AudioInputTest.ts

@@ -514,2 +514,9 @@ import { EventEmitter } from 'events';
         ));
+      } else if (
+        typeof Error !== 'undefined' && error instanceof Error
+      ) {
+        this._onError(new DiagnosticError(
+          error,
+          'An error has occurred.',
+        ));
       } else {
@@ -516,0 +523,0 @@ this._onError(new DiagnosticError(

lib/AudioOutputTest.ts

@@ -413,2 +413,9 @@ import { EventEmitter } from 'events';
         ));
+      } else if (
+        typeof Error !== 'undefined' && error instanceof Error
+      ) {
+        this._onError(new DiagnosticError(
+          error,
+          'An error has occurred.',
+        ));
       } else {
@@ -415,0 +422,0 @@ this._onError(new DiagnosticError(

lib/recorder/audio.ts

@@ -78,4 +78,6 @@ import { DiagnosticError } from '../errors';
   private _generateObjectUrl(): void {
-    // Use wav for faster and simple encoding
-    const blob = new Blob(this._audioData, { type: 'audio/wav' });
+    // Select default browser mime type if it exists.
+    // Otherwise, use wav for faster and simple encoding.
+    const type: string = this._mediaRecorder && this._mediaRecorder.mimeType ? this._mediaRecorder.mimeType : 'audio/wav';
+    const blob = new Blob(this._audioData, { type });
     this._url = URL.createObjectURL(blob);
@@ -82,0 +84,0 @@ this._audioData = [];

lib/types.ts

@@ -73,2 +73,3 @@ // Typescript doesn't yet support `setSinkId`, so we want to add it to the
   export interface MediaRecorder {
+    mimeType?: string;
     ondataavailable: Function;
@@ -75,0 +76,0 @@ onstop: Function;

lib/VideoInputTest.ts

@@ -277,2 +277,9 @@ import { EventEmitter } from 'events';
         ));
+      } else if (
+        typeof Error !== 'undefined' && error instanceof Error
+      ) {
+        this._onError(new DiagnosticError(
+          error,
+          'An error has occurred.',
+        ));
       } else {
@@ -279,0 +286,0 @@ this._onError(new DiagnosticError(

LICENSE.md

 The following license applies to all parts of this software except as
 documented below.
 
-    Copyright (C) 2019-2020 Twilio, inc.
+    Copyright (C) 2019-2023 Twilio, inc.
  
@@ -6,0 +6,0 @@ Licensed under the Apache License, Version 2.0 (the "License");

package.json

 {
   "name": "@twilio/rtc-diagnostics",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Various diagnostics functions to help analyze connections to Twilio",
@@ -42,2 +42,3 @@ "main": "./es5/lib/diagnostics.js",
   "devDependencies": {
+    "@types/mime": "2.0.2",
     "@types/mocha": "5.2.7",
@@ -68,5 +69,5 @@ "@types/request": "^2.48.5",
     "typedoc-plugin-as-member-of": "1.0.2",
-    "typedoc-plugin-external-module-name": "3.0.0",
+    "typedoc-plugin-external-module-name": "4.0.6",
     "typedoc-plugin-internal-external": "2.1.1",
-    "typedoc-twilio-theme": "github:charliesantos/typedoc-twilio-theme#1.0.1",
+    "typedoc-twilio-theme": "1.0.1",
     "typescript": "3.7.2",
@@ -73,0 +74,0 @@ "vinyl-fs": "3.0.3",

README.md

@@ -13,3 +13,2 @@ # RTC Diagnostics SDK
 ## Prerequisites
-* A Twilio account. Sign up for free [here](https://www.twilio.com/try-twilio)
 * Node.js v12+
@@ -16,0 +15,0 @@ * NPM v6+ (comes installed with newer Node versions)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

493718

increased by0.67%

Lines of code

8120

increased by0.46%

Worsened metrics

Dev dependency count

32

increased by3.23%

Number of lines in readme file

185

decreased by-0.54%

No dependency changes