@ui-grid/core - npm Package Compare versions

Comparing version 4.8.1 to 4.8.2

CHANGELOG.md

@@ -6,2 +6,14 @@ # Change Log
 
+## [4.8.2](https://github.com/angular-ui/ui-grid/compare/v4.8.1...v4.8.2) (2019-10-07)
+
+
+### Bug Fixes
+
+* **core:** scrollToIfNecessary not properly including rowHeight on downward scrolls ([7a0e1dc](https://github.com/angular-ui/ui-grid/commit/7a0e1dc))
+* **scrolling:** column footers misaligned with data [#6909](https://github.com/angular-ui/ui-grid/issues/6909) ([74f9107](https://github.com/angular-ui/ui-grid/commit/74f9107))
+
+
+
+
+
 ## [4.8.1](https://github.com/angular-ui/ui-grid/compare/v4.8.0...v4.8.1) (2019-06-27)
@@ -8,0 +20,0 @@

package.json

 {
   "name": "@ui-grid/core",
-  "version": "4.8.1",
+  "version": "4.8.2",
   "description": "A data grid for Angular",
@@ -35,3 +35,3 @@ "main": "index.js",
   "license": "MIT",
-  "gitHead": "3fa72bae9dc2b7ec619d2c44b5eba4c9b5cf1a6d"
+  "gitHead": "c4ec5a4a0f90b5d665b5acb8ffa23e4c772962ad"
 }

src/js/directives/ui-grid-header-cell.js

@@ -164,4 +164,5 @@ (function() {
             $scope.handleKeyDown = function(event) {
-              if (event.keyCode === 32) {
+              if (event.keyCode === 32 || event.keyCode === 13) {
                 event.preventDefault();
+                $scope.handleClick(event);
               }
@@ -168,0 +169,0 @@ };

test/core/directives/ui-grid-header-cell.spec.js

@@ -290,4 +290,4 @@ describe('uiGridHeaderCell', function() {
 			});
-			it('should not prevent default', function() {
-				expect(event.preventDefault).not.toHaveBeenCalled();
+			it('should prevent default', function() {
+				expect(event.preventDefault).toHaveBeenCalled();
 			});
@@ -294,0 +294,0 @@ });

No alert changes

Improved metrics

Total package byte prevSize

1455578

increased by77.86%

Number of package files

105

increased by3.96%

Lines of code

29572

increased by66.05%

No dependency changes