@ui5/builder - npm Package Compare versions

Comparing version 1.2.0 to 1.2.1

CHANGELOG.md

@@ -5,6 +5,12 @@ # Changelog
 
-A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v1.2.0...HEAD).
+A list of unreleased changes can be found [here](https://github.com/SAP/ui5-builder/compare/v1.2.1...HEAD).
 
+<a name="v1.2.1"></a>
+## [v1.2.1] - 2019-05-05
+### Bug Fixes
+- **SmartTemplateAnalyzer:** Detect dependencies from "pages" object [`2d400c2`](https://github.com/SAP/ui5-builder/commit/2d400c2ac0883ad57b4aa894c46a0dd5aecb070a)
+
+
 <a name="v1.2.0"></a>
-## [v1.2.0] - 2019-04-18
+## [v1.2.0] - 2019-04-25
 ### Features
@@ -171,2 +177,3 @@ - Add option to use hash signatures in cachebuster info file [`a4e8338`](https://github.com/SAP/ui5-builder/commit/a4e83383c7371cdde8573a901fdadd2ab243440e)
 
+[v1.2.1]: https://github.com/SAP/ui5-builder/compare/v1.2.0...v1.2.1
 [v1.2.0]: https://github.com/SAP/ui5-builder/compare/v1.1.1...v1.2.0
@@ -173,0 +180,0 @@ [v1.1.1]: https://github.com/SAP/ui5-builder/compare/v1.1.0...v1.1.1

lib/lbt/analyzer/SmartTemplateAnalyzer.js

@@ -84,13 +84,16 @@ /**
 		const st = (manifest && manifest["sap.ui.generic.app"]) || {};
+		function recursePage(page) {
+			if ( page.component && page.component.name ) {
+				const module = ModuleName.fromUI5LegacyName( page.component.name + ".Component" );
+				log.verbose("template app: add dependency to template component %s", module);
+				info.addDependency(module);
+				promises.push( that._analyzeTemplateComponent(module, page, info) );
+			}
+			recurse(page);
+		}
 		function recurse(ctx) {
-			if ( ctx.pages ) {
-				ctx.pages.forEach((page) => {
-					if ( page.component && page.component.name ) {
-						const module = ModuleName.fromUI5LegacyName( page.component.name + ".Component" );
-						log.verbose("template app: add dependency to template component %s", module);
-						info.addDependency(module);
-						promises.push( that._analyzeTemplateComponent(module, page, info) );
-					}
-					recurse(page);
-				});
+			if ( Array.isArray(ctx.pages) ) {
+				ctx.pages.forEach(recursePage);
+			} else if (typeof ctx.pages === "object") {
+				Object.values(ctx.pages).forEach(recursePage);
 			}
@@ -97,0 +100,0 @@ }

package.json

 {
 	"name": "@ui5/builder",
-	"version": "1.2.0",
+	"version": "1.2.1",
 	"description": "UI5 Tooling - Builder",
@@ -22,2 +22,3 @@ "author": "SAP SE (https://www.sap.com)",
 		"test": "npm run lint && npm run jsdoc-generate && npm run coverage",
+		"test-azure": "npm run lint && npm run jsdoc-generate && npm run coverage-xunit",
 		"lint": "eslint ./",
@@ -28,4 +29,6 @@ "unit": "rimraf test/tmp && ava",
 		"unit-nyan": "rimraf test/tmp && ava --tap | tnyan",
+		"unit-xunit": "rimraf test/tmp && ava --tap | tap-xunit --dontUseCommentsAsTestNames=true > test-results.xml",
 		"unit-inspect": "cross-env UI5_LOG_LVL=verbose node --inspect-brk node_modules/ava/profile.js",
 		"coverage": "nyc npm run unit",
+		"coverage-xunit": "nyc --reporter=text --reporter=text-summary --reporter=cobertura npm run unit-xunit",
 		"jsdoc": "npm run jsdoc-generate && opn jsdocs/index.html",
@@ -107,3 +110,3 @@ "jsdoc-generate": "node_modules/.bin/jsdoc -c ./jsdoc.json ./lib/ || (echo 'Error during JSDoc generation! Check log.' && exit 1)",
 		"graceful-fs": "^4.1.15",
-		"jsdoc": "^3.5.5",
+		"jsdoc": "^3.6.0",
 		"less-openui5": "^0.6.0",
@@ -115,2 +118,3 @@ "make-dir": "^2.1.0",
 		"semver": "^6.0.0",
+		"tap-xunit": "^2.3.0",
 		"tmp": "0.1.0",
@@ -133,3 +137,3 @@ "uglify-es": "^3.2.2",
 		"mock-require": "^3.0.3",
-		"nyc": "^14.0.0",
+		"nyc": "^14.1.0",
 		"opn-cli": "^4.1.0",
@@ -136,0 +140,0 @@ "recursive-readdir": "^2.1.1",

README.md

@@ -7,3 +7,3 @@ ![UI5 icon](https://raw.githubusercontent.com/SAP/ui5-tooling/master/docs/images/UI5_logo_wide.png)
 
-[![Travis CI Build Status](https://travis-ci.org/SAP/ui5-builder.svg?branch=master)](https://travis-ci.org/SAP/ui5-builder)
+[![Build Status](https://dev.azure.com/sap/opensource/_apis/build/status/SAP.ui5-builder?branchName=master)](https://dev.azure.com/sap/opensource/_build/latest?definitionId=26&branchName=master)
 [![npm Package Version](https://badge.fury.io/js/%40ui5%2Fbuilder.svg)](https://www.npmjs.com/package/@ui5/builder)
@@ -10,0 +10,0 @@ [![Coverage Status](https://coveralls.io/repos/github/SAP/ui5-builder/badge.svg)](https://coveralls.io/github/SAP/ui5-builder)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

584730

increased by0.14%

Lines of code

15439

increased by0.02%

Worsened metrics

Dependency count

21

increased by5%

Dependency changes

• + Addedtap-xunit@^2.3.0

• + Addedargparse@1.0.10(transitive)

• + Addedduplexer@0.1.2(transitive)

• + Addedevents-to-array@1.1.2(transitive)

• + Addedjs-yaml@3.14.1(transitive)

• + Addedminimist@1.2.8(transitive)

• + Addedsprintf-js@1.0.3(transitive)

• + Addedtap-parser@1.2.2(transitive)

• + Addedtap-xunit@2.4.1(transitive)

• + Addedthrough2@2.0.5(transitive)

• + Addedxmlbuilder@4.2.1(transitive)

• + Addedxtend@4.0.2(transitive)

• Updatedjsdoc@^3.6.0