@ui5/webcomponents-base - npm Package Compare versions

Comparing version 0.0.0-04e3a6f74 to 0.0.0-2db62badf

bundle.es5.js

@@ -11,3 +11,2 @@ // ES5 bundle targets IE11 only
 import { getNoConflict, setNoConflict } from "./dist/config/NoConflict.js";
-import { getCompactSize, setCompactSize } from "./dist/config/CompactSize.js";
 import { getRTL } from "./dist/config/RTL.js";
@@ -23,4 +22,2 @@ import { getFirstDayOfWeek } from "./dist/config/FormatSettings.js";
 	setNoConflict,
-	getCompactSize,
-	setCompactSize,
 	getCalendarType,
@@ -27,0 +24,0 @@ getRTL,

bundle.esm.js

@@ -16,3 +16,2 @@ import { registerThemeProperties } from "./dist/AssetRegistry.js";
 import "./dist/test-resources/elements/Child.js";
-import "./dist/test-resources/elements/DensityAware.js";
 import "./dist/test-resources/elements/GenericExt.js";
@@ -38,3 +37,2 @@
 import { getNoConflict, setNoConflict } from "./dist/config/NoConflict.js";
-import { getCompactSize, setCompactSize } from "./dist/config/CompactSize.js";
 import { getRTL } from "./dist/config/RTL.js";
@@ -51,4 +49,2 @@ import { getFirstDayOfWeek } from "./dist/config/FormatSettings.js";
 		setNoConflict,
-		getCompactSize,
-		setCompactSize,
 		getCalendarType,
@@ -55,0 +51,0 @@ getRTL,

dist/boot.js

 import whenDOMReady from "./util/whenDOMReady.js";
-import EventEnrichment from "./events/EventEnrichment.js";
 import insertFontFace from "./FontFace.js";
@@ -8,4 +7,2 @@ import { getTheme } from "./config/Theme.js";
 
-EventEnrichment.run();
-
 let bootPromise;
@@ -12,0 +9,0 @@

dist/delegate/ItemNavigation.js

@@ -22,3 +22,2 @@ import {
 		this.rowSize = options.rowSize || 1;
-		this.cyclic = options.cyclic || false;
 		this.behavior = options.behavior || ItemNavigationBehavior.Static;
@@ -25,0 +24,0 @@

dist/InitialConfiguration.js

@@ -8,3 +8,2 @@ let initialized = false;
 	language: null,
-	compactSize: false,
 	calendarType: null,
@@ -36,7 +35,2 @@ noConflict: false, // no URL
 
-const getCompactSize = () => {
-	initConfiguration();
-	return initialConfig.compactSize;
-};
-
 const getNoConflict = () => {
@@ -124,3 +118,2 @@ initConfiguration();
 	getLanguage,
-	getCompactSize,
 	getNoConflict,
@@ -127,0 +120,0 @@ getCalendarType,

dist/test-resources/specs/ConfigurationChange.spec.js

@@ -6,11 +6,2 @@ const assert = require("chai").assert;
 
-	it("Tests that compactSize can be changed", () => {
-		const res = browser.execute( () => {
-			const config = window['sap-ui-webcomponents-bundle'].configuration;
-			config.setCompactSize(true);
-			return config.getCompactSize();
-		});
-		assert.strictEqual(res, true, "compactSize changed to true");
-	});
-
 	it("Tests that theme can be changed", () => {
@@ -17,0 +8,0 @@ const newTheme = 'sap_belize_hcb';

dist/test-resources/specs/ConfigurationScript.spec.js

@@ -14,10 +14,2 @@ const assert = require("chai").assert;
 
-	it("Tests that compactSize is applied", () => {
-		const res = browser.execute( () => {
-			const config = window['sap-ui-webcomponents-bundle'].configuration;
-			return config.getCompactSize();
-		});
-		assert.strictEqual(res, true, "compactSize is true");
-	});
-
 	it("Tests that language is applied", () => {
@@ -24,0 +16,0 @@ const res = browser.execute( () => {

dist/test-resources/specs/ConfigurationURL.spec.js

 const assert = require("chai").assert;
 
 describe("Some settings can be set via URL params", () => {
-	browser.url("http://localhost:9191/test-resources/pages/Configuration.html?sap-ui-rtl=true&sap-ui-compactSize=true&sap-ui-language=ja&sap-ui-calendarType=Japanese&sap-ui-theme=sap_belize_hcb&sap-ui-animationMode=basic");
+	browser.url("http://localhost:9191/test-resources/pages/Configuration.html?sap-ui-rtl=true&sap-ui-language=ja&sap-ui-calendarType=Japanese&sap-ui-theme=sap_belize_hcb&sap-ui-animationMode=basic");
 
@@ -14,10 +14,2 @@ it("Tests that RTL is applied", () => {
 
-	it("Tests that compactSize is applied", () => {
-		const res = browser.execute( () => {
-			const config = window['sap-ui-webcomponents-bundle'].configuration;
-			return config.getCompactSize();
-		});
-		assert.strictEqual(res, true, "compactSize is true");
-	});
-
 	it("Tests that language is applied", () => {
@@ -24,0 +16,0 @@ const res = browser.execute( () => {

dist/UI5Element.js

 import merge from "@ui5/webcomponents-utils/dist/sap/base/util/merge.js";
-
 import boot from "./boot.js";
 import { skipOriginalEvent } from "./config/NoConflict.js";
-import { getCompactSize } from "./config/CompactSize.js";
 import DOMObserver from "./compatibility/DOMObserver.js";
@@ -12,3 +10,2 @@ import UI5ElementMetadata from "./UI5ElementMetadata.js";
 import { getEffectiveStyle } from "./Theming.js";
-import { attachContentDensityChange } from "./ContentDensity.js";
 import { kebabToCamelCase, camelToKebabCase } from "./util/StringHelper.js";
@@ -44,4 +41,2 @@ import isValidPropertyName from "./util/isValidPropertyName.js";
 
-		attachContentDensityChange(this._onContentDensityChanged.bind(this));
-
 		let deferredResolve;
@@ -59,24 +54,2 @@ this._domRefReadyPromise = new Promise(resolve => {
 	 */
-	_onContentDensityChanged() {
-		this._syncContentDensity();
-		if (this.constructor.getMetadata().getInvalidateOnContentDensityChange()) {
-			this._invalidate();
-		}
-	}
-
-	/**
-	 * @private
-	 */
-	_syncContentDensity() {
-		const isCompact = getCompactSize();
-		if (isCompact) {
-			this.setAttribute("data-ui5-compact-size", "");
-		} else {
-			this.removeAttribute("data-ui5-compact-size");
-		}
-	}
-
-	/**
-	 * @private
-	 */
 	_generateId() {
@@ -113,4 +86,2 @@ this._id = this.constructor._nextID();
 	async connectedCallback() {
-		this._syncContentDensity();
-
 		if (!this.constructor._needsShadowDOM()) {
@@ -117,0 +88,0 @@ return;

dist/UI5ElementMetadata.js

@@ -103,10 +103,2 @@ import DataType from "./types/DataType.js";
 	}
-
-	/**
-	 * Determines whether this UI5 Element invalidates automatically when content density changes
-	 * @public
-	 */
-	getInvalidateOnContentDensityChange() {
-		return !!this.metadata.invalidateOnContentDensityChange;
-	}
 }
@@ -113,0 +105,0 @@

package.json

 {
   "name": "@ui5/webcomponents-base",
-  "version": "0.0.0-04e3a6f74",
+  "version": "0.0.0-2db62badf",
   "description": "UI5 Web Components: webcomponents.base",
@@ -26,3 +26,3 @@ "author": "SAP SE (https://www.sap.com)",
   "dependencies": {
-    "@ui5/webcomponents-utils": "0.0.0-04e3a6f74",
+    "@ui5/webcomponents-utils": "0.0.0-2db62badf",
     "css-vars-ponyfill": "^2.1.2",
@@ -34,3 +34,3 @@ "lit-html": "^1.0.0",
   "devDependencies": {
-    "@ui5/webcomponents-tools": "0.0.0-04e3a6f74",
+    "@ui5/webcomponents-tools": "0.0.0-2db62badf",
     "array-uniq": "^2.0.0",
@@ -37,0 +37,0 @@ "copy-and-watch": "^0.1.4",

src/boot.js

 import whenDOMReady from "./util/whenDOMReady.js";
-import EventEnrichment from "./events/EventEnrichment.js";
 import insertFontFace from "./FontFace.js";
@@ -8,4 +7,2 @@ import { getTheme } from "./config/Theme.js";
 
-EventEnrichment.run();
-
 let bootPromise;
@@ -12,0 +9,0 @@

src/InitialConfiguration.js

@@ -8,3 +8,2 @@ let initialized = false;
 	language: null,
-	compactSize: false,
 	calendarType: null,
@@ -36,7 +35,2 @@ noConflict: false, // no URL
 
-const getCompactSize = () => {
-	initConfiguration();
-	return initialConfig.compactSize;
-};
-
 const getNoConflict = () => {
@@ -124,3 +118,2 @@ initConfiguration();
 	getLanguage,
-	getCompactSize,
 	getNoConflict,
@@ -127,0 +120,0 @@ getCalendarType,

src/UI5Element.js

 import merge from "@ui5/webcomponents-utils/dist/sap/base/util/merge.js";
-
 import boot from "./boot.js";
 import { skipOriginalEvent } from "./config/NoConflict.js";
-import { getCompactSize } from "./config/CompactSize.js";
 import DOMObserver from "./compatibility/DOMObserver.js";
@@ -12,3 +10,2 @@ import UI5ElementMetadata from "./UI5ElementMetadata.js";
 import { getEffectiveStyle } from "./Theming.js";
-import { attachContentDensityChange } from "./ContentDensity.js";
 import { kebabToCamelCase, camelToKebabCase } from "./util/StringHelper.js";
@@ -44,4 +41,2 @@ import isValidPropertyName from "./util/isValidPropertyName.js";
 
-		attachContentDensityChange(this._onContentDensityChanged.bind(this));
-
 		let deferredResolve;
@@ -59,24 +54,2 @@ this._domRefReadyPromise = new Promise(resolve => {
 	 */
-	_onContentDensityChanged() {
-		this._syncContentDensity();
-		if (this.constructor.getMetadata().getInvalidateOnContentDensityChange()) {
-			this._invalidate();
-		}
-	}
-
-	/**
-	 * @private
-	 */
-	_syncContentDensity() {
-		const isCompact = getCompactSize();
-		if (isCompact) {
-			this.setAttribute("data-ui5-compact-size", "");
-		} else {
-			this.removeAttribute("data-ui5-compact-size");
-		}
-	}
-
-	/**
-	 * @private
-	 */
 	_generateId() {
@@ -113,4 +86,2 @@ this._id = this.constructor._nextID();
 	async connectedCallback() {
-		this._syncContentDensity();
-
 		if (!this.constructor._needsShadowDOM()) {
@@ -117,0 +88,0 @@ return;

src/UI5ElementMetadata.js

@@ -103,10 +103,2 @@ import DataType from "./types/DataType.js";
 	}
-
-	/**
-	 * Determines whether this UI5 Element invalidates automatically when content density changes
-	 * @public
-	 */
-	getInvalidateOnContentDensityChange() {
-		return !!this.metadata.invalidateOnContentDensityChange;
-	}
 }
@@ -113,0 +105,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

12453165

decreased by-1.79%

Number of package files

337

decreased by-3.99%

Lines of code

366670

decreased by-2.64%

Dependency changes

• + Added@ui5/webcomponents-utils@0.0.0-2db62badf(transitive)

• - Removed@ui5/webcomponents-utils@0.0.0-04e3a6f74(transitive)

• Updated@ui5/webcomponents-utils@0.0.0-2db62badf