@umbraco-ui/uui-breadcrumbs - npm Package Compare versions

Comparing version 1.8.0-rc.0 to 1.8.0

custom-elements.json

@@ -13,3 +13,3 @@ {
           "type": "String",
-          "default": "\"'#'\""
+          "default": "\"undefined\""
         },
@@ -29,3 +29,3 @@ {
           "type": "String",
-          "default": "\"'#'\""
+          "default": "\"undefined\""
         },
@@ -32,0 +32,0 @@ {

lib/index.js

@@ -19,3 +19,2 @@ import { defineElement } from '@umbraco-ui/uui-base/lib/registration';
     super(...arguments);
-    this.href = "#";
     this.lastItem = false;
@@ -28,4 +27,4 @@ }
   renderLinkAndSeparator() {
-    return html`<a id="link" href=${this.href}><slot></slot></a
-      ><span part="separator"></span>`;
+    const item = this.href ? html`<a id="link" href=${this.href}><slot></slot></a>` : html`<span id="link"><slot></slot></span>`;
+    return html`${item}<span part="separator"></span>`;
   }
@@ -74,6 +73,2 @@ renderCurrent() {
       }
-
-      #link {
-        cursor: pointer;
-      }
     `
@@ -80,0 +75,0 @@ ];

lib/uui-breadcrumb-item.element.d.ts

@@ -13,5 +13,5 @@ import { LitElement } from 'lit';
      * @type {String}
-     * @default '#'
+     * @default undefined
      */
-    href: string;
+    href?: string;
     /**
@@ -18,0 +18,0 @@ * Specifies if the element is the last item in the uui-breadcrumbs. Last item will not render as a link

package.json

 {
   "name": "@umbraco-ui/uui-breadcrumbs",
-  "version": "1.8.0-rc.0",
+  "version": "1.8.0",
   "license": "MIT",
@@ -35,3 +35,3 @@ "keywords": [
   "dependencies": {
-    "@umbraco-ui/uui-base": "1.8.0-rc.0"
+    "@umbraco-ui/uui-base": "1.8.0"
   },
@@ -47,3 +47,3 @@ "scripts": {
   "homepage": "https://uui.umbraco.com/?path=/story/uui-breadcrumbs",
-  "gitHead": "46d444c66217c9a3c74518d8ce4badc7f121bfdf"
+  "gitHead": "53021762a52dc54a46f0c5ef829c1cbaabde1160"
 }

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

11990

increased by0.18%

Number of low quality alerts

0

decreased by-100%

Worsened metrics

Lines of code

265

decreased by-1.49%

Dependency changes

• + Added@umbraco-ui/uui-base@1.8.0(transitive)

• - Removed@umbraco-ui/uui-base@1.8.0-rc.0(transitive)

• Updated@umbraco-ui/uui-base@1.8.0