@vaadin/checkbox - npm Package Compare versions

Comparing version 22.0.3 to 22.0.4

package.json

 {
   "name": "@vaadin/checkbox",
-  "version": "22.0.3",
+  "version": "22.0.4",
   "publishConfig": {
@@ -36,7 +36,7 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "^22.0.3",
-    "@vaadin/field-base": "^22.0.3",
-    "@vaadin/vaadin-lumo-styles": "^22.0.3",
-    "@vaadin/vaadin-material-styles": "^22.0.3",
-    "@vaadin/vaadin-themable-mixin": "^22.0.3"
+    "@vaadin/component-base": "^22.0.4",
+    "@vaadin/field-base": "^22.0.4",
+    "@vaadin/vaadin-lumo-styles": "^22.0.4",
+    "@vaadin/vaadin-material-styles": "^22.0.4",
+    "@vaadin/vaadin-themable-mixin": "^22.0.4"
   },
@@ -48,3 +48,3 @@ "devDependencies": {
   },
-  "gitHead": "935ad1ea65a79b0f9ecb10d767689479b36c4e07"
+  "gitHead": "55891f68d4da41e846e06dfe51dceba1665e41ce"
 }

src/vaadin-checkbox.d.ts

@@ -11,3 +11,3 @@ /**
 import { DelegateFocusMixin } from '@vaadin/field-base/src/delegate-focus-mixin.js';
-import { SlotLabelMixin } from '@vaadin/field-base/src/slot-label-mixin.js';
+import { LabelMixin } from '@vaadin/field-base/src/label-mixin.js';
 import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
@@ -65,3 +65,3 @@
  */
-declare class Checkbox extends SlotLabelMixin(
+declare class Checkbox extends LabelMixin(
   CheckedMixin(DelegateFocusMixin(ActiveMixin(ElementMixin(ThemableMixin(ControllerMixin(HTMLElement))))))
@@ -68,0 +68,0 @@ ) {

src/vaadin-checkbox.js

@@ -13,4 +13,5 @@ /**
 import { InputController } from '@vaadin/field-base/src/input-controller.js';
+import { LabelMixin } from '@vaadin/field-base/src/label-mixin.js';
 import { LabelledInputController } from '@vaadin/field-base/src/labelled-input-controller.js';
-import { SlotLabelMixin } from '@vaadin/field-base/src/slot-label-mixin.js';
+import { SlotTargetController } from '@vaadin/field-base/src/slot-target-controller.js';
 import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
@@ -57,5 +58,5 @@
  * @mixes CheckedMixin
- * @mixes SlotLabelMixin
+ * @mixes LabelMixin
  */
-class Checkbox extends SlotLabelMixin(
+class Checkbox extends LabelMixin(
   CheckedMixin(DelegateFocusMixin(ActiveMixin(ElementMixin(ThemableMixin(ControllerMixin(PolymerElement))))))
@@ -83,3 +84,4 @@ ) {
         .vaadin-checkbox-container {
-          display: inline-flex;
+          display: grid;
+          grid-template-columns: auto 1fr;
           align-items: baseline;
@@ -90,3 +92,3 @@ }
           position: relative;
-          flex: none;
+          height: 100%;
         }
@@ -185,25 +187,14 @@
       this.addController(new LabelledInputController(this.inputElement, this._labelController));
+      this.addController(
+        new SlotTargetController(
+          this.$.noop,
+          () => this._labelController.node,
+          () => this.__warnDeprecated()
+        )
+      );
     }
   }
 
-  /**
-   * A reference to the default slot from which nodes are copied to the label node.
-   *
-   * @override
-   * @protected
-   * @type {HTMLSlotElement}
-   */
-  get _sourceSlot() {
-    return this.$.noop;
-  }
-
-  /**
-   * Override __copyNodesToSlotTarget from SlotTargetMixin to show a warning.
-   * @override
-   * @protected
-   * @param {!Array<!Node>} nodes
-   **/
-  __copyNodesToSlotTarget(nodes) {
-    super.__copyNodesToSlotTarget(nodes);
-
+  /** @private */
+  __warnDeprecated() {
     console.warn(
@@ -210,0 +201,0 @@ `WARNING: Since Vaadin 22, placing the label as a direct child of a <vaadin-checkbox> is deprecated.

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

33353

decreased by-0.36%

Lines of code

571

decreased by-1.21%

Dependency changes

• Updated@vaadin/component-base@^22.0.4

• Updated@vaadin/field-base@^22.0.4

• Updated@vaadin/vaadin-lumo-styles@^22.0.4

• Updated@vaadin/vaadin-material-styles@^22.0.4

• Updated@vaadin/vaadin-themable-mixin@^22.0.4