@vaadin/combo-box - npm Package Compare versions

Comparing version 22.0.14 to 22.0.15

package.json

 {
   "name": "@vaadin/combo-box",
-  "version": "22.0.14",
+  "version": "22.0.15",
   "publishConfig": {
@@ -36,21 +36,21 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "^22.0.14",
-    "@vaadin/field-base": "^22.0.14",
-    "@vaadin/input-container": "^22.0.14",
-    "@vaadin/item": "^22.0.14",
-    "@vaadin/vaadin-lumo-styles": "^22.0.14",
-    "@vaadin/vaadin-material-styles": "^22.0.14",
-    "@vaadin/vaadin-overlay": "^22.0.14",
-    "@vaadin/vaadin-themable-mixin": "^22.0.14"
+    "@vaadin/component-base": "^22.0.15",
+    "@vaadin/field-base": "^22.0.15",
+    "@vaadin/input-container": "^22.0.15",
+    "@vaadin/item": "^22.0.15",
+    "@vaadin/vaadin-lumo-styles": "^22.0.15",
+    "@vaadin/vaadin-material-styles": "^22.0.15",
+    "@vaadin/vaadin-overlay": "^22.0.15",
+    "@vaadin/vaadin-themable-mixin": "^22.0.15"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/dialog": "^22.0.14",
-    "@vaadin/polymer-legacy-adapter": "^22.0.14",
+    "@vaadin/dialog": "^22.0.15",
+    "@vaadin/polymer-legacy-adapter": "^22.0.15",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-field": "^22.0.14",
+    "@vaadin/text-field": "^22.0.15",
     "lit": "^2.0.0",
     "sinon": "^9.2.0"
   },
-  "gitHead": "62419e3f8f41fe9dc4f0bce5e1717b16828459b6"
+  "gitHead": "bba021b56ba45da93d2bb980242956ad929ecfe2"
 }

src/vaadin-combo-box-data-provider-mixin.d.ts

@@ -18,7 +18,7 @@ /**
   params: ComboBoxDataProviderParams,
-  callback: ComboBoxDataProviderCallback<TItem>
+  callback: ComboBoxDataProviderCallback<TItem>,
 ) => void;
 
 export declare function ComboBoxDataProviderMixin<TItem, T extends Constructor<HTMLElement>>(
-  base: T
+  base: T,
 ): T & Constructor<ComboBoxDataProviderMixinClass<TItem>>;
@@ -25,0 +25,0 @@

src/vaadin-combo-box-data-provider-mixin.js

@@ -23,3 +23,3 @@ /**
           value: 50,
-          observer: '_pageSizeChanged'
+          observer: '_pageSizeChanged',
         },
@@ -33,3 +33,3 @@
           type: Number,
-          observer: '_sizeChanged'
+          observer: '_sizeChanged',
         },
@@ -53,3 +53,3 @@
           type: Object,
-          observer: '_dataProviderChanged'
+          observer: '_dataProviderChanged',
         },
@@ -61,3 +61,3 @@
             return {};
-          }
+          },
         },
@@ -67,4 +67,4 @@
         __placeHolder: {
-          value: new ComboBoxPlaceholder()
-        }
+          value: new ComboBoxPlaceholder(),
+        },
       };
@@ -78,3 +78,3 @@ }
         '_warnDataProviderValue(dataProvider, value)',
-        '_ensureFirstPage(opened)'
+        '_ensureFirstPage(opened)',
       ];
@@ -181,3 +181,3 @@ }
           pageSize: this.pageSize,
-          filter: this.filter
+          filter: this.filter,
         };
@@ -293,3 +293,3 @@
               'the `dataProvider` callback. Consider setting `selectedItem` ' +
-              'instead of `value`'
+              'instead of `value`',
           );
@@ -296,0 +296,0 @@ }

src/vaadin-combo-box-dropdown.js

@@ -49,3 +49,3 @@ /**
         type: Object,
-        observer: '_positionTargetChanged'
+        observer: '_positionTargetChanged',
       },
@@ -64,3 +64,3 @@
         value: false,
-        reflectToAttribute: true
+        reflectToAttribute: true,
       },
@@ -74,7 +74,7 @@
       _selectedItem: {
-        type: Object
+        type: Object,
       },
 
       _items: {
-        type: Array
+        type: Array,
       },
@@ -84,3 +84,3 @@
         type: Number,
-        value: -1
+        value: -1,
       },
@@ -90,3 +90,3 @@
         type: String,
-        computed: '_getFocusedItem(_focusedIndex)'
+        computed: '_getFocusedItem(_focusedIndex)',
       },
@@ -96,3 +96,3 @@
         type: String,
-        value: 'label'
+        value: 'label',
       },
@@ -102,3 +102,3 @@
         type: String,
-        value: 'value'
+        value: 'value',
       },
@@ -112,4 +112,4 @@
         type: Boolean,
-        observer: '_openedChanged'
-      }
+        observer: '_openedChanged',
+      },
     };
@@ -121,3 +121,3 @@ }
       '_openedOrItemsChanged(opened, _items, loading)',
-      '__updateScroller(_scroller, _items, opened, loading, _selectedItem, _itemIdPath, _focusedIndex, renderer, theme)'
+      '__updateScroller(_scroller, _items, opened, loading, _selectedItem, _itemIdPath, _focusedIndex, renderer, theme)',
     ];
@@ -184,4 +184,4 @@ }
       new CustomEvent('vaadin-overlay-touch-action', {
-        detail: { sourceEvent: sourceEvent }
-      })
+        detail: { sourceEvent: sourceEvent },
+      }),
     );
@@ -275,3 +275,3 @@ }
         renderer,
-        theme
+        theme,
       });
@@ -278,0 +278,0 @@ }

src/vaadin-combo-box-item.js

@@ -82,3 +82,3 @@ /**
         value: false,
-        reflectToAttribute: true
+        reflectToAttribute: true,
       },
@@ -92,3 +92,3 @@
         value: false,
-        reflectToAttribute: true
+        reflectToAttribute: true,
       },
@@ -104,3 +104,3 @@
        */
-      _oldRenderer: Function
+      _oldRenderer: Function,
     };
@@ -139,3 +139,3 @@ }
       focused: this.focused,
-      selected: this.selected
+      selected: this.selected,
     };
@@ -142,0 +142,0 @@

src/vaadin-combo-box-light.d.ts

@@ -16,3 +16,3 @@ /**
   ComboBoxDataProviderCallback,
-  ComboBoxDataProviderParams
+  ComboBoxDataProviderParams,
 } from './vaadin-combo-box-data-provider-mixin.js';
@@ -121,3 +121,3 @@ export { ComboBoxDefaultItem, ComboBoxItemModel, ComboBoxRenderer } from './vaadin-combo-box-mixin.js';
     listener: (this: ComboBoxLight<TItem>, ev: ComboBoxLightEventMap<TItem>[K]) => void,
-    options?: boolean | AddEventListenerOptions
+    options?: boolean | AddEventListenerOptions,
   ): void;
@@ -128,3 +128,3 @@
     listener: (this: ComboBoxLight<TItem>, ev: ComboBoxLightEventMap<TItem>[K]) => void,
-    options?: boolean | EventListenerOptions
+    options?: boolean | EventListenerOptions,
   ): void;
@@ -131,0 +131,0 @@ }

src/vaadin-combo-box-light.js

@@ -102,4 +102,4 @@ /**
         type: String,
-        value: 'value'
-      }
+        value: 'value',
+      },
     };
@@ -106,0 +106,0 @@ }

src/vaadin-combo-box-mixin.d.ts

@@ -22,7 +22,7 @@ /**
   comboBox: ComboBox<TItem>,
-  model: ComboBoxItemModel<TItem>
+  model: ComboBoxItemModel<TItem>,
 ) => void;
 
 export declare function ComboBoxMixin<TItem, T extends Constructor<HTMLElement>>(
-  base: T
+  base: T,
 ): T &
@@ -29,0 +29,0 @@ Constructor<ComboBoxMixinClass<TItem>> &

src/vaadin-combo-box-mixin.js

@@ -29,3 +29,3 @@ /**
           reflectToAttribute: true,
-          observer: '_openedChanged'
+          observer: '_openedChanged',
         },
@@ -38,3 +38,3 @@
         autoOpenDisabled: {
-          type: Boolean
+          type: Boolean,
         },
@@ -49,3 +49,3 @@
           value: false,
-          reflectToAttribute: true
+          reflectToAttribute: true,
         },
@@ -74,3 +74,3 @@
           type: Array,
-          observer: '_itemsChanged'
+          observer: '_itemsChanged',
         },
@@ -88,3 +88,3 @@
           type: Boolean,
-          value: false
+          value: false,
         },
@@ -99,3 +99,3 @@
         filteredItems: {
-          type: Array
+          type: Array,
         },
@@ -117,3 +117,3 @@
           reflectToAttribute: true,
-          observer: '_loadingChanged'
+          observer: '_loadingChanged',
         },
@@ -128,3 +128,3 @@
           observer: '_focusedIndexChanged',
-          value: -1
+          value: -1,
         },
@@ -139,3 +139,3 @@
           value: '',
-          notify: true
+          notify: true,
         },
@@ -149,3 +149,3 @@
           type: Object,
-          notify: true
+          notify: true,
         },
@@ -166,3 +166,3 @@
           value: 'label',
-          observer: '_itemLabelPathChanged'
+          observer: '_itemLabelPathChanged',
         },
@@ -182,3 +182,3 @@
           type: String,
-          value: 'value'
+          value: 'value',
         },
@@ -201,7 +201,7 @@
           type: Object,
-          observer: '_toggleElementChanged'
+          observer: '_toggleElementChanged',
         },
 
         /** @private */
-        _closeOnBlurIsPrevented: Boolean
+        _closeOnBlurIsPrevented: Boolean,
       };
@@ -215,3 +215,3 @@ }
         '_filteredItemsChanged(filteredItems.*, itemValuePath, itemLabelPath)',
-        '_selectedItemChanged(selectedItem, itemValuePath, itemLabelPath)'
+        '_selectedItemChanged(selectedItem, itemValuePath, itemLabelPath)',
       ];
@@ -749,3 +749,3 @@ }
             cancelable: true,
-            bubbles: true
+            bubbles: true,
           });
@@ -752,0 +752,0 @@ this.dispatchEvent(e);

src/vaadin-combo-box-overlay.js

@@ -23,3 +23,3 @@ /**
   `,
-  { moduleId: 'vaadin-combo-box-overlay-styles' }
+  { moduleId: 'vaadin-combo-box-overlay-styles' },
 );
@@ -26,0 +26,0 @@

src/vaadin-combo-box-scroller.js

@@ -59,3 +59,3 @@ /**
         type: Array,
-        observer: '__itemsChanged'
+        observer: '__itemsChanged',
       },
@@ -69,3 +69,3 @@
         type: Number,
-        observer: '__focusedIndexChanged'
+        observer: '__focusedIndexChanged',
       },
@@ -78,3 +78,3 @@
         type: Boolean,
-        observer: '__loadingChanged'
+        observer: '__loadingChanged',
       },
@@ -88,3 +88,3 @@
         type: Boolean,
-        observer: '__openedChanged'
+        observer: '__openedChanged',
       },
@@ -96,3 +96,3 @@
       selectedItem: {
-        type: Object
+        type: Object,
       },
@@ -104,3 +104,3 @@
       itemIdPath: {
-        type: String
+        type: String,
       },
@@ -112,3 +112,3 @@
       comboBox: {
-        type: Object
+        type: Object,
       },
@@ -120,3 +120,3 @@
       getItemLabel: {
-        type: Object
+        type: Object,
       },
@@ -129,3 +129,3 @@
         type: Object,
-        observer: '__rendererChanged'
+        observer: '__rendererChanged',
       },
@@ -137,4 +137,4 @@
       theme: {
-        type: String
-      }
+        type: String,
+      },
     };
@@ -172,3 +172,3 @@ }
       scrollTarget: this,
-      scrollContainer: this.$.selector
+      scrollContainer: this.$.selector,
     });
@@ -207,3 +207,3 @@ }
     const lastPhysicalItem = [...this.children].find(
-      (el) => !el.hidden && el.index === this.__virtualizer.lastVisibleIndex
+      (el) => !el.hidden && el.index === this.__virtualizer.lastVisibleIndex,
     );
@@ -275,3 +275,5 @@ if (!lastPhysicalItem || index !== lastPhysicalItem.index) {
 
-    if (index >= 0) {
+    // Do not jump back to the previously focused item while loading
+    // when requesting next page from the data provider on scroll.
+    if (index >= 0 && !this.loading) {
       this.scrollIntoView(index);
@@ -311,3 +313,3 @@ }
       renderer: this.renderer,
-      focused: this.__isItemFocused(focusedIndex, index)
+      focused: this.__isItemFocused(focusedIndex, index),
     });
@@ -373,3 +375,3 @@
       this.dispatchEvent(
-        new CustomEvent('index-requested', { detail: { index, currentScrollerPos: this._oldScrollerPosition } })
+        new CustomEvent('index-requested', { detail: { index, currentScrollerPos: this._oldScrollerPosition } }),
       );
@@ -376,0 +378,0 @@ }

src/vaadin-combo-box.d.ts

@@ -27,3 +27,3 @@ /**
   ComboBoxDataProviderCallback,
-  ComboBoxDataProviderParams
+  ComboBoxDataProviderParams,
 } from './vaadin-combo-box-data-provider-mixin.js';
@@ -207,3 +207,3 @@ export { ComboBoxDefaultItem, ComboBoxItemModel, ComboBoxRenderer } from './vaadin-combo-box-mixin.js';
     listener: (this: ComboBox<TItem>, ev: ComboBoxEventMap<TItem>[K]) => void,
-    options?: boolean | AddEventListenerOptions
+    options?: boolean | AddEventListenerOptions,
   ): void;
@@ -214,3 +214,3 @@
     listener: (this: ComboBox<TItem>, ev: ComboBoxEventMap<TItem>[K]) => void,
-    options?: boolean | EventListenerOptions
+    options?: boolean | EventListenerOptions,
   ): void;
@@ -217,0 +217,0 @@ }

src/vaadin-combo-box.js

@@ -157,3 +157,3 @@ /**
 class ComboBox extends ComboBoxDataProviderMixin(
-  ComboBoxMixin(PatternMixin(InputControlMixin(ThemableMixin(ElementMixin(PolymerElement)))))
+  ComboBoxMixin(PatternMixin(InputControlMixin(ThemableMixin(ElementMixin(PolymerElement))))),
 ) {
@@ -220,4 +220,4 @@ static get is() {
       _positionTarget: {
-        type: Object
-      }
+        type: Object,
+      },
     };
@@ -245,3 +245,3 @@ }
         this.ariaTarget = input;
-      })
+      }),
     );
@@ -248,0 +248,0 @@ this.addController(new LabelledInputController(this.inputElement, this._labelController));

theme/lumo/vaadin-combo-box-dropdown-styles.js

@@ -92,3 +92,3 @@ import '@vaadin/vaadin-lumo-styles/color.js';
 registerStyles('vaadin-combo-box-overlay', [overlay, menuOverlayCore, comboBoxOverlay], {
-  moduleId: 'lumo-combo-box-overlay'
+  moduleId: 'lumo-combo-box-overlay',
 });

theme/lumo/vaadin-combo-box-item-styles.js

@@ -22,3 +22,3 @@ import '@vaadin/vaadin-lumo-styles/color.js';
 registerStyles('vaadin-combo-box-item', [item, comboBoxItem], {
-  moduleId: 'lumo-combo-box-item'
+  moduleId: 'lumo-combo-box-item',
 });

theme/material/vaadin-combo-box-dropdown-styles.js

@@ -120,3 +120,3 @@ import '@vaadin/vaadin-material-styles/color.js';
 registerStyles('vaadin-combo-box-overlay', [menuOverlay, comboBoxOverlay], {
-  moduleId: 'material-combo-box-overlay'
+  moduleId: 'material-combo-box-overlay',
 });

theme/material/vaadin-combo-box-item-styles.js

@@ -17,3 +17,3 @@ import '@vaadin/vaadin-material-styles/color.js';
 registerStyles('vaadin-combo-box-item', [item, comboBoxItem], {
-  moduleId: 'material-combo-box-item'
+  moduleId: 'material-combo-box-item',
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

133019

increased by0.17%

Lines of code

3367

increased by0.06%

Dependency changes

• Updated@vaadin/component-base@^22.0.15

• Updated@vaadin/field-base@^22.0.15

• Updated@vaadin/input-container@^22.0.15

• Updated@vaadin/item@^22.0.15

• Updated@vaadin/vaadin-lumo-styles@^22.0.15

• Updated@vaadin/vaadin-material-styles@^22.0.15

• Updated@vaadin/vaadin-overlay@^22.0.15

• Updated@vaadin/vaadin-themable-mixin@^22.0.15