@vaadin/combo-box - npm Package Compare versions

Comparing version 23.0.10 to 23.0.11

package.json

 {
   "name": "@vaadin/combo-box",
-  "version": "23.0.10",
+  "version": "23.0.11",
   "publishConfig": {
@@ -37,21 +37,21 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "^23.0.10",
-    "@vaadin/field-base": "^23.0.10",
-    "@vaadin/input-container": "^23.0.10",
-    "@vaadin/item": "^23.0.10",
-    "@vaadin/vaadin-lumo-styles": "^23.0.10",
-    "@vaadin/vaadin-material-styles": "^23.0.10",
-    "@vaadin/vaadin-overlay": "^23.0.10",
-    "@vaadin/vaadin-themable-mixin": "^23.0.10"
+    "@vaadin/component-base": "^23.0.11",
+    "@vaadin/field-base": "^23.0.11",
+    "@vaadin/input-container": "^23.0.11",
+    "@vaadin/item": "^23.0.11",
+    "@vaadin/vaadin-lumo-styles": "^23.0.11",
+    "@vaadin/vaadin-material-styles": "^23.0.11",
+    "@vaadin/vaadin-overlay": "^23.0.11",
+    "@vaadin/vaadin-themable-mixin": "^23.0.11"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/dialog": "^23.0.10",
-    "@vaadin/polymer-legacy-adapter": "^23.0.10",
+    "@vaadin/dialog": "^23.0.11",
+    "@vaadin/polymer-legacy-adapter": "^23.0.11",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-field": "^23.0.10",
+    "@vaadin/text-field": "^23.0.11",
     "lit": "^2.0.0",
     "sinon": "^9.2.0"
   },
-  "gitHead": "e8402a55ce0e823ae6da5c97486998cfd931b1d3"
+  "gitHead": "10838304fe6f5c98b838ec3a90bdcf49cbf4650b"
 }

src/vaadin-combo-box-data-provider-mixin.js

@@ -77,14 +77,2 @@ /**
 
-    /** @private */
-    _dataProviderClearFilter(dataProvider, opened, value) {
-      // Can't depend on filter in this observer as we don't want
-      // to clear the filter whenever it's set
-      if (dataProvider && !this.loading && this.filter && !(opened && this.autoOpenDisabled && value === this.filter)) {
-        this.size = undefined;
-        this._pendingRequests = {};
-        this.filter = '';
-        this.clearCache();
-      }
-    }
-
     /** @protected */
@@ -122,4 +110,28 @@ ready() {
 
+      this._refreshData();
+    }
+
+    /** @private */
+    _dataProviderClearFilter(dataProvider, opened, value) {
+      // Can't depend on filter in this observer as we don't want
+      // to clear the filter whenever it's set
+      if (dataProvider && !this.loading && this.filter && !(opened && this.autoOpenDisabled && value === this.filter)) {
+        this._refreshData(true);
+      }
+    }
+
+    /** @private */
+    _refreshData(clearFilter) {
+      // Immediately mark as loading if this refresh leads to re-fetching pages
+      // This prevents some issues with the properties below triggering
+      // observers that also rely on the loading state
+      this.loading = this._shouldFetchData();
+      // Reset size and internal loading state
       this.size = undefined;
       this._pendingRequests = {};
+      // Clear filter if requested
+      if (clearFilter) {
+        this.filter = '';
+      }
+      // Clear cached pages, and reload current page if we need the data
       this.clearCache();
@@ -126,0 +138,0 @@ }

src/vaadin-combo-box-mixin.js

@@ -428,6 +428,23 @@ /**
      * @param {Event} event
+     * @private
+     */
+    _onToggleButtonClick(event) {
+      // Prevent parent components such as `vaadin-grid`
+      // from handling the click event after it bubbles.
+      event.preventDefault();
+
+      if (this.opened) {
+        this.close();
+      } else {
+        this.open();
+      }
+    }
+
+    /**
+     * @param {Event} event
      * @protected
      */
-    _onHostClick(_event) {
+    _onHostClick(event) {
       if (!this.autoOpenDisabled) {
+        event.preventDefault();
         this.open();
@@ -446,7 +463,3 @@ }
       } else if (path.indexOf(this._toggleElement) > -1) {
-        if (this.opened) {
-          this.close();
-        } else {
-          this.open();
-        }
+        this._onToggleButtonClick(e);
       } else {
@@ -453,0 +466,0 @@ this._onHostClick(e);

theme/material/vaadin-combo-box-dropdown-styles.js

 import '@vaadin/vaadin-material-styles/color.js';
+import '@vaadin/vaadin-overlay/theme/material/vaadin-overlay.js';
 import { menuOverlay } from '@vaadin/vaadin-material-styles/mixins/menu-overlay.js';
@@ -3,0 +4,0 @@ import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

135008

increased by0.62%

Lines of code

3417

increased by0.68%

Dependency changes

• Updated@vaadin/component-base@^23.0.11

• Updated@vaadin/field-base@^23.0.11

• Updated@vaadin/input-container@^23.0.11

• Updated@vaadin/item@^23.0.11

• Updated@vaadin/vaadin-lumo-styles@^23.0.11

• Updated@vaadin/vaadin-material-styles@^23.0.11

• Updated@vaadin/vaadin-overlay@^23.0.11

• Updated@vaadin/vaadin-themable-mixin@^23.0.11