@vaadin/combo-box - npm Package Compare versions

Comparing version 23.2.0-dev.53560527d to 23.2.0-dev.8a7678b70

package.json

 {
   "name": "@vaadin/combo-box",
-  "version": "23.2.0-dev.53560527d",
+  "version": "23.2.0-dev.8a7678b70",
   "publishConfig": {
@@ -39,21 +39,21 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "23.2.0-dev.53560527d",
-    "@vaadin/field-base": "23.2.0-dev.53560527d",
-    "@vaadin/input-container": "23.2.0-dev.53560527d",
-    "@vaadin/item": "23.2.0-dev.53560527d",
-    "@vaadin/lit-renderer": "23.2.0-dev.53560527d",
-    "@vaadin/vaadin-lumo-styles": "23.2.0-dev.53560527d",
-    "@vaadin/vaadin-material-styles": "23.2.0-dev.53560527d",
-    "@vaadin/vaadin-overlay": "23.2.0-dev.53560527d",
-    "@vaadin/vaadin-themable-mixin": "23.2.0-dev.53560527d"
+    "@vaadin/component-base": "23.2.0-dev.8a7678b70",
+    "@vaadin/field-base": "23.2.0-dev.8a7678b70",
+    "@vaadin/input-container": "23.2.0-dev.8a7678b70",
+    "@vaadin/item": "23.2.0-dev.8a7678b70",
+    "@vaadin/lit-renderer": "23.2.0-dev.8a7678b70",
+    "@vaadin/vaadin-lumo-styles": "23.2.0-dev.8a7678b70",
+    "@vaadin/vaadin-material-styles": "23.2.0-dev.8a7678b70",
+    "@vaadin/vaadin-overlay": "23.2.0-dev.8a7678b70",
+    "@vaadin/vaadin-themable-mixin": "23.2.0-dev.8a7678b70"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/polymer-legacy-adapter": "23.2.0-dev.53560527d",
+    "@vaadin/polymer-legacy-adapter": "23.2.0-dev.8a7678b70",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-field": "23.2.0-dev.53560527d",
+    "@vaadin/text-field": "23.2.0-dev.8a7678b70",
     "lit": "^2.0.0",
     "sinon": "^13.0.2"
   },
-  "gitHead": "6c5c18369b09e22e76365d8a8a5e4bbb220f969b"
+  "gitHead": "85b403f96d8282f262322b56c0ff4289f843d02a"
 }

src/vaadin-combo-box-mixin.js

@@ -445,2 +445,7 @@ /**
       if (scroller) {
+        if (opened) {
+          scroller.style.maxHeight =
+            getComputedStyle(this).getPropertyValue(`--${this._tagNamePrefix}-overlay-max-height`) || '65vh';
+        }
+
         scroller.setProperties({
@@ -853,6 +858,2 @@ items: opened ? items : [],
       requestAnimationFrame(() => {
-        // When opened is set as attribute, this logic needs to be delayed until scroller is created.
-        this._scroller.style.maxHeight =
-          getComputedStyle(this).getPropertyValue(`--${this._tagNamePrefix}-overlay-max-height`) || '65vh';
-
         this._scrollIntoView(this._focusedIndex);
@@ -859,0 +860,0 @@

No alert changes

Improved metrics

Lines of code

3430

increased by0.03%

Worsened metrics

Total package byte prevSize

136365

decreased by-0.05%

Dependency changes

• + Added@vaadin/component-base@23.2.0-dev.8a7678b70(transitive)

• + Added@vaadin/field-base@23.2.0-dev.8a7678b70(transitive)

• + Added@vaadin/icon@23.2.0-dev.8a7678b70(transitive)

• + Added@vaadin/input-container@23.2.0-dev.8a7678b70(transitive)

• + Added@vaadin/item@23.2.0-dev.8a7678b70(transitive)

• + Added@vaadin/lit-renderer@23.2.0-dev.8a7678b70(transitive)

• + Added@vaadin/vaadin-lumo-styles@23.2.0-dev.8a7678b70(transitive)

• + Added@vaadin/vaadin-material-styles@23.2.0-dev.8a7678b70(transitive)

• + Added@vaadin/vaadin-overlay@23.2.0-dev.8a7678b70(transitive)

• + Added@vaadin/vaadin-themable-mixin@23.2.0-dev.8a7678b70(transitive)

• - Removed@vaadin/component-base@23.2.0-dev.53560527d(transitive)

• - Removed@vaadin/field-base@23.2.0-dev.53560527d(transitive)

• - Removed@vaadin/icon@23.2.0-dev.53560527d(transitive)

• - Removed@vaadin/input-container@23.2.0-dev.53560527d(transitive)

• - Removed@vaadin/item@23.2.0-dev.53560527d(transitive)

• - Removed@vaadin/lit-renderer@23.2.0-dev.53560527d(transitive)

• - Removed@vaadin/vaadin-lumo-styles@23.2.0-dev.53560527d(transitive)

• - Removed@vaadin/vaadin-material-styles@23.2.0-dev.53560527d(transitive)

• - Removed@vaadin/vaadin-overlay@23.2.0-dev.53560527d(transitive)

• - Removed@vaadin/vaadin-themable-mixin@23.2.0-dev.53560527d(transitive)

• Updated@vaadin/component-base@23.2.0-dev.8a7678b70

• Updated@vaadin/field-base@23.2.0-dev.8a7678b70

• Updated@vaadin/input-container@23.2.0-dev.8a7678b70

• Updated@vaadin/item@23.2.0-dev.8a7678b70

• Updated@vaadin/lit-renderer@23.2.0-dev.8a7678b70

• Updated@vaadin/vaadin-lumo-styles@23.2.0-dev.8a7678b70

• Updated@vaadin/vaadin-material-styles@23.2.0-dev.8a7678b70

• Updated@vaadin/vaadin-overlay@23.2.0-dev.8a7678b70

• Updated@vaadin/vaadin-themable-mixin@23.2.0-dev.8a7678b70