@vaadin/custom-field - npm Package Compare versions

Comparing version 24.5.1 to 24.5.2

package.json

 {
   "name": "@vaadin/custom-field",
-  "version": "24.5.1",
+  "version": "24.5.2",
   "publishConfig": {
@@ -41,23 +41,23 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/a11y-base": "~24.5.1",
-    "@vaadin/component-base": "~24.5.1",
-    "@vaadin/field-base": "~24.5.1",
-    "@vaadin/vaadin-lumo-styles": "~24.5.1",
-    "@vaadin/vaadin-material-styles": "~24.5.1",
-    "@vaadin/vaadin-themable-mixin": "~24.5.1",
+    "@vaadin/a11y-base": "~24.5.2",
+    "@vaadin/component-base": "~24.5.2",
+    "@vaadin/field-base": "~24.5.2",
+    "@vaadin/vaadin-lumo-styles": "~24.5.2",
+    "@vaadin/vaadin-material-styles": "~24.5.2",
+    "@vaadin/vaadin-themable-mixin": "~24.5.2",
     "lit": "^3.0.0"
   },
   "devDependencies": {
-    "@vaadin/chai-plugins": "~24.5.1",
-    "@vaadin/combo-box": "~24.5.1",
-    "@vaadin/date-picker": "~24.5.1",
-    "@vaadin/email-field": "~24.5.1",
-    "@vaadin/form-layout": "~24.5.1",
-    "@vaadin/number-field": "~24.5.1",
-    "@vaadin/password-field": "~24.5.1",
-    "@vaadin/select": "~24.5.1",
+    "@vaadin/chai-plugins": "~24.5.2",
+    "@vaadin/combo-box": "~24.5.2",
+    "@vaadin/date-picker": "~24.5.2",
+    "@vaadin/email-field": "~24.5.2",
+    "@vaadin/form-layout": "~24.5.2",
+    "@vaadin/number-field": "~24.5.2",
+    "@vaadin/password-field": "~24.5.2",
+    "@vaadin/select": "~24.5.2",
     "@vaadin/testing-helpers": "^1.0.0",
-    "@vaadin/text-area": "~24.5.1",
-    "@vaadin/text-field": "~24.5.1",
-    "@vaadin/time-picker": "~24.5.1",
+    "@vaadin/text-area": "~24.5.2",
+    "@vaadin/text-field": "~24.5.2",
+    "@vaadin/time-picker": "~24.5.2",
     "sinon": "^18.0.0"
@@ -69,3 +69,3 @@ },
   ],
-  "gitHead": "0cf89edf4f22ee6f71925b86ea38d22f118638c3"
+  "gitHead": "3e07e97ed0bf355373d1ef0216a3954113e4a40f"
 }

src/vaadin-custom-field-mixin.js

@@ -175,3 +175,3 @@ /**
       const { relatedTarget } = event;
-      return !this.inputs.some((el) => relatedTarget === (el.focusElement || el));
+      return !this.inputs || !this.inputs.some((el) => relatedTarget === (el.focusElement || el));
     }
@@ -185,5 +185,6 @@
     checkValidity() {
-      const invalidFields = this.inputs.filter((input) => !(input.validate || input.checkValidity).call(input));
+      const hasInvalidFields =
+        this.inputs && this.inputs.some((input) => !(input.validate || input.checkValidity).call(input));
 
-      if (invalidFields.length || (this.required && !this.value.trim())) {
+      if (hasInvalidFields || (this.required && !(this.value && this.value.trim()))) {
         // Either 1. one of the input fields is invalid or
@@ -218,5 +219,6 @@ // 2. the custom field itself is required but doesn't have a value
       if (e.key === 'Tab') {
+        const inputs = this.inputs || [];
         if (
-          (this.inputs.indexOf(e.target) < this.inputs.length - 1 && !e.shiftKey) ||
-          (this.inputs.indexOf(e.target) > 0 && e.shiftKey)
+          (inputs.indexOf(e.target) < inputs.length - 1 && !e.shiftKey) ||
+          (inputs.indexOf(e.target) > 0 && e.shiftKey)
         ) {
@@ -300,3 +302,3 @@ this.dispatchEvent(new CustomEvent('internal-tab'));
 
-      this.__applyInputsValue(value);
+      this.__applyInputsValue(value || '\t');
 
@@ -303,0 +305,0 @@ if (oldValue !== undefined) {

web-types.json

 {
   "$schema": "https://json.schemastore.org/web-types",
   "name": "@vaadin/custom-field",
-  "version": "24.5.1",
+  "version": "24.5.2",
   "description-markup": "markdown",
@@ -103,3 +103,3 @@ "contributions": {
               "name": "value",
-              "description": "The value of the field. When wrapping several inputs, it will contain `\\t`\n(Tab character) as a delimiter indicating parts intended to be used as the\ncorresponding inputs values.\nUse the [`formatValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.1/#/elements/vaadin-custom-field#property-formatValue)\nand [`parseValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.1/#/elements/vaadin-custom-field#property-parseValue)\nproperties to customize this behavior.",
+              "description": "The value of the field. When wrapping several inputs, it will contain `\\t`\n(Tab character) as a delimiter indicating parts intended to be used as the\ncorresponding inputs values.\nUse the [`formatValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.2/#/elements/vaadin-custom-field#property-formatValue)\nand [`parseValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.2/#/elements/vaadin-custom-field#property-parseValue)\nproperties to customize this behavior.",
               "value": {
@@ -217,3 +217,3 @@ "type": [
                 "name": "value",
-                "description": "The value of the field. When wrapping several inputs, it will contain `\\t`\n(Tab character) as a delimiter indicating parts intended to be used as the\ncorresponding inputs values.\nUse the [`formatValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.1/#/elements/vaadin-custom-field#property-formatValue)\nand [`parseValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.1/#/elements/vaadin-custom-field#property-parseValue)\nproperties to customize this behavior.",
+                "description": "The value of the field. When wrapping several inputs, it will contain `\\t`\n(Tab character) as a delimiter indicating parts intended to be used as the\ncorresponding inputs values.\nUse the [`formatValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.2/#/elements/vaadin-custom-field#property-formatValue)\nand [`parseValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.2/#/elements/vaadin-custom-field#property-parseValue)\nproperties to customize this behavior.",
                 "value": {
@@ -220,0 +220,0 @@ "type": [

web-types.lit.json

 {
   "$schema": "https://json.schemastore.org/web-types",
   "name": "@vaadin/custom-field",
-  "version": "24.5.1",
+  "version": "24.5.2",
   "description-markup": "markdown",
@@ -80,3 +80,3 @@ "framework": "lit",
               "name": ".value",
-              "description": "The value of the field. When wrapping several inputs, it will contain `\\t`\n(Tab character) as a delimiter indicating parts intended to be used as the\ncorresponding inputs values.\nUse the [`formatValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.1/#/elements/vaadin-custom-field#property-formatValue)\nand [`parseValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.1/#/elements/vaadin-custom-field#property-parseValue)\nproperties to customize this behavior.",
+              "description": "The value of the field. When wrapping several inputs, it will contain `\\t`\n(Tab character) as a delimiter indicating parts intended to be used as the\ncorresponding inputs values.\nUse the [`formatValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.2/#/elements/vaadin-custom-field#property-formatValue)\nand [`parseValue`](https://cdn.vaadin.com/vaadin-web-components/24.5.2/#/elements/vaadin-custom-field#property-parseValue)\nproperties to customize this behavior.",
               "value": {
@@ -83,0 +83,0 @@ "kind": "expression"

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

61269

increased by0.14%

Lines of code

1183

increased by0.17%

Dependency changes

• Updated@vaadin/a11y-base@~24.5.2

• Updated@vaadin/component-base@~24.5.2

• Updated@vaadin/field-base@~24.5.2

• Updated@vaadin/vaadin-lumo-styles@~24.5.2

• Updated@vaadin/vaadin-material-styles@~24.5.2

• Updated@vaadin/vaadin-themable-mixin@~24.5.2