@vaadin/dialog - npm Package Compare versions

Comparing version 23.1.0-alpha3 to 23.1.0-alpha4

package.json

 {
   "name": "@vaadin/dialog",
-  "version": "23.1.0-alpha3",
+  "version": "23.1.0-alpha4",
   "publishConfig": {
@@ -38,16 +38,16 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "23.1.0-alpha3",
-    "@vaadin/vaadin-lumo-styles": "23.1.0-alpha3",
-    "@vaadin/vaadin-material-styles": "23.1.0-alpha3",
-    "@vaadin/vaadin-overlay": "23.1.0-alpha3",
-    "@vaadin/vaadin-themable-mixin": "23.1.0-alpha3"
+    "@vaadin/component-base": "23.1.0-alpha4",
+    "@vaadin/vaadin-lumo-styles": "23.1.0-alpha4",
+    "@vaadin/vaadin-material-styles": "23.1.0-alpha4",
+    "@vaadin/vaadin-overlay": "23.1.0-alpha4",
+    "@vaadin/vaadin-themable-mixin": "23.1.0-alpha4"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/polymer-legacy-adapter": "23.1.0-alpha3",
+    "@vaadin/polymer-legacy-adapter": "23.1.0-alpha4",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-area": "23.1.0-alpha3",
+    "@vaadin/text-area": "23.1.0-alpha4",
     "sinon": "^13.0.2"
   },
-  "gitHead": "8c9e64e8dfa158dd52a9bf6da351ff038c88ca85"
+  "gitHead": "aacdb7fe09811894751f0378ff7fb66071892c71"
 }

src/vaadin-dialog-draggable-mixin.d.ts

@@ -9,3 +9,3 @@ /**
 export declare function DialogDraggableMixin<T extends Constructor<HTMLElement>>(
-  base: T
+  base: T,
 ): T & Constructor<DialogDraggableMixinClass>;
@@ -12,0 +12,0 @@

src/vaadin-dialog-draggable-mixin.js

@@ -31,3 +31,3 @@ /**
           value: false,
-          reflectToAttribute: true
+          reflectToAttribute: true,
         },
@@ -38,3 +38,3 @@
           type: Boolean,
-          value: isTouch
+          value: isTouch,
         },
@@ -44,4 +44,4 @@
         __dragHandleClassName: {
-          type: String
-        }
+          type: String,
+        },
       };
@@ -88,3 +88,5 @@ }
         if ((isResizerContainer && !isResizerContainerScrollbar) || isContentPart || isDraggable) {
-          !isDraggable && e.preventDefault();
+          if (!isDraggable) {
+            e.preventDefault();
+          }
           this._originalBounds = this.$.overlay.getBounds();
@@ -91,0 +93,0 @@ const event = getMouseOrFirstTouchEvent(e);

src/vaadin-dialog-resizable-mixin.d.ts

@@ -9,3 +9,3 @@ /**
 export declare function DialogResizableMixin<T extends Constructor<HTMLElement>>(
-  base: T
+  base: T,
 ): T & Constructor<DialogResizableMixinClass>;
@@ -12,0 +12,0 @@

src/vaadin-dialog-resizable-mixin.js

@@ -108,3 +108,3 @@ /**
   `,
-  { moduleId: 'vaadin-dialog-resizable-overlay-styles' }
+  { moduleId: 'vaadin-dialog-resizable-overlay-styles' },
 );
@@ -126,4 +126,4 @@
           value: false,
-          reflectToAttribute: true
-        }
+          reflectToAttribute: true,
+        },
       };
@@ -257,3 +257,3 @@ }
         'style',
-        'position: absolute; top: 0; right: 0; bottom: 0; left: 0; box-sizing: content-box; height: auto;'
+        'position: absolute; top: 0; right: 0; bottom: 0; left: 0; box-sizing: content-box; height: auto;',
       );
@@ -260,0 +260,0 @@ const { width: contentWidth, height: contentHeight } = getComputedStyle(content);

src/vaadin-dialog.d.ts

@@ -211,3 +211,3 @@ /**
     listener: (this: Dialog, ev: DialogEventMap[K]) => void,
-    options?: boolean | AddEventListenerOptions
+    options?: boolean | AddEventListenerOptions,
   ): void;
@@ -218,3 +218,3 @@
     listener: (this: Dialog, ev: DialogEventMap[K]) => void,
-    options?: boolean | EventListenerOptions
+    options?: boolean | EventListenerOptions,
   ): void;
@@ -221,0 +221,0 @@ }

src/vaadin-dialog.js

@@ -18,6 +18,5 @@ /**
   css`
-    /* prefixing with the element tags to avoid styling confirm-dialog header part */
-    header[part='header'],
+    [part='header'],
     [part='header-content'],
-    footer[part='footer'] {
+    [part='footer'] {
       display: flex;
@@ -31,6 +30,5 @@ align-items: center;
 
-    :host(:is([has-title], [has-header])) ::slotted([slot='header']),
     ::slotted([slot='header-content']),
     ::slotted([slot='title']),
-    :host([has-footer]) ::slotted([slot='footer']) {
+    ::slotted([slot='footer']) {
       display: contents;
@@ -44,17 +42,14 @@ pointer-events: auto;
 
-    /* prefixing with the element tag to avoid styling confirm-dialog footer part */
     :host([has-title]) [part='header-content'],
-    footer[part='footer'] {
+    [part='footer'] {
       justify-content: flex-end;
     }
 
-    :host(:not([has-title]):not([has-header])) header[part='header'],
-    :host(:not([has-title])) [part='title'] {
-      display: none;
+    :host(:not([has-title]):not([has-header])) [part='header'],
+    :host(:not([has-header])) [part='header-content'],
+    :host(:not([has-title])) [part='title'],
+    :host(:not([has-footer])) [part='footer'] {
+      display: none !important;
     }
 
-    :host(:not([has-footer])) footer[part='footer'] {
-      display: none;
-    }
-
     :host(:is([has-title], [has-header], [has-footer])) [part='content'] {
@@ -89,3 +84,3 @@ height: auto;
   `,
-  { moduleId: 'vaadin-dialog-overlay-styles' }
+  { moduleId: 'vaadin-dialog-overlay-styles' },
 );
@@ -151,3 +146,3 @@
       '_headerFooterRendererChange(headerRenderer, footerRenderer, opened)',
-      '_headerTitleChanged(headerTitle, opened)'
+      '_headerTitleChanged(headerTitle, opened)',
     ];
@@ -166,3 +161,3 @@ }
 
-      footerRenderer: Function
+      footerRenderer: Function,
     };
@@ -511,3 +506,3 @@ }
         value: false,
-        notify: true
+        notify: true,
       },
@@ -522,3 +517,3 @@
         type: Boolean,
-        value: false
+        value: false,
       },
@@ -533,3 +528,3 @@
         type: Boolean,
-        value: false
+        value: false,
       },
@@ -544,3 +539,3 @@
         type: String,
-        value: ''
+        value: '',
       },
@@ -604,4 +599,4 @@
         type: Boolean,
-        value: false
-      }
+        value: false,
+      },
     };
@@ -614,3 +609,3 @@ }
       '_ariaLabelChanged(ariaLabel)',
-      '_rendererChanged(renderer, headerRenderer, footerRenderer)'
+      '_rendererChanged(renderer, headerRenderer, footerRenderer)',
     ];
@@ -617,0 +612,0 @@ }

theme/lumo/vaadin-dialog-styles.js

@@ -34,5 +34,5 @@ import '@vaadin/vaadin-lumo-styles/spacing.js';
 
-  :host(:is([has-header], [has-title])) [part='header'],
-  :host([has-header]) [part='header-content'],
-  :host([has-footer]) [part='footer'] {
+  [part='header'],
+  [part='header-content'],
+  [part='footer'] {
     gap: var(--lumo-space-xs) var(--lumo-space-s);
@@ -42,3 +42,3 @@ line-height: var(--lumo-line-height-s);
 
-  :host(:is([has-header], [has-title])) [part='header'] {
+  [part='header'] {
     padding: var(--lumo-space-m);
@@ -49,3 +49,3 @@ background-color: var(--lumo-base-color);
 
-  :host([has-footer]) [part='footer'] {
+  [part='footer'] {
     padding: var(--lumo-space-s) var(--lumo-space-m);
@@ -69,3 +69,3 @@ background-color: var(--lumo-contrast-5pct);
   @media (min-height: 320px) {
-    :host(:is([has-header], [has-title])[overflow~='top']) [part='header'] {
+    :host([overflow~='top']) [part='header'] {
       box-shadow: 0 1px 0 0 var(--lumo-contrast-10pct);
@@ -72,0 +72,0 @@ }

theme/material/vaadin-dialog-styles.js

@@ -19,3 +19,3 @@ import '@vaadin/vaadin-material-styles/shadow.js';
 
-  :host(:is([has-header], [has-title])) [part='header'] {
+  [part='header'] {
     padding: 16px;
@@ -28,5 +28,5 @@ }
 
-  :host(:is([has-header], [has-title])) [part='header'],
-  :host([has-header]) [part='header-content'],
-  :host([has-footer]) [part='footer'] {
+  [part='header'],
+  [part='header-content'],
+  [part='footer'] {
     gap: 8px;
@@ -42,3 +42,3 @@ line-height: 1.2;
 
-  :host([has-footer]) [part='footer'] {
+  [part='footer'] {
     padding: 8px;
@@ -48,7 +48,7 @@ }
   @media (min-height: 320px) {
-    :host(:is([has-header], [has-title])[overflow~='top']) [part='header'] {
+    :host([overflow~='top']) [part='header'] {
       box-shadow: 0 1px 0 0 var(--material-divider-color);
     }
 
-    :host([has-footer][overflow~='bottom']) [part='footer'] {
+    :host([overflow~='bottom']) [part='footer'] {
       box-shadow: 0 -1px 0 0 var(--material-divider-color);
@@ -65,3 +65,3 @@ }
 registerStyles('vaadin-dialog-overlay', [overlay, dialogOverlay], {
-  moduleId: 'material-dialog'
+  moduleId: 'material-dialog',
 });

No alert changes

Worsened metrics

Total package byte prevSize

62481

decreased by-0.87%

Lines of code

1374

decreased by-0.15%

Dependency changes

• + Added@vaadin/component-base@23.1.0-alpha4(transitive)

• + Added@vaadin/icon@23.1.0-alpha4(transitive)

• + Added@vaadin/vaadin-lumo-styles@23.1.0-alpha4(transitive)

• + Added@vaadin/vaadin-material-styles@23.1.0-alpha4(transitive)

• + Added@vaadin/vaadin-overlay@23.1.0-alpha4(transitive)

• + Added@vaadin/vaadin-themable-mixin@23.1.0-alpha4(transitive)

• - Removed@vaadin/component-base@23.1.0-alpha3(transitive)

• - Removed@vaadin/icon@23.1.0-alpha3(transitive)

• - Removed@vaadin/vaadin-lumo-styles@23.1.0-alpha3(transitive)

• - Removed@vaadin/vaadin-material-styles@23.1.0-alpha3(transitive)

• - Removed@vaadin/vaadin-overlay@23.1.0-alpha3(transitive)

• - Removed@vaadin/vaadin-themable-mixin@23.1.0-alpha3(transitive)

• Updated@vaadin/component-base@23.1.0-alpha4

• Updated@vaadin/vaadin-lumo-styles@23.1.0-alpha4

• Updated@vaadin/vaadin-material-styles@23.1.0-alpha4

• Updated@vaadin/vaadin-overlay@23.1.0-alpha4

• Updated@vaadin/vaadin-themable-mixin@23.1.0-alpha4