@vaadin/dialog
Advanced tools
@vaadin/dialog - npm Package Compare versions
Comparing version 23.1.0-alpha4 to 23.1.0-beta1
| { | ||
| "name": "@vaadin/dialog", | ||
| "version": "23.1.0-alpha4", | ||
| "version": "23.1.0-beta1", | ||
| "publishConfig": { | ||
@@ -38,16 +38,17 @@ "access": "public" | ||
| "@polymer/polymer": "^3.0.0", | ||
| "@vaadin/component-base": "23.1.0-alpha4", | ||
| "@vaadin/vaadin-lumo-styles": "23.1.0-alpha4", | ||
| "@vaadin/vaadin-material-styles": "23.1.0-alpha4", | ||
| "@vaadin/vaadin-overlay": "23.1.0-alpha4", | ||
| "@vaadin/vaadin-themable-mixin": "23.1.0-alpha4" | ||
| "@vaadin/component-base": "23.1.0-beta1", | ||
| "@vaadin/lit-renderer": "23.1.0-beta1", | ||
| "@vaadin/vaadin-lumo-styles": "23.1.0-beta1", | ||
| "@vaadin/vaadin-material-styles": "23.1.0-beta1", | ||
| "@vaadin/vaadin-overlay": "23.1.0-beta1", | ||
| "@vaadin/vaadin-themable-mixin": "23.1.0-beta1" | ||
| }, | ||
| "devDependencies": { | ||
| "@esm-bundle/chai": "^4.3.4", | ||
| "@vaadin/polymer-legacy-adapter": "23.1.0-alpha4", | ||
| "@vaadin/polymer-legacy-adapter": "23.1.0-beta1", | ||
| "@vaadin/testing-helpers": "^0.3.2", | ||
| "@vaadin/text-area": "23.1.0-alpha4", | ||
| "@vaadin/text-area": "23.1.0-beta1", | ||
| "sinon": "^13.0.2" | ||
| }, | ||
| "gitHead": "aacdb7fe09811894751f0378ff7fb66071892c71" | ||
| "gitHead": "8be43cf83102a6b9ccf309687446e590ce0164e8" | ||
| } |
@@ -102,3 +102,3 @@ /** | ||
| const overlayPart = memoizedTemplate.content.querySelector('[part="overlay"]'); | ||
| const resizerContainer = document.createElement('div'); | ||
| const resizerContainer = document.createElement('section'); | ||
| resizerContainer.id = 'resizerContainer'; | ||
@@ -165,5 +165,2 @@ resizerContainer.classList.add('resizer-container'); | ||
| const uniqueId = (DialogOverlay._uniqueId = 1 + DialogOverlay._uniqueId || 0); | ||
| this._titleId = `${this.constructor.is}-title-${uniqueId}`; | ||
| // Update overflow attribute on resize | ||
@@ -269,7 +266,4 @@ this.__resizeObserver = new ResizeObserver(() => { | ||
| this.headerTitleElement = document.createElement('span'); | ||
| this.headerTitleElement.id = this._titleId; | ||
| this.headerTitleElement.setAttribute('slot', 'title'); | ||
| this.headerTitleElement.classList.add('draggable'); | ||
| this.setAttribute('aria-labelledby', this._titleId); | ||
| } | ||
@@ -281,3 +275,2 @@ this.appendChild(this.headerTitleElement); | ||
| this.headerTitleElement = null; | ||
| this.removeAttribute('aria-labelledby'); | ||
| } | ||
@@ -601,3 +594,3 @@ } | ||
| '_openedChanged(opened)', | ||
| '_ariaLabelChanged(ariaLabel)', | ||
| '_ariaLabelChanged(ariaLabel, headerTitle)', | ||
| '_rendererChanged(renderer, headerRenderer, footerRenderer)', | ||
@@ -656,5 +649,5 @@ ]; | ||
| /** @private */ | ||
| _ariaLabelChanged(ariaLabel) { | ||
| if (ariaLabel) { | ||
| this.$.overlay.setAttribute('aria-label', ariaLabel); | ||
| _ariaLabelChanged(ariaLabel, headerTitle) { | ||
| if (ariaLabel || headerTitle) { | ||
| this.$.overlay.setAttribute('aria-label', ariaLabel || headerTitle); | ||
| } else { | ||
@@ -661,0 +654,0 @@ this.$.overlay.removeAttribute('aria-label'); |
New alerts
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
Fixed alerts
License Policy Violation
LicenseThis package is not allowed per your license policy. Review the package's license to ensure compliance.
Found 1 instance in 1 package
Improved metrics
- Total package byte prevSize
- increased by17.14%
73188
- Number of package files
- increased by11.76%
19
- Lines of code
- increased by18.85%
1633
Worsened metrics
- Dependency count
- increased by14.29%
8
Dependency changes
+ Added@vaadin/component-base@23.1.0-beta1(transitive)
+ Added@vaadin/icon@23.1.0-beta1(transitive)
+ Added@vaadin/lit-renderer@23.1.0-beta1(transitive)
+ Added@vaadin/vaadin-lumo-styles@23.1.0-beta1(transitive)
+ Added@vaadin/vaadin-material-styles@23.1.0-beta1(transitive)
+ Added@vaadin/vaadin-overlay@23.1.0-beta1(transitive)
+ Added@vaadin/vaadin-themable-mixin@23.1.0-beta1(transitive)
- Removed@vaadin/component-base@23.1.0-alpha4(transitive)
- Removed@vaadin/icon@23.1.0-alpha4(transitive)
- Removed@vaadin/vaadin-lumo-styles@23.1.0-alpha4(transitive)
- Removed@vaadin/vaadin-material-styles@23.1.0-alpha4(transitive)
- Removed@vaadin/vaadin-overlay@23.1.0-alpha4(transitive)
- Removed@vaadin/vaadin-themable-mixin@23.1.0-alpha4(transitive)