@vaadin/form-layout - npm Package Compare versions

Comparing version 23.0.6 to 23.0.7

package.json

 {
   "name": "@vaadin/form-layout",
-  "version": "23.0.6",
+  "version": "23.0.7",
   "publishConfig": {
@@ -37,15 +37,15 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "^23.0.6",
-    "@vaadin/vaadin-lumo-styles": "^23.0.6",
-    "@vaadin/vaadin-material-styles": "^23.0.6",
-    "@vaadin/vaadin-themable-mixin": "^23.0.6"
+    "@vaadin/component-base": "^23.0.7",
+    "@vaadin/vaadin-lumo-styles": "^23.0.7",
+    "@vaadin/vaadin-material-styles": "^23.0.7",
+    "@vaadin/vaadin-themable-mixin": "^23.0.7"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/custom-field": "^23.0.6",
+    "@vaadin/custom-field": "^23.0.7",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-field": "^23.0.6",
+    "@vaadin/text-field": "^23.0.7",
     "sinon": "^9.2.1"
   },
-  "gitHead": "82ca8522e24a63343fb28bcb4c686e55d25c8858"
+  "gitHead": "005c2d85db8f50cd3b239dd89ac467add6a71049"
 }

src/vaadin-form-item.js

@@ -180,6 +180,2 @@ /**
     this.__fieldNode = null;
-
-    // Ensure every instance has unique ID
-    const uniqueId = (FormItem._uniqueLabelId = 1 + FormItem._uniqueLabelId || 0);
-    this.__labelId = `label-${this.localName}-${uniqueId}`;
   }
@@ -248,3 +244,2 @@
     if (this.__labelNode) {
-      this.__labelNode.id = '';
       this.__labelNode = null;
@@ -260,4 +255,13 @@
       this.__labelNode = newLabelNode;
-      this.__labelNode.id = this.__labelId;
 
+      if (this.__labelNode.id) {
+        // The new label node already has an id. Let's use it.
+        this.__labelId = this.__labelNode.id;
+      } else {
+        // The new label node doesn't have an id yet. Generate a unique one.
+        const uniqueId = (FormItem._uniqueLabelId = 1 + FormItem._uniqueLabelId || 0);
+        this.__labelId = `label-${this.localName}-${uniqueId}`;
+        this.__labelNode.id = this.__labelId;
+      }
+
       if (this.__fieldNode) {
@@ -264,0 +268,0 @@ this.__linkLabelToField(this.__fieldNode);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

53034

increased by0.33%

Lines of code

1139

increased by0.35%

Dependency changes

• Updated@vaadin/component-base@^23.0.7

• Updated@vaadin/vaadin-lumo-styles@^23.0.7

• Updated@vaadin/vaadin-material-styles@^23.0.7

• Updated@vaadin/vaadin-themable-mixin@^23.0.7