@vaadin/grid - npm Package Compare versions

Comparing version 24.3.10 to 24.3.11

package.json

 {
   "name": "@vaadin/grid",
-  "version": "24.3.10",
+  "version": "24.3.11",
   "publishConfig": {
@@ -49,10 +49,10 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/a11y-base": "~24.3.10",
-    "@vaadin/checkbox": "~24.3.10",
-    "@vaadin/component-base": "~24.3.10",
-    "@vaadin/lit-renderer": "~24.3.10",
-    "@vaadin/text-field": "~24.3.10",
-    "@vaadin/vaadin-lumo-styles": "~24.3.10",
-    "@vaadin/vaadin-material-styles": "~24.3.10",
-    "@vaadin/vaadin-themable-mixin": "~24.3.10"
+    "@vaadin/a11y-base": "~24.3.11",
+    "@vaadin/checkbox": "~24.3.11",
+    "@vaadin/component-base": "~24.3.11",
+    "@vaadin/lit-renderer": "~24.3.11",
+    "@vaadin/text-field": "~24.3.11",
+    "@vaadin/vaadin-lumo-styles": "~24.3.11",
+    "@vaadin/vaadin-material-styles": "~24.3.11",
+    "@vaadin/vaadin-themable-mixin": "~24.3.11"
   },
@@ -69,3 +69,3 @@ "devDependencies": {
   ],
-  "gitHead": "32a4f327e78490074eaefa768f58857b83ca6278"
+  "gitHead": "890abeb0937416074456782aa90ed92c1bfe9cac"
 }

src/vaadin-grid-column-reordering-mixin.js

@@ -240,9 +240,22 @@ /**
       }
-      const cell = this.shadowRoot.elementFromPoint(x, y);
+      const elementFromPoint = this.shadowRoot.elementFromPoint(x, y);
       this.$.scroller.toggleAttribute('no-content-pointer-events', false);
 
-      // Make sure the element is actually a cell
-      if (cell && cell._column) {
-        return cell;
+      return this._getCellFromElement(elementFromPoint);
+    }
+
+    /** @private */
+    _getCellFromElement(element) {
+      if (element) {
+        // Check if element is a cell
+        if (element._column) {
+          return element;
+        }
+        // Check if element is the cell of a focus button mode column
+        const { parentElement } = element;
+        if (parentElement && parentElement._focusButton === element) {
+          return parentElement;
+        }
       }
+      return null;
     }
@@ -249,0 +262,0 @@

src/vaadin-grid-filter-element-mixin.js

@@ -72,8 +72,4 @@ /**
         initializer: (field) => {
-          field.addEventListener('value-changed', (e) => {
-            if (field.__previousValue === undefined && e.detail.value === '') {
-              field.__previousValue = e.detail.value;
-              return;
-            }
-            this.value = e.detail.value;
+          field.addEventListener('input', (e) => {
+            this.value = e.target.value;
           });
@@ -92,8 +88,4 @@
       }
-      if (this._previousValue === undefined && value === '') {
-        return;
-      }
 
       textField.value = value;
-      this._previousValue = value;
 
@@ -100,0 +92,0 @@ this._debouncerFilterChanged = Debouncer.debounce(this._debouncerFilterChanged, timeOut.after(200), () => {

src/vaadin-grid-keyboard-navigation-mixin.js

@@ -817,6 +817,8 @@ /**
       if (rootTarget === this.$.table || rootTarget === this.$.focusexit) {
-        // The focus enters the top (bottom) of the grid, meaning that user has
-        // tabbed (shift-tabbed) into the grid. Move the focus to
-        // the first (the last) focusable.
-        this._predictFocusStepTarget(rootTarget, rootTarget === this.$.table ? 1 : -1).focus();
+        if (!this._isMousedown) {
+          // The focus enters the top (bottom) of the grid, meaning that user has
+          // tabbed (shift-tabbed) into the grid. Move the focus to
+          // the first (the last) focusable.
+          this._predictFocusStepTarget(rootTarget, rootTarget === this.$.table ? 1 : -1).focus();
+        }
         this._setInteracting(false);
@@ -823,0 +825,0 @@ } else {

src/vaadin-grid-mixin.js

@@ -577,6 +577,2 @@ /**
 
-      if (column && column._onCellKeyDown) {
-        cell.addEventListener('keydown', column._onCellKeyDown.bind(column));
-      }
-
       const slot = document.createElement('slot');
@@ -670,2 +666,5 @@ slot.setAttribute('name', slotName);
               cell = this._createCell('td', column);
+              if (column._onCellKeyDown) {
+                cell.addEventListener('keydown', column._onCellKeyDown.bind(column));
+              }
               column._cells.push(cell);
@@ -714,3 +713,9 @@ }
             if (isColumnRow || column.localName === 'vaadin-grid-column-group') {
-              cell = column[`_${section}Cell`] || this._createCell(tagName, column);
+              cell = column[`_${section}Cell`];
+              if (!cell) {
+                cell = this._createCell(tagName);
+                if (column._onCellKeyDown) {
+                  cell.addEventListener('keydown', column._onCellKeyDown.bind(column));
+                }
+              }
               cell._column = column;
@@ -717,0 +722,0 @@ row.appendChild(cell);

src/vaadin-grid-scroll-mixin.js

@@ -238,3 +238,3 @@ /**
     __updateColumnsBodyContentHidden() {
-      if (!this._columnTree) {
+      if (!this._columnTree || !this._areSizerCellsAssigned()) {
         return;
@@ -244,8 +244,2 @@ }
       const columnsInOrder = this._getColumnsInOrder();
-
-      // Return if sizer cells are not yet assigned to columns
-      if (!columnsInOrder[0] || !columnsInOrder[0]._sizerCell) {
-        return;
-      }
-
       let bodyContentHiddenChanged = false;
@@ -490,3 +484,3 @@
 
-      if (this._lazyColumns) {
+      if (this._lazyColumns && this._areSizerCellsAssigned()) {
         // Lazy column rendering is used, calculate the offset to apply to the frozen to end cells
@@ -521,2 +515,7 @@ const columnsInOrder = this._getColumnsInOrder();
     }
+
+    /** @private */
+    _areSizerCellsAssigned() {
+      return this._getColumnsInOrder().every((column) => column._sizerCell);
+    }
   };

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

663780

increased by0.06%

Lines of code

15974

increased by0.08%

Dependency changes

• Updated@vaadin/a11y-base@~24.3.11

• Updated@vaadin/checkbox@~24.3.11

• Updated@vaadin/component-base@~24.3.11

• Updated@vaadin/lit-renderer@~24.3.11

• Updated@vaadin/text-field@~24.3.11

• Updated@vaadin/vaadin-lumo-styles@~24.3.11

• Updated@vaadin/vaadin-material-styles@~24.3.11

• Updated@vaadin/vaadin-themable-mixin@~24.3.11