@vaadin/grid - npm Package Compare versions

Comparing version 24.3.4 to 24.3.5

package.json

 {
   "name": "@vaadin/grid",
-  "version": "24.3.4",
+  "version": "24.3.5",
   "publishConfig": {
@@ -49,10 +49,10 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/a11y-base": "~24.3.4",
-    "@vaadin/checkbox": "~24.3.4",
-    "@vaadin/component-base": "~24.3.4",
-    "@vaadin/lit-renderer": "~24.3.4",
-    "@vaadin/text-field": "~24.3.4",
-    "@vaadin/vaadin-lumo-styles": "~24.3.4",
-    "@vaadin/vaadin-material-styles": "~24.3.4",
-    "@vaadin/vaadin-themable-mixin": "~24.3.4"
+    "@vaadin/a11y-base": "~24.3.5",
+    "@vaadin/checkbox": "~24.3.5",
+    "@vaadin/component-base": "~24.3.5",
+    "@vaadin/lit-renderer": "~24.3.5",
+    "@vaadin/text-field": "~24.3.5",
+    "@vaadin/vaadin-lumo-styles": "~24.3.5",
+    "@vaadin/vaadin-material-styles": "~24.3.5",
+    "@vaadin/vaadin-themable-mixin": "~24.3.5"
   },
@@ -69,3 +69,3 @@ "devDependencies": {
   ],
-  "gitHead": "dc5d3fd1d0f11a130b3574c455b62ce6b5706ffc"
+  "gitHead": "0c9b61a0facbbde52da3a96d2044de1c6a03e98c"
 }

src/vaadin-grid-keyboard-navigation-mixin.js

@@ -112,2 +112,7 @@ /**
 
+    /** @private */
+    get _visibleItemsCount() {
+      return this._lastVisibleIndex - this._firstVisibleIndex - 1;
+    }
+
     /** @protected */
@@ -308,4 +313,5 @@ ready() {
 
-      const visibleItemsCount = this._lastVisibleIndex - this._firstVisibleIndex - 1;
       const isRTL = this.__isRTL;
+      const activeRow = e.composedPath().find((el) => this.__isRow(el));
+      const activeCell = e.composedPath().find((el) => this.__isCell(el));
 
@@ -355,6 +361,13 @@ // Handle keyboard interaction as defined in:
         case 'PageDown':
-          dy = visibleItemsCount;
+          // Check if the active group is body
+          if (this.$.items.contains(activeRow)) {
+            const currentRowIndex = this.__getIndexInGroup(activeRow, this._focusedItemIndex);
+            // Scroll the current row to the top...
+            this._scrollToFlatIndex(currentRowIndex);
+          }
+          // ...only then measure the visible items count
+          dy = this._visibleItemsCount;
           break;
         case 'PageUp':
-          dy = -visibleItemsCount;
+          dy = -this._visibleItemsCount;
           break;
@@ -365,5 +378,2 @@ default:
 
-      const activeRow = e.composedPath().find((el) => this.__isRow(el));
-      const activeCell = e.composedPath().find((el) => this.__isCell(el));
-
       if ((this.__rowFocusMode && !activeRow) || (!this.__rowFocusMode && !activeCell)) {
@@ -370,0 +380,0 @@ // When using a screen reader, it's possible that neither a cell nor a row is focused.

src/vaadin-grid-mixin.js

@@ -662,7 +662,9 @@ /**
             row.__cells.push(cell);
-            if (!column._bodyContentHidden) {
+
+            const isSizerRow = row === this.$.sizer;
+            if (!column._bodyContentHidden || isSizerRow) {
               row.appendChild(cell);
             }
 
-            if (row === this.$.sizer) {
+            if (isSizerRow) {
               column._sizerCell = cell;
@@ -669,0 +671,0 @@ }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

661892

increased by0.07%

Lines of code

15943

increased by0.07%

Dependency changes

• Updated@vaadin/a11y-base@~24.3.5

• Updated@vaadin/checkbox@~24.3.5

• Updated@vaadin/component-base@~24.3.5

• Updated@vaadin/lit-renderer@~24.3.5

• Updated@vaadin/text-field@~24.3.5

• Updated@vaadin/vaadin-lumo-styles@~24.3.5

• Updated@vaadin/vaadin-material-styles@~24.3.5

• Updated@vaadin/vaadin-themable-mixin@~24.3.5