@vaadin/grid - npm Package Compare versions

Comparing version 24.5.0-alpha1 to 24.5.0-alpha2

package.json

 {
   "name": "@vaadin/grid",
-  "version": "24.5.0-alpha1",
+  "version": "24.5.0-alpha2",
   "publishConfig": {
@@ -49,10 +49,10 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/a11y-base": "24.5.0-alpha1",
-    "@vaadin/checkbox": "24.5.0-alpha1",
-    "@vaadin/component-base": "24.5.0-alpha1",
-    "@vaadin/lit-renderer": "24.5.0-alpha1",
-    "@vaadin/text-field": "24.5.0-alpha1",
-    "@vaadin/vaadin-lumo-styles": "24.5.0-alpha1",
-    "@vaadin/vaadin-material-styles": "24.5.0-alpha1",
-    "@vaadin/vaadin-themable-mixin": "24.5.0-alpha1",
+    "@vaadin/a11y-base": "24.5.0-alpha2",
+    "@vaadin/checkbox": "24.5.0-alpha2",
+    "@vaadin/component-base": "24.5.0-alpha2",
+    "@vaadin/lit-renderer": "24.5.0-alpha2",
+    "@vaadin/text-field": "24.5.0-alpha2",
+    "@vaadin/vaadin-lumo-styles": "24.5.0-alpha2",
+    "@vaadin/vaadin-material-styles": "24.5.0-alpha2",
+    "@vaadin/vaadin-themable-mixin": "24.5.0-alpha2",
     "lit": "^3.0.0"
@@ -69,3 +69,3 @@ },
   ],
-  "gitHead": "57806caac5468532a3b4e3dbdda730cd0fca193a"
+  "gitHead": "403f153bf4351f220cb6172485a0575ddf0d0fba"
 }

src/vaadin-grid-data-provider-mixin.js

@@ -237,2 +237,8 @@ /**
       updateCellsPart(cells, 'loading-row-cell', loading);
+
+      if (loading) {
+        // Run style generators for the loading row to have custom names cleared
+        this._generateCellClassNames(row);
+        this._generateCellPartNames(row);
+      }
     }
@@ -239,0 +245,0 @@

src/vaadin-grid-styling-mixin.js

@@ -92,3 +92,3 @@ /**
       iterateChildren(this.$.items, (row) => {
-        if (!row.hidden && !row.hasAttribute('loading')) {
+        if (!row.hidden) {
           this._generateCellClassNames(row, this.__getRowModel(row));
@@ -107,3 +107,3 @@ }
       iterateChildren(this.$.items, (row) => {
-        if (!row.hidden && !row.hasAttribute('loading')) {
+        if (!row.hidden) {
           this._generateCellPartNames(row, this.__getRowModel(row));
@@ -120,3 +120,3 @@ }
         }
-        if (this.cellClassNameGenerator) {
+        if (this.cellClassNameGenerator && !row.hasAttribute('loading')) {
           const result = this.cellClassNameGenerator(cell._column, model);
@@ -140,3 +140,3 @@ cell.__generatedClasses = result && result.split(' ').filter((className) => className.length > 0);
         }
-        if (this.cellPartNameGenerator) {
+        if (this.cellPartNameGenerator && !row.hasAttribute('loading')) {
           const result = this.cellPartNameGenerator(cell._column, model);
@@ -143,0 +143,0 @@ cell.__generatedParts = result && result.split(' ').filter((partName) => partName.length > 0);

No alert changes

Improved metrics

Total package byte prevSize

675200

increased by0.03%

Lines of code

16215

increased by0.03%

Dependency changes

• + Added@vaadin/a11y-base@24.5.0-alpha2(transitive)

• + Added@vaadin/checkbox@24.5.0-alpha2(transitive)

• + Added@vaadin/component-base@24.5.0-alpha2(transitive)

• + Added@vaadin/field-base@24.5.0-alpha2(transitive)

• + Added@vaadin/icon@24.5.0-alpha2(transitive)

• + Added@vaadin/input-container@24.5.0-alpha2(transitive)

• + Added@vaadin/lit-renderer@24.5.0-alpha2(transitive)

• + Added@vaadin/text-field@24.5.0-alpha2(transitive)

• + Added@vaadin/vaadin-lumo-styles@24.5.0-alpha2(transitive)

• + Added@vaadin/vaadin-material-styles@24.5.0-alpha2(transitive)

• + Added@vaadin/vaadin-themable-mixin@24.5.0-alpha2(transitive)

• - Removed@vaadin/a11y-base@24.5.0-alpha1(transitive)

• - Removed@vaadin/checkbox@24.5.0-alpha1(transitive)

• - Removed@vaadin/component-base@24.5.0-alpha1(transitive)

• - Removed@vaadin/field-base@24.5.0-alpha1(transitive)

• - Removed@vaadin/icon@24.5.0-alpha1(transitive)

• - Removed@vaadin/input-container@24.5.0-alpha1(transitive)

• - Removed@vaadin/lit-renderer@24.5.0-alpha1(transitive)

• - Removed@vaadin/text-field@24.5.0-alpha1(transitive)

• - Removed@vaadin/vaadin-lumo-styles@24.5.0-alpha1(transitive)

• - Removed@vaadin/vaadin-material-styles@24.5.0-alpha1(transitive)

• - Removed@vaadin/vaadin-themable-mixin@24.5.0-alpha1(transitive)

• Updated@vaadin/a11y-base@24.5.0-alpha2

• Updated@vaadin/checkbox@24.5.0-alpha2

• Updated@vaadin/component-base@24.5.0-alpha2

• Updated@vaadin/lit-renderer@24.5.0-alpha2

• Updated@vaadin/text-field@24.5.0-alpha2

• Updated@vaadin/vaadin-lumo-styles@24.5.0-alpha2

• Updated@vaadin/vaadin-material-styles@24.5.0-alpha2

• Updated@vaadin/vaadin-themable-mixin@24.5.0-alpha2