@vaadin/overlay - npm Package Compare versions

Comparing version 24.4.0-alpha9 to 24.4.0-beta1

package.json

 {
   "name": "@vaadin/overlay",
-  "version": "24.4.0-alpha9",
+  "version": "24.4.0-beta1",
   "publishConfig": {
@@ -39,7 +39,7 @@ "access": "public"
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/a11y-base": "24.4.0-alpha9",
-    "@vaadin/component-base": "24.4.0-alpha9",
-    "@vaadin/vaadin-lumo-styles": "24.4.0-alpha9",
-    "@vaadin/vaadin-material-styles": "24.4.0-alpha9",
-    "@vaadin/vaadin-themable-mixin": "24.4.0-alpha9",
+    "@vaadin/a11y-base": "24.4.0-beta1",
+    "@vaadin/component-base": "24.4.0-beta1",
+    "@vaadin/vaadin-lumo-styles": "24.4.0-beta1",
+    "@vaadin/vaadin-material-styles": "24.4.0-beta1",
+    "@vaadin/vaadin-themable-mixin": "24.4.0-beta1",
     "lit": "^3.0.0"
@@ -52,3 +52,3 @@ },
   },
-  "gitHead": "effb81abe3c6283a6ec620cc0cee56069af58226"
+  "gitHead": "504787f741d677467ae93ca7cd31d84489366a9c"
 }

README.md

@@ -6,3 +6,2 @@ # <vaadin-overlay>
 [![npm version](https://badgen.net/npm/v/@vaadin/overlay)](https://www.npmjs.com/package/@vaadin/overlay)
-[![Discord](https://img.shields.io/discord/732335336448852018?label=discord)](https://discord.gg/PHmkCKC)
 
@@ -9,0 +8,0 @@ ## License

src/vaadin-overlay-mixin.js

@@ -223,2 +223,3 @@ /**
       const rendererChanged = this._oldRenderer !== renderer;
+      const hasOldRenderer = this._oldRenderer !== undefined;
       this._oldRenderer = renderer;
@@ -229,3 +230,3 @@
 
-      if (rendererChanged) {
+      if (rendererChanged && hasOldRenderer) {
         this.innerHTML = '';
@@ -232,0 +233,0 @@ // Whenever a Lit-based renderer is used, it assigns a Lit part to the node it was rendered into.

src/vaadin-overlay-position-mixin.js

@@ -149,3 +149,4 @@ /**
     __addUpdatePositionEventListeners() {
-      window.addEventListener('resize', this._updatePosition);
+      window.visualViewport.addEventListener('resize', this._updatePosition);
+      window.visualViewport.addEventListener('scroll', this.__onScroll, true);
 
@@ -160,3 +161,4 @@ this.__positionTargetAncestorRootNodes = getAncestorRootNodes(this.positionTarget);
     __removeUpdatePositionEventListeners() {
-      window.removeEventListener('resize', this._updatePosition);
+      window.visualViewport.removeEventListener('resize', this._updatePosition);
+      window.visualViewport.removeEventListener('scroll', this.__onScroll, true);
 
@@ -209,5 +211,7 @@ if (this.__positionTargetAncestorRootNodes) {
       // If the scroll event occurred inside the overlay, ignore it.
-      if (!this.contains(e.target)) {
-        this._updatePosition();
+      if (e.target instanceof Node && this.contains(e.target)) {
+        return;
       }
+
+      this._updatePosition();
     }
@@ -214,0 +218,0 @@

src/vaadin-overlay-styles.js

@@ -42,3 +42,4 @@ /**
   :host([hidden]),
-  :host(:not([opened]):not([closing])) {
+  :host(:not([opened]):not([closing])),
+  :host(:not([opened]):not([closing])) [part='overlay'] {
     display: none !important;
@@ -45,0 +46,0 @@ }

No alert changes

Improved metrics

Total package byte prevSize

70498

increased by0.37%

Lines of code

1554

increased by0.32%

Worsened metrics

Number of lines in readme file

10

decreased by-9.09%

Dependency changes

• + Added@vaadin/a11y-base@24.4.0-beta1(transitive)

• + Added@vaadin/component-base@24.4.0-beta1(transitive)

• + Added@vaadin/icon@24.4.0-beta1(transitive)

• + Added@vaadin/vaadin-lumo-styles@24.4.0-beta1(transitive)

• + Added@vaadin/vaadin-material-styles@24.4.0-beta1(transitive)

• + Added@vaadin/vaadin-themable-mixin@24.4.0-beta1(transitive)

• - Removed@vaadin/a11y-base@24.4.0-alpha9(transitive)

• - Removed@vaadin/component-base@24.4.0-alpha9(transitive)

• - Removed@vaadin/icon@24.4.0-alpha9(transitive)

• - Removed@vaadin/vaadin-lumo-styles@24.4.0-alpha9(transitive)

• - Removed@vaadin/vaadin-material-styles@24.4.0-alpha9(transitive)

• - Removed@vaadin/vaadin-themable-mixin@24.4.0-alpha9(transitive)

• Updated@vaadin/a11y-base@24.4.0-beta1

• Updated@vaadin/component-base@24.4.0-beta1

• Updated@vaadin/vaadin-lumo-styles@24.4.0-beta1

• Updated@vaadin/vaadin-material-styles@24.4.0-beta1

• Updated@vaadin/vaadin-themable-mixin@24.4.0-beta1