@vaadin/vaadin-checkbox - npm Package Compare versions

Comparing version 2.2.7 to 2.2.8

package.json

@@ -13,3 +13,3 @@ {
   "name": "@vaadin/vaadin-checkbox",
-  "version": "2.2.7",
+  "version": "2.2.8",
   "main": "vaadin-checkbox.js",
@@ -16,0 +16,0 @@ "author": "Vaadin Ltd",

README.md

@@ -117,3 +117,3 @@ [![npm version](https://badgen.net/npm/v/@vaadin/vaadin-checkbox)](https://www.npmjs.com/package/@vaadin/vaadin-checkbox)
 
-We are using [ESLint](http://eslint.org/) for linting JavaScript code. You can check if your code is following our standards by running `gulp lint`, which will automatically lint all `.js` files as well as JavaScript snippets inside `.html` files.
+We are using [ESLint](http://eslint.org/) for linting JavaScript code. You can check if your code is following our standards by running `npm run lint`, which will automatically lint all `.js` files as well as JavaScript snippets inside `.html` files.
 
@@ -120,0 +120,0 @@

src/vaadin-checkbox-group.js

@@ -186,2 +186,4 @@ /**
           this._addCheckboxToValue(checkbox.value);
+        } else if (this.value.indexOf(checkbox.value) > -1) {
+          checkbox.checked = true;
         }
@@ -230,12 +232,9 @@ });
   _addCheckboxToValue(value) {
-    const update = this.value.slice(0);
-    update.push(value);
-    this.value = update;
+    if (this.value.indexOf(value) === -1) {
+      this.value = this.value.concat(value);
+    }
   }
 
   _removeCheckboxFromValue(value) {
-    const update = this.value.slice(0);
-    const index = update.indexOf(value);
-    update.splice(index, 1);
-    this.value = update;
+    this.value = this.value.filter(v => v !== value);
   }
@@ -242,0 +241,0 @@

src/vaadin-checkbox.js

@@ -113,3 +113,3 @@ /**
   static get version() {
-    return '2.2.7';
+    return '2.2.8';
   }
@@ -305,3 +305,3 @@
     this.checked = !this.checked;
-    this.dispatchEvent(new CustomEvent('change', {composed: true, bubbles: true}));
+    this.dispatchEvent(new CustomEvent('change', {composed: false, bubbles: true}));
   }
@@ -308,0 +308,0 @@

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

44852

increased by0.06%

Worsened metrics

Lines of code

885

decreased by-0.11%

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes