@vaadin/vaadin-combo-box - npm Package Compare versions

Comparing version 4.1.0-beta2 to 4.1.0

package.json

@@ -13,3 +13,3 @@ {
   "name": "@vaadin/vaadin-combo-box",
-  "version": "4.1.0-beta2",
+  "version": "4.1.0",
   "main": "vaadin-combo-box.js",
@@ -40,3 +40,3 @@ "author": "Vaadin Ltd",
     "@vaadin/vaadin-item": "^2.1.0-beta2",
-    "@vaadin/vaadin-element-mixin": "^1.1.2"
+    "@vaadin/vaadin-element-mixin": "^2.0.0"
   },
@@ -43,0 +43,0 @@ "devDependencies": {

README.md

@@ -1,2 +0,3 @@
-[![npm version](https://badge.fury.io/js/%40vaadin%2Fvaadin-combo-box.svg)](https://badge.fury.io/js/%40vaadin%2Fvaadin-combo-box)
+[![npm version](https://badgen.net/npm/v/@vaadin/vaadin-combo-box)](https://www.npmjs.com/package/@vaadin/vaadin-combo-box)
+[![Bower version](https://badgen.net/github/release/vaadin/vaadin-combo-box)](https://github.com/vaadin/vaadin-combo-box/releases)
 [![Published on webcomponents.org](https://img.shields.io/badge/webcomponents.org-published-blue.svg)](https://www.webcomponents.org/element/vaadin/vaadin-combo-box)
@@ -3,0 +4,0 @@ [![Build Status](https://travis-ci.org/vaadin/vaadin-combo-box.svg?branch=master)](https://travis-ci.org/vaadin/vaadin-combo-box)

src/vaadin-combo-box-dropdown-wrapper.js

@@ -177,3 +177,3 @@ /**
   _setOverlayHeight() {
-    if (!this.positionTarget || !this._selector) {
+    if (!this.opened || !this.positionTarget || !this._selector) {
       return;
@@ -180,0 +180,0 @@ }

src/vaadin-combo-box-mixin.js

@@ -486,3 +486,3 @@ /**
     microTask.run(() => this.$.overlay.adjustScrollPosition());
-    setTimeout(() => this.$.overlay.$.dropdown.notifyResize(), 1);
+    setTimeout(() => this._resizeDropdown(), 1);
 
@@ -598,2 +598,6 @@
 
+  _resizeDropdown() {
+    this.$.overlay.$.dropdown.notifyResize();
+  }
+
   _updateHasValue(hasValue) {
@@ -699,11 +703,5 @@ if (hasValue) {
 
-      // async needed to reposition correctly after filtering
-      // (especially when aligned on top of input)
-      setTimeout(() => {
-        this.$.overlay.$.dropdown.notifyResize();
-        this.$.overlay.updateViewportBoundaries();
-        this.$.overlay.ensureItemsRendered();
-        this.$.overlay._selector.notifyResize();
-        flush && flush();
-      }, 1);
+      if (this.opened) {
+        this._repositionOverlay();
+      }
     }
@@ -727,5 +725,19 @@ }
 
-    this.$.overlay.$.dropdown.notifyResize();
+    if (this.opened) {
+      this._resizeDropdown();
+    }
   }
 
+  _repositionOverlay() {
+    // async needed to reposition correctly after filtering
+    // (especially when aligned on top of input)
+    setTimeout(() => {
+      this._resizeDropdown();
+      this.$.overlay.updateViewportBoundaries();
+      this.$.overlay.ensureItemsRendered();
+      this.$.overlay._selector.notifyResize();
+      flush && flush();
+    }, 1);
+  }
+
   _indexOfValue(value, items) {
@@ -732,0 +744,0 @@ if (items && this._isValidValue(value)) {

src/vaadin-combo-box.js

@@ -170,3 +170,3 @@ /**
   static get version() {
-    return '4.1.0-beta2';
+    return '4.1.0';
   }
@@ -173,0 +173,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Number of low quality alerts

0

decreased by-100%

Number of lines in readme file

146

increased by0.69%

Worsened metrics

Total package byte prevSize

266642

decreased by-56.13%

Number of package files

52

decreased by-22.39%

Lines of code

2140

decreased by-22.8%

Dependency changes

• - Removed@vaadin/vaadin-development-mode-detector@1.1.0(transitive)

• - Removed@vaadin/vaadin-element-mixin@1.1.2(transitive)

• - Removed@vaadin/vaadin-usage-statistics@1.1.0(transitive)

• Updated@vaadin/vaadin-element-mixin@^2.0.0