@vaadin/vaadin-dialog - npm Package Compare versions

Comparing version 2.2.0-alpha1 to 2.2.0-alpha2

package.json

@@ -13,3 +13,3 @@ {
   "name": "@vaadin/vaadin-dialog",
-  "version": "2.2.0-alpha1",
+  "version": "2.2.0-alpha2",
   "main": "vaadin-dialog.js",
@@ -21,2 +21,7 @@ "author": "Vaadin Ltd",
   },
+  "files": [
+    "vaadin-*.js",
+    "src",
+    "theme"
+  ],
   "resolutions": {
@@ -26,9 +31,8 @@ "inherits": "2.0.3",
     "supports-color": "3.1.2",
-    "type-detect": "1.0.0",
-    "@webcomponents/webcomponentsjs": "2.0.0-beta.2"
+    "type-detect": "1.0.0"
   },
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/vaadin-overlay": "^3.2.0-alpha2",
-    "@vaadin/vaadin-themable-mixin": "^1.2.1",
+    "@vaadin/vaadin-overlay": "^3.2.0-alpha3",
+    "@vaadin/vaadin-themable-mixin": "^1.3.2",
     "@vaadin/vaadin-lumo-styles": "^1.1.0",
@@ -39,10 +43,10 @@ "@vaadin/vaadin-material-styles": "^1.1.0",
   "devDependencies": {
-    "@polymer/iron-component-page": "^3.0.0-pre.15",
-    "@polymer/iron-demo-helpers": "^3.0.0-pre.15",
-    "@polymer/iron-test-helpers": "^3.0.0-pre.15",
+    "@polymer/iron-component-page": "^3.0.0-pre.18",
+    "@polymer/iron-demo-helpers": "^3.0.0-pre.18",
+    "@polymer/iron-test-helpers": "^3.0.0-pre.18",
     "@vaadin/vaadin-button": "^2.1.0",
-    "@webcomponents/webcomponentsjs": "^2.0.0-beta.2",
-    "wct-browser-legacy": "^0.0.1-pre.11",
+    "@webcomponents/webcomponentsjs": "^2.0.0",
+    "wct-browser-legacy": "^1.0.1",
     "@vaadin/vaadin-demo-helpers": "^2.0.1"
   }
 }

README.md

@@ -124,2 +124,7 @@ [![npm version](https://badgen.net/npm/v/@vaadin/vaadin-dialog)](https://www.npmjs.com/package/@vaadin/vaadin-dialog)
 
+## Big Thanks
+
+Cross-browser Testing Platform and Open Source <3 Provided by [Sauce Labs](https://saucelabs.com).
+
+
 ## Contributing
@@ -126,0 +131,0 @@

src/vaadin-dialog.js

@@ -12,5 +12,5 @@ /**
 import { FlattenedNodesObserver } from '@polymer/polymer/lib/utils/flattened-nodes-observer.js';
+import { ThemePropertyMixin } from '@vaadin/vaadin-themable-mixin/vaadin-theme-property-mixin.js';
 import { html } from '@polymer/polymer/lib/utils/html-tag.js';
 const $_documentContainer = document.createElement('template');
-$_documentContainer.setAttribute('style', 'display: none;');
 
@@ -97,2 +97,5 @@ $_documentContainer.innerHTML = `<dom-module id="vaadin-dialog-overlay-styles" theme-for="vaadin-dialog-overlay">
  *
+ * Note: the `theme` attribute value set on `<vaadin-dialog>` is
+ * propagated to the internal `<vaadin-dialog-overlay>` component.
+ *
  * See [ThemableMixin – how to apply styles for shadow parts](https://github.com/vaadin/vaadin-themable-mixin/wiki)
@@ -102,5 +105,6 @@ *
  * @mixes Vaadin.ElementMixin
+ * @mixes Vaadin.ThemePropertyMixin
  * @demo demo/index.html
  */
-class DialogElement extends ElementMixin(PolymerElement) {
+class DialogElement extends ThemePropertyMixin(ElementMixin(PolymerElement)) {
   static get template() {
@@ -114,3 +118,3 @@ return html`
 
-    <vaadin-dialog-overlay id="overlay" on-opened-changed="_onOverlayOpened" with-backdrop="" focus-trap="">
+    <vaadin-dialog-overlay id="overlay" on-opened-changed="_onOverlayOpened" with-backdrop="" theme\$="[[theme]]" focus-trap="">
     </vaadin-dialog-overlay>
@@ -125,3 +129,3 @@ `;
   static get version() {
-    return '2.2.0-alpha1';
+    return '2.2.0-alpha2';
   }
@@ -166,2 +170,7 @@
 
+      /**
+       * Theme to apply to the overlay element
+       */
+      theme: String,
+
       _contentTemplate: Object,
@@ -217,2 +226,9 @@
 
+  /**
+   * Manually invoke existing renderer.
+   */
+  render() {
+    this.$.overlay.render();
+  }
+
   _templateOrRendererChanged(template, renderer) {
@@ -219,0 +235,0 @@ if (template && renderer) {

theme/lumo/vaadin-dialog-styles.js

 import '@vaadin/vaadin-lumo-styles/spacing.js';
 import '@vaadin/vaadin-lumo-styles/mixins/overlay.js';
 const $_documentContainer = document.createElement('template');
-$_documentContainer.setAttribute('style', 'display: none;');
 
@@ -6,0 +5,0 @@ $_documentContainer.innerHTML = `<dom-module id="lumo-dialog" theme-for="vaadin-dialog-overlay">

theme/material/vaadin-dialog-styles.js

 import '@vaadin/vaadin-material-styles/mixins/overlay.js';
 import '@vaadin/vaadin-material-styles/shadow.js';
 const $_documentContainer = document.createElement('template');
-$_documentContainer.setAttribute('style', 'display: none;');
 
@@ -6,0 +5,0 @@ $_documentContainer.innerHTML = `<dom-module id="material-dialog" theme-for="vaadin-dialog-overlay">

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Number of lines in readme file

139

increased by3.73%

Worsened metrics

Total package byte prevSize

27359

decreased by-62.58%

Number of package files

9

decreased by-43.75%

Lines of code

325

decreased by-3.56%

Number of medium supply chain risk alerts

1

increased byInfinity%

Dependency changes

• Updated@vaadin/vaadin-overlay@^3.2.0-alpha3

• Updated@vaadin/vaadin-themable-mixin@^1.3.2