@vaadin/vaadin-dialog - npm Package Compare versions

Comparing version 2.4.0 to 2.5.0-alpha1

package.json

@@ -13,3 +13,3 @@ {
   "name": "@vaadin/vaadin-dialog",
-  "version": "2.4.0",
+  "version": "2.5.0-alpha1",
   "main": "vaadin-dialog.js",
@@ -22,3 +22,5 @@ "author": "Vaadin Ltd",
   "files": [
+    "vaadin-*.d.ts",
     "vaadin-*.js",
+    "@types",
     "src",
@@ -36,15 +38,15 @@ "theme"
     "@polymer/iron-resizable-behavior": "^3.0.0",
-    "@vaadin/vaadin-overlay": "^3.4.0",
-    "@vaadin/vaadin-themable-mixin": "^1.5.2",
+    "@vaadin/vaadin-overlay": "^3.5.0",
+    "@vaadin/vaadin-themable-mixin": "^1.6.1",
     "@vaadin/vaadin-lumo-styles": "^1.6.0",
     "@vaadin/vaadin-material-styles": "^1.3.2",
-    "@vaadin/vaadin-element-mixin": "^2.3.0"
+    "@vaadin/vaadin-element-mixin": "^2.4.1"
   },
   "scripts": {
-  "generate-typings": "gen-typescript-declarations --outDir . --verify"
-},
-"devDependencies": {
+    "generate-typings": "gen-typescript-declarations --outDir . --verify"
+  },
+  "devDependencies": {
     "@polymer/iron-component-page": "^4.0.0",
     "@polymer/iron-test-helpers": "^3.0.0",
-    "@vaadin/vaadin-button": "^2.3.0",
+    "@vaadin/vaadin-button": "^2.4.0-alpha1",
     "@webcomponents/webcomponentsjs": "^2.0.0",
@@ -51,0 +53,0 @@ "wct-browser-legacy": "^1.0.1",

src/vaadin-dialog-draggable-mixin.js

@@ -17,2 +17,3 @@ const TOUCH_DEVICE = (() => {
       return {
+        /** @private */
         _touchDevice: {
@@ -25,2 +26,3 @@ type: Boolean,
 
+    /** @protected */
     ready() {
@@ -37,2 +39,3 @@ super.ready();
 
+    /** @private */
     _startDrag(e) {
@@ -62,2 +65,3 @@ if (this.draggable && (e.button === 0 || e.touches)) {
 
+    /** @private */
     _drag(e) {
@@ -73,2 +77,3 @@ const event = this.__getMouseOrFirstTouchEvent(e);
 
+    /** @private */
     _stopDrag() {
@@ -75,0 +80,0 @@ window.removeEventListener('mouseup', this._stopDrag);

src/vaadin-dialog-resizable-mixin.js

@@ -105,2 +105,3 @@ const $_documentContainer = document.createElement('template');
   class VaadinDialogResizableMixin extends superClass {
+    /** @protected */
     ready() {
@@ -114,2 +115,3 @@ super.ready();
 
+    /** @private */
     _addResizeListeners() {
@@ -133,2 +135,7 @@ // Note: edge controls added before corners
 
+    /**
+     * @param {!MouseEvent | !TouchEvent} e
+     * @param {!DialogResizableDirection} direction
+     * @protected
+     */
     _startResize(e, direction) {
@@ -150,2 +157,7 @@ if (e.button === 0 || e.touches) {
 
+    /**
+     * @param {!MouseEvent | !TouchEvent} e
+     * @param {!DialogResizableDirection} resizer
+     * @protected
+     */
     _resize(e, resizer) {
@@ -194,2 +206,6 @@ const event = this.__getMouseOrFirstTouchEvent(e);
 
+    /**
+     * @param {!DialogResizableDirection} direction
+     * @protected
+     */
     _stopResize(direction) {
@@ -203,2 +219,6 @@ window.removeEventListener('mousemove', this._resizeListeners.resize[direction]);
 
+    /**
+     * @return {!DialogResizeDimensions}
+     * @protected
+     */
     _getResizeDimensions() {
@@ -205,0 +225,0 @@ const {width, height} = getComputedStyle(this.$.overlay.$.overlay);

src/vaadin-dialog.js

@@ -134,4 +134,6 @@ /**
  * @extends PolymerElement
+ * @mixes ThemePropertyMixin
  * @mixes ElementMixin
- * @mixes ThemePropertyMixin
+ * @mixes DialogDraggableMixin
+ * @mixes DialogResizableMixin
  * @demo demo/index.html
@@ -163,3 +165,3 @@ */
   static get version() {
-    return '2.4.0';
+    return '2.5.0-alpha1';
   }
@@ -171,2 +173,3 @@
        * True if the overlay is currently displayed.
+       * @type {boolean}
        */
@@ -181,2 +184,3 @@ opened: {
        * Set to true to disable closing dialog on outside click
+       * @type {boolean}
        */
@@ -190,2 +194,3 @@ noCloseOnOutsideClick: {
        * Set to true to disable closing dialog on Escape press
+       * @type {boolean}
        */
@@ -208,6 +213,5 @@ noCloseOnEsc: {
       /**
-       * Theme to apply to the overlay element
+       * @type {HTMLTemplateElement | undefined}
+       * @protected
        */
-      theme: String,
-
       _contentTemplate: Object,
@@ -221,2 +225,3 @@
        * - `dialog` The reference to the `<vaadin-dialog>` element.
+       * @type {OverlayRenderer | undefined}
        */
@@ -227,2 +232,3 @@ renderer: Function,
        * Set to true to remove backdrop and allow click events on background elements.
+       * @type {boolean}
        */
@@ -240,2 +246,3 @@ modeless: {
        * "`draggable`" class to it.
+       * @type {boolean}
        */
@@ -250,2 +257,3 @@ draggable: {
        * Set to true to enable resizing the dialog by dragging the corners and edges.
+       * @type {boolean}
        */
@@ -258,4 +266,6 @@ resizable: {
 
+      /** @private */
       _oldTemplate: Object,
 
+      /** @private */
       _oldRenderer: Object
@@ -273,2 +283,3 @@ };
 
+  /** @protected */
   ready() {
@@ -288,2 +299,3 @@ super.ready();
 
+  /** @private */
   _preventMove(e) {
@@ -295,2 +307,6 @@ if (e.touches.length < 2) {
 
+  /**
+   * @param {!Array<!Node>} nodes
+   * @protected
+   */
   _setTemplateFromNodes(nodes) {
@@ -300,2 +316,3 @@ this._contentTemplate = nodes.filter(node => node.localName && node.localName === 'template')[0] || this._contentTemplate;
 
+  /** @private */
   _removeNewRendererOrTemplate(template, oldTemplate, renderer, oldRenderer) {
@@ -316,2 +333,3 @@ if (template !== oldTemplate) {
 
+  /** @private */
   _templateOrRendererChanged(template, renderer) {
@@ -331,2 +349,3 @@ if (template && renderer) {
 
+  /** @protected */
   disconnectedCallback() {
@@ -337,2 +356,3 @@ super.disconnectedCallback();
 
+  /** @private */
   _openedChanged(opened) {
@@ -345,2 +365,3 @@ if (opened) {
 
+  /** @private */
   _ariaLabelChanged(ariaLabel) {
@@ -354,2 +375,3 @@ if (ariaLabel !== undefined && ariaLabel !== null) {
 
+  /** @private */
   _onOverlayOpened(e) {
@@ -363,2 +385,3 @@ if (e.detail.value === false) {
    * Close the dialog if `noCloseOnOutsideClick` isn't set to true
+   * @private
    */
@@ -373,2 +396,3 @@ _handleOutsideClick(e) {
    * Close the dialog if `noCloseOnEsc` isn't set to true
+   * @private
    */
@@ -381,2 +405,6 @@ _handleEscPress(e) {
 
+  /**
+   * @param {!DialogOverlayBoundsParam} bounds
+   * @protected
+   */
   _setBounds(bounds) {
@@ -400,2 +428,3 @@ const overlay = this.$.overlay.$.overlay;
 
+  /** @private */
   _bringOverlayToFront() {
@@ -407,2 +436,6 @@ if (this.modeless) {
 
+  /**
+   * @return {!DialogOverlayBounds}
+   * @protected
+   */
   _getOverlayBounds() {
@@ -419,2 +452,7 @@ const overlay = this.$.overlay.$.overlay;
 
+  /**
+   * @param {!MouseEvent | !TouchEvent} e
+   * @return {boolean}
+   * @protected
+   */
   _eventInWindow(e) {
@@ -424,2 +462,7 @@ return e.clientX >= 0 && e.clientX <= window.innerWidth && e.clientY >= 0 && e.clientY <= window.innerHeight;
 
+  /**
+   * @param {!MouseEvent | !TouchEvent} e
+   * @return {!MouseEvent | !Touch}
+   * @protected
+   */
   __getMouseOrFirstTouchEvent(e) {
@@ -426,0 +469,0 @@ return e.touches ? e.touches[0] : e;

vaadin-dialog.js

 import './theme/lumo/vaadin-dialog.js';
+export * from './src/vaadin-dialog.js';

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No repository

Supply chain risk

Package does not have a linked source code repository. Without this field, a package will have no reference to the location of the source code use to generate the package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

50414

increased by23.7%

Number of package files

16

increased by45.45%

Lines of code

977

increased by42.21%

Worsened metrics

Number of low quality alerts

1

increased byInfinity%

Dependency changes

• Updated@vaadin/vaadin-element-mixin@^2.4.1

• Updated@vaadin/vaadin-overlay@^3.5.0

• Updated@vaadin/vaadin-themable-mixin@^1.6.1