@vaadin/vaadin-grid - npm Package Compare versions

Comparing version 5.2.1 to 5.2.2

package.json

@@ -18,3 +18,3 @@ {
   "name": "@vaadin/vaadin-grid",
-  "version": "5.2.1",
+  "version": "5.2.2",
   "main": "vaadin-grid.js",
@@ -21,0 +21,0 @@ "author": "Vaadin Ltd",

README.md

@@ -0,0 +0,0 @@ [![npm version](https://badge.fury.io/js/%40vaadin%2Fvaadin-grid.svg)](https://badge.fury.io/js/%40vaadin%2Fvaadin-grid)

src/vaadin-grid-selection-column.js

@@ -154,25 +154,22 @@ /**
   disconnectedCallback() {
-    super.disconnectedCallback();
+    this._grid.removeEventListener('active-item-changed', this._boundOnActiveItemChanged);
+    this._grid.removeEventListener('data-provider-changed', this._boundOnDataProviderChanged);
+    this._grid.removeEventListener('filter-changed', this._boundOnSelectedItemsChanged);
+    this._grid.removeEventListener('selected-items-changed', this._boundOnSelectedItemsChanged);
 
-    if (this._grid) {
-      this._grid.removeEventListener('active-item-changed', this._boundOnActiveItemChanged);
-      this._grid.removeEventListener('data-provider-changed', this._boundOnDataProviderChanged);
-      this._grid.removeEventListener('filter-changed', this._boundOnSelectedItemsChanged);
-      this._grid.removeEventListener('selected-items-changed', this._boundOnSelectedItemsChanged);
-
-      const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
-      if (isSafari && window.ShadyDOM && this.parentElement) {
-        // Detach might have beem caused by order change.
-        // Shady on safari doesn't restore isAttached so we'll need to do it manually.
-        const parent = this.parentElement;
-        const nextSibling = this.nextElementSibling;
-        parent.removeChild(this);
-        if (nextSibling) {
-          parent.insertBefore(this, nextSibling);
-        } else {
-          parent.appendChild(this);
-        }
+    const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);
+    if (isSafari && window.ShadyDOM && this.parentElement) {
+      // Detach might have beem caused by order change.
+      // Shady on safari doesn't restore isAttached so we'll need to do it manually.
+      const parent = this.parentElement;
+      const nextSibling = this.nextElementSibling;
+      parent.removeChild(this);
+      if (nextSibling) {
+        parent.insertBefore(this, nextSibling);
+      } else {
+        parent.appendChild(this);
       }
+    }
 
-    }
+    super.disconnectedCallback();
   }
@@ -179,0 +176,0 @@

src/vaadin-grid.js

@@ -313,3 +313,3 @@ /**
   static get version() {
-    return '5.2.1';
+    return '5.2.2';
   }
@@ -316,0 +316,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

253441

decreased by-0.08%

Lines of code

6672

decreased by-0.03%

No dependency changes