@vaadin/vaadin-overlay - npm Package Compare versions

Comparing version 21.0.0-alpha0.b163d3a8c to 21.0.0-alpha1

package.json

 {
   "name": "@vaadin/vaadin-overlay",
-  "version": "21.0.0-alpha0.b163d3a8c",
+  "version": "21.0.0-alpha1",
   "description": "vaadin-overlay",
@@ -30,6 +30,6 @@ "main": "vaadin-overlay.js",
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/vaadin-element-mixin": "^21.0.0-alpha0.b163d3a8c",
-    "@vaadin/vaadin-lumo-styles": "^21.0.0-alpha0.b163d3a8c",
-    "@vaadin/vaadin-material-styles": "^21.0.0-alpha0.b163d3a8c",
-    "@vaadin/vaadin-themable-mixin": "^21.0.0-alpha0.b163d3a8c"
+    "@vaadin/vaadin-element-mixin": "^21.0.0-alpha1",
+    "@vaadin/vaadin-lumo-styles": "^21.0.0-alpha1",
+    "@vaadin/vaadin-material-styles": "^21.0.0-alpha1",
+    "@vaadin/vaadin-themable-mixin": "^21.0.0-alpha1"
   },
@@ -40,5 +40,5 @@ "devDependencies": {
     "@vaadin/testing-helpers": "^0.2.1",
-    "@vaadin/vaadin-button": "^21.0.0-alpha0.b163d3a8c",
-    "@vaadin/vaadin-radio-button": "^21.0.0-alpha0.b163d3a8c",
-    "@vaadin/vaadin-text-field": "^21.0.0-alpha0.b163d3a8c",
+    "@vaadin/vaadin-button": "^21.0.0-alpha1",
+    "@vaadin/vaadin-radio-button": "^21.0.0-alpha1",
+    "@vaadin/vaadin-text-field": "^21.0.0-alpha1",
     "sinon": "^9.2.1"
@@ -49,3 +49,3 @@ },
   },
-  "gitHead": "e1ed53b0be7b77493e3a23a076f4e47c16674dbd"
+  "gitHead": "8542c7dadc4c86e454a48613f0f2d027dcb5aa86"
 }

src/vaadin-overlay.js

@@ -905,13 +905,10 @@ /**
 
+    if (rendererChanged) {
+      this.content = this;
+      this.content.innerHTML = '';
+    }
+
     if (template && templateOrInstancePropsChanged) {
       this._stampOverlayTemplate(template, instanceProps);
     } else if (renderer && (rendererChanged || openedChanged || ownerOrModelChanged)) {
-      this.content = this;
-
-      if (rendererChanged) {
-        while (this.content.firstChild) {
-          this.content.removeChild(this.content.firstChild);
-        }
-      }
-
       if (opened) {
@@ -918,0 +915,0 @@ this.render();

No alert changes

Worsened metrics

Total package byte prevSize

66845

decreased by-0.24%

Lines of code

1519

decreased by-0.13%

Dependency changes

• Updated@vaadin/vaadin-element-mixin@^21.0.0-alpha1

• Updated@vaadin/vaadin-lumo-styles@^21.0.0-alpha1

• Updated@vaadin/vaadin-material-styles@^21.0.0-alpha1

• Updated@vaadin/vaadin-themable-mixin@^21.0.0-alpha1