@vaadin/vaadin-overlay - npm Package Compare versions

Comparing version 3.2.0-alpha2 to 3.2.0-alpha3

package.json

@@ -14,3 +14,3 @@ {
   "name": "@vaadin/vaadin-overlay",
-  "version": "3.2.0-alpha2",
+  "version": "3.2.0-alpha3",
   "main": "vaadin-overlay.js",
@@ -22,2 +22,7 @@ "author": "Vaadin Ltd",
   },
+  "files": [
+    "vaadin-*.js",
+    "src",
+    "theme"
+  ],
   "resolutions": {
@@ -28,4 +33,3 @@ "@webcomponents/webcomponentsjs": "2.0.0",
     "supports-color": "3.1.2",
-    "type-detect": "1.0.0",
-    "@webcomponents/webcomponentsjs": "2.0.0-beta.2"
+    "type-detect": "1.0.0"
   },
@@ -37,19 +41,19 @@ "dependencies": {
     "@vaadin/vaadin-material-styles": "^1.1.0-beta1",
-    "@polymer/iron-overlay-behavior": "^3.0.0-pre.15"
+    "@polymer/iron-overlay-behavior": "^3.0.0-pre.18"
   },
   "devDependencies": {
     "@vaadin/vaadin-demo-helpers": "^2.0.1",
-    "@polymer/iron-component-page": "^3.0.0-pre.15",
-    "@polymer/iron-demo-helpers": "^3.0.0-pre.15",
-    "@polymer/iron-test-helpers": "^3.0.0-pre.15",
+    "@polymer/iron-component-page": "^3.0.0-pre.18",
+    "@polymer/iron-demo-helpers": "^3.0.0-pre.18",
+    "@polymer/iron-test-helpers": "^3.0.0-pre.18",
     "@vaadin/vaadin-button": "^2.1.0",
     "@vaadin/vaadin-text-field": "^2.1.1",
     "@vaadin/vaadin-radio-button": "^1.1.0",
-    "@polymer/iron-form": "^3.0.0-pre.15",
-    "@polymer/iron-input": "^3.0.0-pre.15",
-    "@webcomponents/webcomponentsjs": "^2.0.0-beta.2",
-    "@polymer/paper-button": "^3.0.0-pre.15",
-    "@polymer/paper-input": "^3.0.0-pre.15",
-    "wct-browser-legacy": "^0.0.1-pre.11"
+    "@polymer/iron-form": "^3.0.0-pre.18",
+    "@polymer/iron-input": "^3.0.0-pre.18",
+    "@webcomponents/webcomponentsjs": "^2.0.0",
+    "@polymer/paper-button": "^3.0.0-pre.18",
+    "@polymer/paper-input": "^3.0.0-pre.18",
+    "wct-browser-legacy": "^1.0.1"
   }
 }

src/vaadin-overlay.js

@@ -340,3 +340,5 @@ /**
 
-      _oldRenderer: Object
+      _oldRenderer: Object,
+
+      _oldOpened: Boolean
     };
@@ -348,3 +350,3 @@ }
       '_openedChanged(opened)',
-      '_templateOrRendererChanged(template, renderer, owner, model, instanceProps)'
+      '_templateOrRendererChanged(template, renderer, owner, model, instanceProps, opened)'
     ];
@@ -782,3 +784,12 @@ }
 
-  _templateOrRendererChanged(template, renderer, owner, model, instanceProps) {
+  /**
+   * Manually invoke existing renderer.
+   */
+  render() {
+    if (this.renderer) {
+      this.renderer.call(this.owner, this.content, this.owner, this.model);
+    }
+  }
+
+  _templateOrRendererChanged(template, renderer, owner, model, instanceProps, opened) {
     if (template && renderer) {
@@ -800,5 +811,8 @@ this._removeNewRendererOrTemplate(template, this._oldTemplate, renderer, this._oldRenderer);
 
-    if (template && !ownerOrModelChanged) {
+    const openedChanged = this._oldOpened !== opened;
+    this._oldOpened = opened;
+
+    if (template && templateOrInstancePropsChanged) {
       this._stampOverlayTemplate(template, instanceProps);
-    } else if (renderer && !templateOrInstancePropsChanged) {
+    } else if (renderer && (rendererChanged || openedChanged || ownerOrModelChanged)) {
       this.content = this;
@@ -812,3 +826,5 @@
 
-      this.renderer.call(owner, this.content, owner, model);
+      if (opened) {
+        this.render();
+      }
     }
@@ -815,0 +831,0 @@ }

theme/lumo/vaadin-overlay-styles.js

 import '@vaadin/vaadin-lumo-styles/mixins/overlay.js';
 const $_documentContainer = document.createElement('template');
-$_documentContainer.setAttribute('style', 'display: none;');
 
@@ -5,0 +4,0 @@ $_documentContainer.innerHTML = `<dom-module id="lumo-vaadin-overlay" theme-for="vaadin-overlay">

theme/material/vaadin-overlay-styles.js

 import '@vaadin/vaadin-material-styles/mixins/overlay.js';
 const $_documentContainer = document.createElement('template');
-$_documentContainer.setAttribute('style', 'display: none;');
 
@@ -5,0 +4,0 @@ $_documentContainer.innerHTML = `<dom-module id="material-vaadin-overlay" theme-for="vaadin-overlay">

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

40983

decreased by-61.38%

Number of package files

9

decreased by-40%

Lines of code

762

decreased by-0.13%

Dependency changes

• Updated@polymer/iron-overlay-behavior@^3.0.0-pre.18