@vaadin/vaadin-text-field - npm Package Compare versions

Comparing version 2.5.0 to 2.5.1

package.json

@@ -13,3 +13,3 @@ {
   "name": "@vaadin/vaadin-text-field",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "main": "vaadin-text-field.js",
@@ -16,0 +16,0 @@ "author": "Vaadin Ltd",

src/vaadin-email-field.js

@@ -33,3 +33,3 @@ /**
   static get version() {
-    return '2.5.0';
+    return '2.5.1';
   }
@@ -36,0 +36,0 @@

src/vaadin-integer-field.js

@@ -36,3 +36,3 @@ /**
   static get version() {
-    return '2.5.0';
+    return '2.5.1';
   }
@@ -39,0 +39,0 @@

src/vaadin-number-field.js

@@ -79,3 +79,3 @@ /**
   static get version() {
-    return '2.5.0';
+    return '2.5.1';
   }
@@ -117,3 +117,2 @@
         type: Number,
-        reflectToAttribute: true,
         value: 1,
@@ -301,3 +300,8 @@ observer: '_stepChanged'
   _stepChanged(step) {
-    this.inputElement.step = step;
+    // Avoid using initial value in validation
+    this.__validateByStep = this.__stepChangedCalled || this.getAttribute('step') !== null;
+    this.inputElement.step = this.__validateByStep ? step : 'any';
+
+    this.__stepChangedCalled = true;
+    this.setAttribute('step', step);
   }
@@ -336,10 +340,13 @@
   __onInputChange() {
-    this.checkValidity();
+    this.validate();
   }
 
-  checkValidity() {
+  validate() {
     // text-field mixin does not check against `min`, `max` and `step`
-    if (this.min !== undefined || this.max !== undefined || this.step !== 1) {
+    if (this.min !== undefined || this.max !== undefined || this.__validateByStep) {
       this.invalid = !this.inputElement.checkValidity();
+    } else {
+      this.invalid = !super.checkValidity();
     }
+
     return super.checkValidity();
@@ -346,0 +353,0 @@ }

src/vaadin-password-field.js

@@ -79,3 +79,3 @@ /**
   static get version() {
-    return '2.5.0';
+    return '2.5.1';
   }
@@ -82,0 +82,0 @@

src/vaadin-text-area.js

@@ -133,3 +133,3 @@ /**
   static get version() {
-    return '2.5.0';
+    return '2.5.1';
   }
@@ -136,0 +136,0 @@

src/vaadin-text-field.js

@@ -106,3 +106,3 @@ /**
   static get version() {
-    return '2.5.0';
+    return '2.5.1';
   }
@@ -109,0 +109,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

102959

increased by0.26%

Number of downloads

16631

increased by5.04%

Lines of code

2356

increased by0.21%

Published versions last year

22

increased by10%

No dependency changes