@venncity/errors - npm Package Compare versions

Comparing version 2.1.1 to 2.1.2

CHANGELOG.md

@@ -6,2 +6,10 @@ # Change Log
 
+## [2.1.2](https://github.com/venn-city/npm-shelf/compare/@venncity/errors@2.1.1...@venncity/errors@2.1.2) (2021-02-23)
+
+**Note:** Version bump only for package @venncity/errors
+
+
+
+
+
 ## [2.1.1](https://github.com/venn-city/npm-shelf/compare/@venncity/errors@2.1.0...@venncity/errors@2.1.1) (2021-02-15)
@@ -8,0 +16,0 @@

lib/cjs/errorHandler/errorHandler.js

@@ -35,3 +35,3 @@ "use strict";
     const namespace = cls_hooked_1.default.getNamespace(config.get('clsNamespace.sequelize'));
-    if (namespace) {
+    if (namespace && namespace.active) {
         namespace.set('error', error);
@@ -38,0 +38,0 @@ }

lib/cjs/errorReporting/sentry.d.ts

@@ -11,3 +11,3 @@ import * as Sentry from '@sentry/node';
 };
-export declare function buildTags(event: Pick<APIGatewayProxyEvent, 'headers'>, { impersonated, isPublicAccess, isService, id, email }: AuthDetailsFromRequest, context?: Pick<LambdaContext, 'awsRequestId' | 'functionVersion'>): Record<string, string>;
+export declare function buildTags(event: Pick<APIGatewayProxyEvent, 'headers'>, { impersonated, isPublicAccess, isService, id, email }?: AuthDetailsFromRequest, context?: Pick<LambdaContext, 'awsRequestId' | 'functionVersion'>): Record<string, string>;
 export declare function buildErrorContexts(event: Pick<APIGatewayProxyEvent, 'body'> & {
@@ -14,0 +14,0 @@ Records?: any;

lib/cjs/errorReporting/sentry.js

@@ -78,3 +78,3 @@ "use strict";
 // eslint-disable-next-line max-len
-function buildTags(event, { impersonated, isPublicAccess, isService, id, email }, context) {
+function buildTags(event, { impersonated, isPublicAccess, isService, id, email } = {}, context) {
     const tags = {};
@@ -81,0 +81,0 @@ const { headers } = event;

lib/cjs/errorReporting/sentry.test.js

@@ -101,2 +101,7 @@ "use strict";
         });
+        test('No authDetails passed', () => {
+            // @ts-ignore
+            const tags = sentry.buildTags(testEvents.httpEvent, undefined, null);
+            expect(tags).toMatchSnapshot();
+        });
     });
@@ -103,0 +108,0 @@ describe('buildErrorContexts', () => {

lib/esm/errorHandler/errorHandler.js

@@ -28,3 +28,3 @@ var __rest = (this && this.__rest) || function (s, e) {
     const namespace = cls.getNamespace(config.get('clsNamespace.sequelize'));
-    if (namespace) {
+    if (namespace && namespace.active) {
         namespace.set('error', error);
@@ -31,0 +31,0 @@ }

lib/esm/errorReporting/sentry.d.ts

@@ -11,3 +11,3 @@ import * as Sentry from '@sentry/node';
 };
-export declare function buildTags(event: Pick<APIGatewayProxyEvent, 'headers'>, { impersonated, isPublicAccess, isService, id, email }: AuthDetailsFromRequest, context?: Pick<LambdaContext, 'awsRequestId' | 'functionVersion'>): Record<string, string>;
+export declare function buildTags(event: Pick<APIGatewayProxyEvent, 'headers'>, { impersonated, isPublicAccess, isService, id, email }?: AuthDetailsFromRequest, context?: Pick<LambdaContext, 'awsRequestId' | 'functionVersion'>): Record<string, string>;
 export declare function buildErrorContexts(event: Pick<APIGatewayProxyEvent, 'body'> & {
@@ -14,0 +14,0 @@ Records?: any;

lib/esm/errorReporting/sentry.js

@@ -55,3 +55,3 @@ import { pick, get } from 'lodash';
 // eslint-disable-next-line max-len
-export function buildTags(event, { impersonated, isPublicAccess, isService, id, email }, context) {
+export function buildTags(event, { impersonated, isPublicAccess, isService, id, email } = {}, context) {
     const tags = {};
@@ -58,0 +58,0 @@ const { headers } = event;

lib/esm/errorReporting/sentry.test.js

@@ -80,2 +80,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
         });
+        test('No authDetails passed', () => {
+            // @ts-ignore
+            const tags = sentry.buildTags(testEvents.httpEvent, undefined, null);
+            expect(tags).toMatchSnapshot();
+        });
     });
@@ -82,0 +87,0 @@ describe('buildErrorContexts', () => {

package.json

 {
   "name": "@venncity/errors",
-  "version": "2.1.1",
+  "version": "2.1.2",
   "author": "Venn Engineering",
@@ -36,3 +36,3 @@ "main": "lib/cjs/index.js",
     "@sentry/types": "^5.22.3",
-    "@venncity/nested-config": "^3.1.6",
+    "@venncity/nested-config": "^3.1.7",
     "@venncity/schema-consts": "^4.1.9",
@@ -46,3 +46,3 @@ "cls-hooked": "^4.2.2",
   },
-  "gitHead": "6ff0cfd035866be44b762144c32b8adfdde9f2c7"
+  "gitHead": "e83432b233b00f1ce7578780864f534b455eb37f"
 }

src/errorHandler/errorHandler.ts

@@ -20,3 +20,3 @@ import jsonStringify from 'fast-safe-stringify';
   const namespace = cls.getNamespace(config.get('clsNamespace.sequelize'));
-  if (namespace) {
+  if (namespace && namespace.active) {
     namespace.set('error', error);
@@ -23,0 +23,0 @@ }

src/errorReporting/sentry.test.ts

@@ -77,2 +77,7 @@ import * as sentry from './sentry';
     });
+    test('No authDetails passed', () => {
+      // @ts-ignore
+      const tags = sentry.buildTags(testEvents.httpEvent, undefined, null);
+      expect(tags).toMatchSnapshot();
+    });
   });
@@ -79,0 +84,0 @@

src/errorReporting/sentry.ts

@@ -74,3 +74,3 @@ import { pick, get } from 'lodash';
 // eslint-disable-next-line max-len
-export function buildTags(event: Pick<APIGatewayProxyEvent, 'headers'>, { impersonated, isPublicAccess, isService, id, email }: AuthDetailsFromRequest, context?: Pick<LambdaContext, 'awsRequestId' | 'functionVersion'>) {
+export function buildTags(event: Pick<APIGatewayProxyEvent, 'headers'>, { impersonated, isPublicAccess, isService, id, email }: AuthDetailsFromRequest = {}, context?: Pick<LambdaContext, 'awsRequestId' | 'functionVersion'>) {
   const tags: Record<string, string> = {};
@@ -77,0 +77,0 @@ const { headers } = event;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

223109

increased by0.7%

Lines of code

3506

increased by0.43%

Dependency changes

• Updated@venncity/nested-config@^3.1.7