@visual-framework/embl-conditional-edit - npm Package Compare versions

Comparing version 1.0.0 to 1.0.1

CHANGELOG.md

@@ -6,12 +6,8 @@ # Change Log
 
-# 1.0.0 (2019-12-17)
+# 1.0.1
 
-**Note:** Version bump only for package @visual-framework/embl-conditional-edit
+* Bug: Avoid a recursion issue in embl-conditional-edit https://github.com/visual-framework/vf-core/pull/829
 
-
-
-
-
 # 1.0.0 (2019-12-17)
 
 * Initial stable release

embl-conditional-edit.js

@@ -29,6 +29,7 @@ // embl-conditional-edit
  * @param {element} [element] - the scopped element to be processed
+ * @param {string} [referrer] - what part of the page is asking for a check, we pass this to avoid recursion
  */
-function emblConditionalEditDetectParam(url,element) {
+function emblConditionalEditDetectParam(url,element,referrer) {
   var captured = /embl-conditional-edit=([^&]+)/.exec(url);
-  if (captured == null) {
+  if (captured == null && referrer != 'iframe') {
     // value not found
@@ -38,3 +39,4 @@
     if (window.self !== window.top) {
-      emblConditionalEditDetectParam(parent.window.location,element);
+      console.log(url, parent.window.location.href)
+      emblConditionalEditDetectParam(parent.window.location.href,element,'iframe');
     }
@@ -44,2 +46,3 @@
   }
+  captured = captured || false; // avoid null
   captured = captured[1];
@@ -46,0 +49,0 @@

package.json

 {
-  "version": "1.0.0",
+  "version": "1.0.1",
   "name": "@visual-framework/embl-conditional-edit",
@@ -23,3 +23,3 @@ "description": "embl-conditional-edit component",
   ],
-  "gitHead": "85d3f4d45ea4082e0181ca46692e6ff6f31a25d5"
+  "gitHead": "def4646ee3268ea95fe8d404ec338a3606e8c072"
 }

No alert changes

Improved metrics

Total package byte prevSize

9512

increased by2.72%

Lines of code

124

increased by2.48%

No dependency changes