@web/test-runner-chrome - npm Package Compare versions

Comparing version 0.13.0 to 0.13.1

dist/ChromeLauncher.d.ts

@@ -9,4 +9,4 @@ import * as puppeteerCore from 'puppeteer-core';
 }
-export declare type CreateBrowserContextFn = (args: CreateArgs) => BrowserContext | Promise<BrowserContext>;
-export declare type CreatePageFn = (args: CreateArgs & {
+export type CreateBrowserContextFn = (args: CreateArgs) => BrowserContext | Promise<BrowserContext>;
+export type CreatePageFn = (args: CreateArgs & {
     context: BrowserContext;
@@ -13,0 +13,0 @@ }) => Promise<Page>;

dist/ChromeLauncher.js

@@ -61,7 +61,7 @@ "use strict";
             if (!this.cachedExecutablePath) {
-                this.cachedExecutablePath = findExecutablePath_1.findExecutablePath();
+                this.cachedExecutablePath = (0, findExecutablePath_1.findExecutablePath)();
             }
             mergedOptions.executablePath = this.cachedExecutablePath;
         }
-        return puppeteer_core_1.launch(mergedOptions).catch(error => {
+        return (0, puppeteer_core_1.launch)(mergedOptions).catch(error => {
             console.error('');
@@ -68,0 +68,0 @@ console.error(`Failed to launch local browser installed at ${mergedOptions.executablePath}. ${errorHelp}`);

dist/ChromeLauncherPage.js

@@ -22,3 +22,5 @@ "use strict";
             this.nativeInstrumentationEnabledOnPage = true;
-            await this.puppeteerPage.coverage.startJSCoverage();
+            await this.puppeteerPage.coverage.startJSCoverage({
+                includeRawScriptCoverage: true,
+            });
         }
@@ -59,15 +61,9 @@ await this.puppeteerPage.setViewport({ height: 600, width: 800 });
         }
-        // get native coverage from puppeteer
-        // TODO: this is using a private puppeteer API to grab v8 code coverage, this can be removed
-        // when https://github.com/puppeteer/puppeteer/issues/2136 is resolved
-        const response = (await this.puppeteerPage
-            ._client()
-            .send('Profiler.takePreciseCoverage'));
-        const v8Coverage = response.result
-            // remove puppeteer specific scripts
-            .filter(r => r.url && r.url !== '__puppeteer_evaluation_script__');
-        const userAgent = await userAgentPromise;
-        await ((_b = this.puppeteerPage.coverage) === null || _b === void 0 ? void 0 : _b.stopJSCoverage());
+        const [userAgent, coverageResult] = await Promise.all([
+            userAgentPromise,
+            (_b = this.puppeteerPage.coverage) === null || _b === void 0 ? void 0 : _b.stopJSCoverage(),
+        ]);
+        const v8Coverage = coverageResult === null || coverageResult === void 0 ? void 0 : coverageResult.map(entry => entry.rawScriptCoverage).filter((cov) => cov !== undefined);
         this.nativeInstrumentationEnabledOnPage = false;
-        return test_runner_coverage_v8_1.v8ToIstanbul(config, testFiles, v8Coverage, userAgent);
+        return (0, test_runner_coverage_v8_1.v8ToIstanbul)(config, testFiles, v8Coverage, userAgent);
     }
@@ -74,0 +70,0 @@ }

dist/index.js

 "use strict";
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
-    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
 }) : (function(o, m, k, k2) {
@@ -6,0 +10,0 @@ if (k2 === undefined) k2 = k;

package.json

 {
   "name": "@web/test-runner-chrome",
-  "version": "0.13.0",
+  "version": "0.13.1",
   "publishConfig": {
@@ -49,3 +49,3 @@ "access": "public"
     "@web/test-runner-core": "^0.11.0",
-    "@web/test-runner-coverage-v8": "^0.6.0",
+    "@web/test-runner-coverage-v8": "^0.7.0",
     "chrome-launcher": "^0.15.0",
@@ -52,0 +52,0 @@ "puppeteer-core": "^19.8.1"

src/ChromeLauncherPage.ts

@@ -1,4 +0,4 @@
-import { Page } from 'puppeteer-core';
+import { Page, JSCoverageEntry } from 'puppeteer-core';
 import { TestRunnerCoreConfig } from '@web/test-runner-core';
-import { V8Coverage, v8ToIstanbul } from '@web/test-runner-coverage-v8';
+import { v8ToIstanbul } from '@web/test-runner-coverage-v8';
 import { SessionResult } from '@web/test-runner-core';
@@ -35,3 +35,5 @@
       this.nativeInstrumentationEnabledOnPage = true;
-      await this.puppeteerPage.coverage.startJSCoverage();
+      await this.puppeteerPage.coverage.startJSCoverage({
+        includeRawScriptCoverage: true,
+      });
     }
@@ -84,16 +86,9 @@
 
-    // get native coverage from puppeteer
-    // TODO: this is using a private puppeteer API to grab v8 code coverage, this can be removed
-    // when https://github.com/puppeteer/puppeteer/issues/2136 is resolved
-    const response = (await (this.puppeteerPage as any)
-      ._client()
-      .send('Profiler.takePreciseCoverage')) as {
-      result: V8Coverage[];
-    };
-    const v8Coverage = response.result
-      // remove puppeteer specific scripts
-      .filter(r => r.url && r.url !== '__puppeteer_evaluation_script__');
-
-    const userAgent = await userAgentPromise;
-    await this.puppeteerPage.coverage?.stopJSCoverage();
+    const [userAgent, coverageResult] = await Promise.all([
+      userAgentPromise,
+      this.puppeteerPage.coverage?.stopJSCoverage(),
+    ]);
+    const v8Coverage = coverageResult
+      ?.map(entry => entry.rawScriptCoverage)
+      .filter((cov): cov is Required<JSCoverageEntry>['rawScriptCoverage'] => cov !== undefined);
     this.nativeInstrumentationEnabledOnPage = false;
@@ -100,0 +95,0 @@

No alert changes

Worsened metrics

Total package byte prevSize

43792

decreased by-0.75%

Lines of code

696

decreased by-0.57%

Dependency changes

• + Added@web/test-runner-core@0.12.0(transitive)

• + Added@web/test-runner-coverage-v8@0.7.3(transitive)

• - Removed@web/test-runner-coverage-v8@0.6.1(transitive)

• Updated@web/test-runner-coverage-v8@^0.7.0