@wixc3/create-disposables - npm Package Compare versions

Comparing version 1.1.1 to 2.0.0

dist/create-disposables.d.ts

 export declare function createDisposables(): {
     dispose(): Promise<void>;
-    add<T extends {
-        dispose(): unknown;
-    } | (() => unknown)>(disposable: T): T;
+    add(disposable: Disposable): void;
 };
+export declare type DisposeFunction = () => unknown;
+export declare type Disposable = {
+    dispose: DisposeFunction;
+} | DisposeFunction;
+export declare type Disposables = ReturnType<typeof createDisposables>;
 //# sourceMappingURL=create-disposables.d.ts.map

dist/create-disposables.js

@@ -8,3 +8,3 @@ "use strict";
         async dispose() {
-            const toDispose = new Set(Array.from(disposables).reverse());
+            const toDispose = Array.from(disposables).reverse();
             disposables.clear();
@@ -22,3 +22,2 @@ for (const dispose of toDispose) {
             }
-            return disposable;
         },
@@ -25,0 +24,0 @@ };

dist/index.js

 "use strict";
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
-    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
 }) : (function(o, m, k, k2) {
@@ -6,0 +10,0 @@ if (k2 === undefined) k2 = k;

package.json

 {
   "name": "@wixc3/create-disposables",
-  "version": "1.1.1",
+  "version": "2.0.0",
   "description": "A utility for saving objects to be disposed",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

src/create-disposables.ts

@@ -6,3 +6,3 @@ export function createDisposables() {
     async dispose() {
-      const toDispose = new Set(Array.from(disposables).reverse());
+      const toDispose = Array.from(disposables).reverse();
       disposables.clear();
@@ -13,3 +13,3 @@ for (const dispose of toDispose) {
     },
-    add<T extends { dispose(): unknown } | (() => unknown)>(disposable: T): T {
+    add(disposable: Disposable) {
       if (typeof disposable === 'function') {
@@ -20,5 +20,8 @@ disposables.add(disposable);
       }
-      return disposable;
     },
   };
 }
+
+export type DisposeFunction = () => unknown;
+export type Disposable = { dispose: DisposeFunction } | DisposeFunction;
+export type Disposables = ReturnType<typeof createDisposables>;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

5552

increased by9.85%

Lines of code

81

increased by10.96%

No dependency changes