@wordpress/wordcount - npm Package Compare versions

Comparing version 2.0.2 to 2.0.3

build-module/index.js

@@ -81,5 +81,8 @@ import { extend, flow } from 'lodash';
 export function count(text, type, userSettings) {
-  var settings = loadSettings(type, userSettings);
+  if ('' === text) {
+    return 0;
+  }
 
   if (text) {
+    var settings = loadSettings(type, userSettings);
     var matchRegExp = settings[type + 'RegExp'];
@@ -86,0 +89,0 @@ var results = 'words' === settings.type ? matchWords(text, matchRegExp, settings) : matchCharacters(text, matchRegExp, settings);

build/index.js

@@ -100,5 +100,8 @@ "use strict";
 function count(text, type, userSettings) {
-  var settings = loadSettings(type, userSettings);
+  if ('' === text) {
+    return 0;
+  }
 
   if (text) {
+    var settings = loadSettings(type, userSettings);
     var matchRegExp = settings[type + 'RegExp'];
@@ -105,0 +108,0 @@ var results = 'words' === settings.type ? matchWords(text, matchRegExp, settings) : matchCharacters(text, matchRegExp, settings);

CHANGELOG.md

@@ -0,1 +1,7 @@
+## 2.0.3 (2018-10-29)
+
+### Polish
+
+- Fix: `count` returns 0 for empty strings ([#10602](https://github.com/WordPress/gutenberg/pull/10602))
+
 ## 2.0.0 (2018-09-05)
@@ -2,0 +8,0 @@

package.json

 {
 	"name": "@wordpress/wordcount",
-	"version": "2.0.2",
+	"version": "2.0.3",
 	"description": "WordPress word count utility.",
@@ -28,3 +28,3 @@ "author": "The WordPress Contributors",
 	},
-	"gitHead": "0aa5c4340f57a69ab935f9e819d74958aad2e022"
+	"gitHead": "308f6aa950705531ef9d360dc88bb9f4194542f5"
 }

src/index.js

@@ -95,4 +95,8 @@ import { extend, flow } from 'lodash';
 export function count( text, type, userSettings ) {
-	const settings = loadSettings( type, userSettings );
+	if ( '' === text ) {
+		return 0;
+	}
+
 	if ( text ) {
+		const settings = loadSettings( type, userSettings );
 		const matchRegExp = settings[ type + 'RegExp' ];
@@ -99,0 +103,0 @@ const results = ( 'words' === settings.type ) ?

src/test/index.test.js

@@ -88,3 +88,3 @@ /**
 		{
-			message: 'Empty Tags',
+			message: 'Empty tags',
 			string: '<p></p>',
@@ -95,2 +95,9 @@ words: 0,
 		},
+		{
+			message: 'Empty string',
+			string: '',
+			words: 0,
+			characters_excluding_spaces: 0,
+			characters_including_spaces: 0,
+		},
 	];
@@ -97,0 +104,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

88409

increased by0.47%

Lines of code

981

increased by1.66%

No dependency changes