acme-v2 - npm Package Compare versions

Comparing version 1.0.5 to 1.0.6

node.js

@@ -437,2 +437,4 @@ /*!
     }).then(function (resp) {
+      // https://tools.ietf.org/html/draft-ietf-acme-acme-12#section-7.1.3
+      // Possible values are: "pending" => ("invalid" || "ready") => "processing" => "valid"
       me._nonce = resp.toJSON().headers['replay-nonce'];
@@ -443,6 +445,2 @@
 
-      if ('processing' === resp.body.status) {
-        return ACME._wait().then(pollCert);
-      }
-
       if ('valid' === resp.body.status) {
@@ -455,9 +453,41 @@ me._expires = resp.body.expires;
 
+      if ('processing' === resp.body.status) {
+        return ACME._wait().then(pollCert);
+      }
+
+      if (me.debug) console.debug("Error: bad status:\n" + JSON.stringify(resp.body, null, 2));
+
+      if ('pending' === resp.body.status) {
+        return Promise.reject(new Error(
+          "Did not finalize order: status 'pending'."
+        + " Best guess: You have not accepted at least one challenge for each domain." + "\n\n"
+        + JSON.stringify(resp.body, null, 2)
+        ));
+      }
+
       if ('invalid' === resp.body.status) {
-        console.error('cannot finalize: badness');
-        return;
+        return Promise.reject(new Error(
+          "Did not finalize order: status 'invalid'."
+        + " Best guess: One or more of the domain challenges could not be verified"
+        + " (or the order was canceled)." + "\n\n"
+        + JSON.stringify(resp.body, null, 2)
+        ));
       }
 
-      console.error('(x) cannot finalize: badness');
-      return;
+      if ('ready' === resp.body.status) {
+        return Promise.reject(new Error(
+          "Did not finalize order: status 'ready'."
+        + " Hmmm... this state shouldn't be possible here. That was the last state."
+        + " This one should at least be 'processing'." + "\n\n"
+        + JSON.stringify(resp.body, null, 2) + "\n\n"
+        + "Please open an issue at https://git.coolaj86.com/coolaj86/acme-v2.js"
+        ));
+      }
+
+      return Promise.reject(new Error(
+        "Didn't finalize order: Unhandled status '" + resp.body.status + "'."
+      + " This is not one of the known statuses...\n\n"
+      + JSON.stringify(resp.body, null, 2) + "\n\n"
+      + "Please open an issue at https://git.coolaj86.com/coolaj86/acme-v2.js"
+      ));
     });
@@ -464,0 +494,0 @@ }

package.json

 {
   "name": "acme-v2",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "Free SSL. A framework for building Let's Encrypt v2 clients, and other ACME v2 (draft 11) clients. Successor to le-acme-core.js",
@@ -5,0 +5,0 @@ "homepage": "https://git.coolaj86.com/coolaj86/acme-v2.js",

README.md

@@ -179,14 +179,8 @@ | Sponsored by [ppl](https://ppl.family)
 
-Todo
-----
-
-* support ECDSA keys
-* Apr  5, 2018 - appears that sometimes 'pending' status cannot be progressed to 'processing' nor 'deactivated'
-  * this may be a bug in the staging API as it appears it cannot be cancelled either, but returns success status code
-
 Changelog
 ---------
 
-* v1.0.3
-  * documentation cleanup
+* v1.0.5 - cleanup logging
+* v1.0.4 - v6- compat use `promisify` from node's util or bluebird
+* v1.0.3 - documentation cleanup
 * v1.0.2
@@ -193,0 +187,0 @@ * use `options.contact` to provide raw contact array

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

44033

increased by3.05%

Lines of code

962

increased by2.89%

Worsened metrics

Number of lines in readme file

213

decreased by-2.74%

No dependency changes