activecampaign - npm Package Compare versions

Comparing version 0.1.0 to 1.0.0

lib/ActiveCampaign.js

@@ -26,9 +26,7 @@ var Connector = require(__dirname + "/Connector");
 
-		credentials_test: function(cb) {
-			Connector.credentials_test(function(response) {
-				return cb(response);
-			});
+		credentials_test: function() {
+			return Connector.credentials_test();
 		},
 		
-		api: function(path, post_data, cb) {
+		api: function(path, post_data) {
 			Connector.debug = this.debug;
@@ -115,5 +113,3 @@ if (this.debug) {
 
-			Connector.process_request(Connector, params, post_data, function(response) {
-				return cb(response);
-			});
+			return Connector.process_request(Connector, params, post_data);
 
@@ -120,0 +116,0 @@ }

lib/Connector.js

 var http = require("http"),
-    request = require("request");
+    request = require("request"),
+    RSVP = require("rsvp");
 
@@ -12,3 +13,3 @@ var Connector = {
 	request_method: "GET",
-		
+
 	construct: function(url, api_key, api_user, api_pass) {
@@ -37,14 +38,5 @@
 	
-	credentials_test: function(cb) {
+	credentials_test: function() {
 		var test_url = this.url + "&api_action=user_me&api_output=" + this.output;
-		var response = Connector.curl(test_url, {}, function(response) {
-			if (typeof response != "undefined" && response.result_code) {
-				// successful
-				return cb("1");
-			}
-			else {
-				// failed
-				return cb("0");
-			}
-		});
+		return Connector.curl(test_url, {});
 	},
@@ -67,10 +59,8 @@
 	
-	process_request: function(Connector, params, post_data, cb) {
+	process_request: function(Connector, params, post_data) {
 		var request_url = Connector.prepare_url(Connector.action, params);
-		var response = Connector.curl(request_url, post_data, function(response) {
-			return cb(response);
-		});
+		return Connector.curl(request_url, post_data);
 	},
 	
-	curl: function(url, post_data, cb) {
+	curl: function(url, post_data) {
 		if (this.version == 1) {
@@ -126,25 +116,26 @@ // find the method from the URL
 
-		request(request_options, function(error, response, body) {
-			var result = JSON.parse(body);
-			if (!error && response.statusCode == 200) {
-				
-				if (typeof result.result_code != "undefined") {
-					result.success = result.result_code;
-					if (!result.result_code) {
-						result.error = result.result_message;
+		var api_request = new RSVP.Promise(function(fulfill, reject) {
+			request(request_options, function(error, response, body) {
+				var result = JSON.parse(body);
+				if (!error && response.statusCode == 200) {
+					if (typeof result.result_code != "undefined") {
+						result.success = result.result_code;
+						if (!result.result_code) {
+							result.error = result.result_message;
+						}
+					} else if (typeof result.succeeded != "undefined") {
+						result.success = result.succeeded;
+						if (!result.succeeded) {
+							result.error = result.message;
+						}
 					}
+					fulfill(result);
+				} else {
+					reject(result);
 				}
-				else if (typeof result.succeeded != "undefined") {
-					result.success = result.succeeded;
-					if (!result.succeeded) {
-						result.error = result.message;
-					}
-				}
-				return cb(result);
-			}
-			else {
-				return cb(result);
-			}
+			});
 		});
 
+		return api_request;
+
 	}
@@ -151,0 +142,0 @@

package.json

@@ -5,3 +5,3 @@ {
   "author": "ActiveCampaign <[e-mail]>",
-  "version": "0.1.0",
+  "version": "1.0.0",
   "repository" : {
@@ -20,3 +20,4 @@ "type" : "git",
   "dependencies": {
-    "request": "2.9.x"
+    "request": "2.x",
+    "rsvp": "3.0.x"
   },
@@ -23,0 +24,0 @@ "devDependencies": {

README.md

@@ -23,7 +23,14 @@ # ActiveCampaign Node.js API wrapper
 
-	var ac = new ActiveCampaign("http://ACCOUNT.api-us1.com", "iy837huygda7dsgy");
+	var ac = new ActiveCampaign("https://ACCOUNT.api-us1.com", {{KEY}});
 
 	// TEST API credentials
-	var test = ac.credentials_test(function(response) {
-		console.log(response);
+	ac.credentials_test().then(function(result) {
+		// successful request
+		if (result.success) {
+			// VALID ACCOUNT
+		} else {
+			// INVALID ACCOUNT
+		}
+	}, function(result) {
+		// request error
 	});
@@ -33,20 +40,16 @@
 
-	var account = ac.api("account/view", {}, function(response) {
-		console.log(response);
-	
-		if (response.success) {
-
-			// successful request
-
-		}
-		else {
-
-			// request error
-			console.log(response.error);
-
-		}
+	var account_view = ac.api("account/view", {});
+	account_view.then(function(result) {
+		// successful request
+		console.log(result);
+	}, function(result) {
+		// request error
 	});
 
-	var contact_exists = ac.api("contact/view?email=[e-mail]", {}, function(response) {
-		console.log(response);
+	var contact_exists = ac.api("contact/view?email=[e-mail]", {});
+	contact_exists.then(function(result) {
+		// successful request
+		console.log(result);
+	}, function(result) {
+		// request error
 	});
@@ -65,4 +68,8 @@
 
-	var list_add = ac.api("list/add", list, function(response) {
-		console.log(response);
+	var list_add = ac.api("list/add", list);
+	list_add.then(function(result) {
+		// successful request
+		console.log(result);
+	}, function(result) {
+		// request error
 	});
@@ -69,0 +76,0 @@

Fixed alerts

No v1

Quality

Package is not semver >=1. This means it is not stable and does not support ^ ranges.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

15168

increased by0.08%

Number of low quality alerts

1

decreased by-50%

Number of lines in readme file

80

increased by9.59%

Worsened metrics

Dependency count

2

increased by100%

Lines of code

437

decreased by-2.89%

Dependency changes

• + Addedrsvp@3.0.x

• + Addedajv@6.12.6(transitive)

• + Addedasn1@0.2.6(transitive)

• + Addedassert-plus@1.0.0(transitive)

• + Addedasynckit@0.4.0(transitive)

• + Addedaws-sign2@0.7.0(transitive)

• + Addedaws4@1.13.2(transitive)

• + Addedbcrypt-pbkdf@1.0.2(transitive)

• + Addedcaseless@0.12.0(transitive)

• + Addedcombined-stream@1.0.8(transitive)

• + Addedcore-util-is@1.0.2(transitive)

• + Addeddashdash@1.14.1(transitive)

• + Addeddelayed-stream@1.0.0(transitive)

• + Addedecc-jsbn@0.1.2(transitive)

• + Addedextend@3.0.2(transitive)

• + Addedextsprintf@1.3.0(transitive)

• + Addedfast-deep-equal@3.1.3(transitive)

• + Addedfast-json-stable-stringify@2.1.0(transitive)

• + Addedforever-agent@0.6.1(transitive)

• + Addedform-data@2.3.3(transitive)

• + Addedgetpass@0.1.7(transitive)

• + Addedhar-schema@2.0.0(transitive)

• + Addedhar-validator@5.1.5(transitive)

• + Addedhttp-signature@1.2.0(transitive)

• + Addedis-typedarray@1.0.0(transitive)

• + Addedisstream@0.1.2(transitive)

• + Addedjsbn@0.1.1(transitive)

• + Addedjson-schema@0.4.0(transitive)

• + Addedjson-schema-traverse@0.4.1(transitive)

• + Addedjson-stringify-safe@5.0.1(transitive)

• + Addedjsprim@1.4.2(transitive)

• + Addedmime-db@1.52.0(transitive)

• + Addedmime-types@2.1.35(transitive)

• + Addedoauth-sign@0.9.0(transitive)

• + Addedperformance-now@2.1.0(transitive)

• + Addedpsl@1.15.0(transitive)

• + Addedpunycode@2.3.1(transitive)

• + Addedqs@6.5.3(transitive)

• + Addedrequest@2.88.2(transitive)

• + Addedrsvp@3.0.21(transitive)

• + Addedsafe-buffer@5.2.1(transitive)

• + Addedsafer-buffer@2.1.2(transitive)

• + Addedsshpk@1.18.0(transitive)

• + Addedtough-cookie@2.5.0(transitive)

• + Addedtunnel-agent@0.6.0(transitive)

• + Addedtweetnacl@0.14.5(transitive)

• + Addeduri-js@4.4.1(transitive)

• + Addeduuid@3.4.0(transitive)

• + Addedverror@1.10.0(transitive)

• - Removedrequest@2.9.203(transitive)

• Updatedrequest@2.x