affixing-header - npm Package Compare versions

Comparing version 0.3.2 to 0.3.3

package.json

 {
   "name": "affixing-header",
-  "version": "0.3.2",
+  "version": "0.3.3",
   "description": "An affixing header that behaves normally as a user navigates down a page, but reveals itself naturally when a user scrolls or drags upwards. Inspired by iOS Safari, Medium, and others.",
@@ -44,2 +44,3 @@ "main": "dist/affixing-header.js",
     "esperanto": "^0.6.24",
+    "extend": "^2.0.0",
     "finalhandler": "^0.3.4",
@@ -46,0 +47,0 @@ "jshint": "^2.6.3",

test/affixing-header-specs.js

@@ -1,2 +0,3 @@
-var webdriver = require('selenium-webdriver'),
+var extend    = require('extend'),
+    webdriver = require('selenium-webdriver'),
     chai      = require('chai'),
@@ -19,5 +20,5 @@ expect    = chai.expect,
     function setupDocument() {
-        browser.name = browser.name || 'chrome';
+        browser.browserName = browser.browserName || 'chrome';
     	if (process.env.SAUCE_USERNAME && process.env.TRAVIS_JOB_NUMBER) {
-            var tags = ['CI', browser.name],
+            var tags = ['CI', browser.browserName],
                 capabilities;
@@ -35,9 +36,7 @@ if (process.env.TRAVIS_PULL_REQUEST) {
                 accessKey           : process.env.SAUCE_ACCESS_KEY,
-                browserName         : browser.name,
                 name                : 'Testing affixing-header',
                 tags                : tags
             };
-            if (browser.version) {
-                capabilities.version = browser.version;
-            }
+            // Merge with browser settings
+            capabilities = extend(capabilities, browser);
     		driver = new webdriver.Builder()
@@ -48,7 +47,8 @@ .usingServer('http://' + process.env.SAUCE_USERNAME + ':' + process.env.SAUCE_ACCESS_KEY + '@ondemand.saucelabs.com:80/wd/hub')
     		driver = new webdriver.Builder()
-    		.forBrowser(browser.name)
+    		.forBrowser(browser.browserName)
     		.build();
     	}
-        console.log(('\n  Running tests for ' + browser.name).cyan);
-    	return driver.get('http://localhost:3000/test/index.html').then(function() {
+        console.log(('\n  Running tests for ' + browser.browserName + ' with test url ' + testState.get('testUrl')).cyan);
+
+    	return driver.get(testState.get('testUrl')).then(function() {
             driver.getSession().then(function (session) {
@@ -91,3 +91,3 @@ testState.update({sauceSessionId: session.getId()});
 
-        if (browser.name === 'ipad' || browser.name === 'iphone') {
+        if (browser.browserName === 'ipad' || browser.browserName === 'iphone') {
             // The simulator seems to be suuuuper slow
@@ -94,0 +94,0 @@ testDuration = 100000;

test/bootstrap.js

@@ -57,2 +57,5 @@ // BEGIN - Static server for test html
 // browserConfig.set(browsers.shift());
+
+testState.update({testUrl: 'http://localhost:3000/test/index.html'});
+
 var runner = mocha.run(function(failures) {
@@ -77,22 +80,1 @@ if (isSauceRequestQueued) {
 });
-
-// browsers.forEach(function(browser) {
-//     browserConfig.set(browser);
-//     // Start up Mocha
-//     var runner   = mocha.run(),
-//         isFailed = false;
-//     runner.on('fail', function() {
-//         isFailed = true;
-//     });
-//     runner.on('end', function() {
-//         if (process.env.SAUCE_USERNAME && process.env.SAUCE_SESSION_ID && process.env.TRAVIS_JOB_NUMBER) {
-//             var sauce = new Saucelabs({
-//                 username: process.env.SAUCE_USERNAME,
-//                 password: process.env.SAUCE_ACCESS_KEY
-//             });
-//             sauce.updateJob(process.env.SAUCE_SESSION_ID, {passed: !isFailed}, function () {});
-//         }
-//     });
-//
-//     // runTests(browser);
-// });

test/conductor.js

 // Test runner
 var runTests  = require('./affixing-header-specs'),
     browsers  = [
-        {name: 'chrome'},
-        {name: 'firefox'}
+        {browserName: 'chrome'},
+        {browserName: 'firefox'}
     ];
@@ -12,6 +12,7 @@
 	browsers.push(
-        {name: 'safari', version: 7},
-        // {name: 'ipad', version: 8},
-        // {name: 'iphone', version: 8},
-        {name: 'internet explorer'}
+        {browserName: 'safari', version: 7},
+        {browserName: 'ipad', version: '8.2', appiumVersion: '1.3.7'},
+        {browserName: 'iphone', version: '8.2', appiumVersion: '1.3.7'},
+        // {browserName: 'chrome', platformName: 'Android', platformVersion: '4.0', appiumVersion: '1.3.7'},
+        {browserName: 'internet explorer'}
 	);
@@ -18,0 +19,0 @@ }

test/helpers/state.js

@@ -1,6 +0,7 @@
-var extend = require('util')._extend;
+var extend = require('extend');
 
 var initialTestState = {
 	isFailing: false,
-	isReported: false
+	isReported: false,
+	sauceSessionId: ''
 };
@@ -11,6 +12,6 @@ var testState = extend({}, initialTestState);
 	update: function(state) {
-		extend(testState, state);
+		testState = extend(testState, state);
 	},
 	reset: function() {
-		testState = extend({}, initialTestState);
+		testState = extend(testState, initialTestState);
 	},
@@ -17,0 +18,0 @@ get: function(key) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

48871

decreased by-0.68%

Dev dependency count

16

increased by6.67%

Lines of code

772

decreased by-2.28%

No dependency changes