ali-ons - npm Package Compare versions

Comparing version 2.0.1 to 2.0.2

History.md

 
+2.0.2 / 2017-10-09
+==================
+
+  * fix: persist consumer offset issue
+
 2.0.1 / 2017-09-29
@@ -3,0 +8,0 @@ ==================

lib/consumer/mq_push_consumer.js

@@ -125,2 +125,3 @@ 'use strict';
       this._isClosed = true;
+      yield this.persistConsumerOffset();
       this._pullFromWhichNodeTable.clear();
@@ -131,3 +132,2 @@ this._subscriptions.clear();
 
-      yield this.persistConsumerOffset();
       yield this._mqClient.unregisterConsumer(this.consumerGroup);
@@ -134,0 +134,0 @@ yield this._mqClient.close();

lib/store/local_file.js

@@ -173,3 +173,3 @@ 'use strict';
       e.message = 'readLocalOffset() failed' + e.message;
-      this.logger.error(e);
+      this.emit('error', e);
       return null;
@@ -176,0 +176,0 @@ }

lib/store/remote_broker.js

@@ -94,3 +94,3 @@ 'use strict';
       err.message = `RemoteBrokerOffsetStore.readOffset failed, topic: ${messageQueue.topic}, group: ${this.groupName}, queueId: ${messageQueue.queueId}, type: ${type} ` + err.message;
-      this.logger.error(err);
+      this.emit('error', err);
     }
@@ -119,5 +119,9 @@ return -1;
     }
+    this.logger.info('[mq:RemoteBrokerOffsetStore] %s', info);
     this.offsetTable = newTable;
     const ret = yield gather(tasks);
-    this.logger.info('[mq:RemoteBrokerOffsetStore] ' + info + ' result:' + JSON.stringify(ret));
+    const errors = ret.filter(item => item.isError);
+    for (const err of errors) {
+      this.emit('error', err);
+    }
   }
@@ -124,0 +128,0 @@

package.json

 {
   "name": "ali-ons",
-  "version": "2.0.1",
+  "version": "2.0.2",
   "description": "Aliyun Open Notification Service Client",
@@ -58,3 +58,3 @@ "main": "./lib/index.js",
     "egg-bin": "^4.3.3",
-    "eslint": "^4.7.2",
+    "eslint": "^4.8.0",
     "eslint-config-egg": "^5.1.1",
@@ -61,0 +61,0 @@ "mm": "^2.2.0",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

137307

increased by0.12%

Lines of code

3911

increased by0.1%

No dependency changes