amalgamatic - npm Package Compare versions

Comparing version 3.0.0 to 4.0.0

CHANGELOG.md

 # 2014-09-22
-34 commits against 25 issues, over 6 days [`bc295f6`](https://github.com/ucsf-ckm/amalgamatic/commit/bc295f6)⎆[`e966def`](https://github.com/ucsf-ckm/amalgamatic/commit/e966def)
+2 commits against 1 issues, over an hour [`c14b146`](https://github.com/ucsf-ckm/amalgamatic/commit/c14b146)⎆[`ea42929`](https://github.com/ucsf-ckm/amalgamatic/commit/ea42929)
 
+## [**4.0.0**](https://github.com/ucsf-ckm/amalgamatic/issues?milestone=4&state=closed)
+- [**#36**](https://github.com/ucsf-ckm/amalgamatic/issues/36) Fix broken option passing
+
+---
+
+
+# 2014-09-22
+36 commits against 25 issues, over 6 days [`48f8c3d`](https://github.com/ucsf-ckm/amalgamatic/commit/48f8c3d)⎆[`e966def`](https://github.com/ucsf-ckm/amalgamatic/commit/e966def)
+
 ## [**3.0.0**](https://github.com/ucsf-ckm/amalgamatic/issues?milestone=3&state=closed)
@@ -38,12 +47,1 @@ - [**#21**](https://github.com/ucsf-ckm/amalgamatic/issues/21) search() needs to have two types of callbacks?
 
-
-## [**2.0.0**](https://github.com/ucsf-ckm/amalgamatic/issues?milestone=2&state=closed)
-- [**#12**](https://github.com/ucsf-ckm/amalgamatic/issues/12) Move libguides collector to its own npm module
-- [**#11**](https://github.com/ucsf-ckm/amalgamatic/issues/11) Move millennium collector to its own npm module
-- [**#8**](https://github.com/ucsf-ckm/amalgamatic/issues/8) add() should load collectors from npm modules
-- [**#6**](https://github.com/ucsf-ckm/amalgamatic/issues/6) Add libguides connector
-- [**#2**](https://github.com/ucsf-ckm/amalgamatic/issues/2) Add configurability
-
-## [**1.1.0**](https://github.com/ucsf-ckm/amalgamatic/issues?milestone=1&state=closed)
-- [**#1**](https://github.com/ucsf-ckm/amalgamatic/issues/1) Millennium should be a default collection
-

index.js

@@ -23,3 +23,3 @@ var async = require('async');
     if (collection in collections) {
-      collections[collection].search(query.searchTerm, function (value) {
+      collections[collection].search(query, function (value) {
         if (maxResults && value.data instanceof Array) {
@@ -26,0 +26,0 @@ value.data = value.data.slice(0, maxResults);

package.json

@@ -8,3 +8,3 @@ {
   },
-  "version": "3.0.0",
+  "version": "4.0.0",
   "dependencies": {
@@ -11,0 +11,0 @@ "async": "^0.9.0",

test/index.js

@@ -7,4 +7,6 @@ /*jshint expr: true*/
 	search: function (query, callback) {
-		if (query === 'error') {
+		if (query.searchTerm === 'error') {
 			callback({error: 'There was an error! Oh noes!'});
+		} else if (query.searchTerm === 'options') {
+			callback(query);
 		} else {
@@ -34,2 +36,10 @@ callback({data: [
 
+	it('should pass the entire query object to the plugin', function (done) {
+		var query = {searchTerm: 'options', fhqwhgads: 'fhqwhgads'};
+		amalgamatic.search(query, function (results) {
+			expect(results).to.deep.equal({plugin: query});
+			done();
+		});
+	});
+
 	it('returns only specified collection', function (done) {
@@ -36,0 +46,0 @@ amalgamatic.search({searchTerm: 'medicine', collections: ['plugin']}, function (results) {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

125

increased by7.76%

Worsened metrics

Total package byte prevSize

11938

decreased by-0.59%

No dependency changes