amalgamatic - npm Package Compare versions

Comparing version 5.0.0 to 5.0.1

CHANGELOG.md

@@ -1,4 +0,6 @@
-# 2014-09-25
-13 commits against 9 issues, over 6 hours [`0a9e574`](https://github.com/ucsf-ckm/amalgamatic/commit/0a9e574)⎆[`a53f149`](https://github.com/ucsf-ckm/amalgamatic/commit/a53f149)
 
+## [**5.0.1**](https://github.com/ucsf-ckm/amalgamatic/issues?milestone=7&state=closed)
+- [**#51**](https://github.com/ucsf-ckm/amalgamatic/issues/51) TypeError if error thrown with maxResults set
+- [**#49**](https://github.com/ucsf-ckm/amalgamatic/issues/49) Add CONTRIBUTING.md
+
 ## [**5.0.0**](https://github.com/ucsf-ckm/amalgamatic/issues?milestone=6&state=closed)
@@ -12,14 +14,2 @@ - [**#48**](https://github.com/ucsf-ckm/amalgamatic/issues/48) update README for proper callback documentation
 
-
-## Issues
-- [**#46**](https://github.com/ucsf-ckm/amalgamatic/issues/46) add .travis.yml for #45
-- [**#44**](https://github.com/ucsf-ckm/amalgamatic/issues/44) callback-signature, fix for #38
-- [**#43**](https://github.com/ucsf-ckm/amalgamatic/issues/43) include plugin name in pluginCallback argument
-
----
-
-
-# 2014-09-25
-5 commits against 3 issues, over 3 days [`17ee010`](https://github.com/ucsf-ckm/amalgamatic/commit/17ee010)⎆[`81c6b7a`](https://github.com/ucsf-ckm/amalgamatic/commit/81c6b7a)
-
 ## [**4.0.1**](https://github.com/ucsf-ckm/amalgamatic/issues?milestone=5&state=closed)
@@ -29,21 +19,5 @@ - [**#40**](https://github.com/ucsf-ckm/amalgamatic/issues/40) Callback should not be required
 
-
-## Issues
-- [**#41**](https://github.com/ucsf-ckm/amalgamatic/issues/41) tolerate null callback, fixes #40
-
----
-
-
-# 2014-09-22
-2 commits against 1 issues, over an hour [`c14b146`](https://github.com/ucsf-ckm/amalgamatic/commit/c14b146)⎆[`ea42929`](https://github.com/ucsf-ckm/amalgamatic/commit/ea42929)
-
 ## [**4.0.0**](https://github.com/ucsf-ckm/amalgamatic/issues?milestone=4&state=closed)
 - [**#36**](https://github.com/ucsf-ckm/amalgamatic/issues/36) Fix broken option passing
 
----
-
-
-# 2014-09-22
-36 commits against 25 issues, over 6 days [`48f8c3d`](https://github.com/ucsf-ckm/amalgamatic/commit/48f8c3d)⎆[`e966def`](https://github.com/ucsf-ckm/amalgamatic/commit/e966def)
-
 ## [**3.0.0**](https://github.com/ucsf-ckm/amalgamatic/issues?milestone=3&state=closed)
@@ -70,14 +44,1 @@ - [**#21**](https://github.com/ucsf-ckm/amalgamatic/issues/21) search() needs to have two types of callbacks?
 
-
-## Issues
-- [**#33**](https://github.com/ucsf-ckm/amalgamatic/issues/33) add pluginCallback option for #21
-- [**#32**](https://github.com/ucsf-ckm/amalgamatic/issues/32) limit number of results returned if maxResults specified, for #4
-- [**#31**](https://github.com/ucsf-ckm/amalgamatic/issues/31) more descriptive properties for #30
-- [**#28**](https://github.com/ucsf-ckm/amalgamatic/issues/28) document API in README for now at least, for #3
-- [**#27**](https://github.com/ucsf-ckm/amalgamatic/issues/27) handle errors for #26
-- [**#25**](https://github.com/ucsf-ckm/amalgamatic/issues/25) use test double rather than nock + amalgamatic-sfx, fixes #24
-- [**#23**](https://github.com/ucsf-ckm/amalgamatic/issues/23) update method signature for #20 and #22
-- [**#13**](https://github.com/ucsf-ckm/amalgamatic/issues/13) add() should load collectors from npm modules, closes #8
-- [**#10**](https://github.com/ucsf-ckm/amalgamatic/issues/10) Add libguides connector for #6
-- [**#7**](https://github.com/ucsf-ckm/amalgamatic/issues/7) allow programmatic adding of collectors for #2
-

index.js

@@ -24,3 +24,3 @@ var async = require('async');
       collections[collection].search(query, function (err, value) {
-        if (maxResults && value.data instanceof Array) {
+        if (maxResults && value && value.data instanceof Array) {
           value.data = value.data.slice(0, maxResults);
@@ -27,0 +27,0 @@ }

package.json

@@ -8,3 +8,3 @@ {
   },
-  "version": "5.0.0",
+  "version": "5.0.1",
   "dependencies": {
@@ -11,0 +11,0 @@ "async": "^0.9.0",

test/index.js

@@ -100,2 +100,12 @@ /*jshint expr: true*/
 
+	it('does not cause a TypeError if maxResults set and plugin returns an error', function (done) {
+		var pluginCallback = function (err, value) {
+			expect(err).to.be.ok;
+			expect(value).to.be.not.ok;
+			done();
+		};
+
+		amalgamatic.search({searchTerm: 'error', pluginCallback: pluginCallback, maxResults: 5});
+	});
+
 	it('runs pluginCallback for each plugin before runnning its own callback', function (done) {
@@ -102,0 +112,0 @@ var pluginCallbackRan = false;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Number of package files

11

increased by10%

Lines of code

171

increased by4.91%

Worsened metrics

Total package byte prevSize

13778

decreased by-9.95%

No dependency changes