angular-component - npm Package Compare versions

Comparing version 0.0.1 to 0.0.2

dist/angular-component.js

@@ -1,2 +0,2 @@
-/*! angular-component v0.0.1 | (c) 2015 @toddmotto | https://github.com/toddmotto/angular-component */
+/*! angular-component v0.0.2 | (c) 2016 @toddmotto | https://github.com/toddmotto/angular-component */
 (function () {
@@ -18,2 +18,6 @@
 
+    if (hijacked.component) {
+      return hijacked;
+    }
+
     function component(name, options) {
@@ -38,3 +42,3 @@
           controller: options.controller || angular.noop,
-          controllerAs: identifierForController(options.controller) || options.controllerAs || name,
+          controllerAs: identifierForController(options.controller) || options.controllerAs || '$ctrl',
           template: makeInjectable(
@@ -45,7 +49,3 @@ !options.template && !options.templateUrl ? '' : options.template
           transclude: options.transclude === undefined ? true : options.transclude,
-          scope: (
-            options.isolate === false ?
-            true :
-            options.bindings
-          ),
+          scope: {},
           bindToController: !!options.bindings,
@@ -52,0 +52,0 @@ restrict: options.restrict || 'E'

dist/angular-component.min.js

@@ -1,2 +0,2 @@
-/*! angular-component v0.0.1 | (c) 2015 @toddmotto | https://github.com/toddmotto/angular-component */
-!function(){function t(t,n){if(n&&"string"==typeof n)return n;if("string"==typeof t){var e=/^(\S+)(\s+as\s+(\w+))?$/.exec(t);if(e)return e[3]}}function n(){function n(n,e){function o(r){function o(t){return angular.isFunction(t)?function(n,e){return r.invoke(t,this,{$element:n,$attrs:e})}:t}return{controller:e.controller||angular.noop,controllerAs:t(e.controller)||e.controllerAs||n,template:o(e.template||e.templateUrl?e.template:""),templateUrl:o(e.templateUrl),transclude:void 0===e.transclude?!0:e.transclude,scope:e.isolate===!1?!0:e.bindings,bindToController:!!e.bindings,restrict:e.restrict||"E"}}return e.$canActivate&&(o.$canActivate=e.$canActivate),e.$routeConfig&&(o.$routeConfig=e.$routeConfig),o.$inject=["$injector"],r.directive(n,o)}var r=e.apply(this,arguments);return r.component=n,r}var e=angular.module;angular.module=n}();
+/*! angular-component v0.0.2 | (c) 2016 @toddmotto | https://github.com/toddmotto/angular-component */
+!function(){function t(t,n){if(n&&"string"==typeof n)return n;if("string"==typeof t){var e=/^(\S+)(\s+as\s+(\w+))?$/.exec(t);if(e)return e[3]}}function n(){function n(n,e){function o(n){function r(t){return angular.isFunction(t)?function(e,r){return n.invoke(t,this,{$element:e,$attrs:r})}:t}return{controller:e.controller||angular.noop,controllerAs:t(e.controller)||e.controllerAs||"$ctrl",template:r(e.template||e.templateUrl?e.template:""),templateUrl:r(e.templateUrl),transclude:void 0===e.transclude?!0:e.transclude,scope:{},bindToController:!!e.bindings,restrict:e.restrict||"E"}}return e.$canActivate&&(o.$canActivate=e.$canActivate),e.$routeConfig&&(o.$routeConfig=e.$routeConfig),o.$inject=["$injector"],r.directive(n,o)}var r=e.apply(this,arguments);return r.component?r:(r.component=n,r)}var e=angular.module;angular.module=n}();

package.json

 {
   "name": "angular-component",
-  "version": "0.0.1",
+  "version": "0.0.2",
+  "main": "./dist/angular-component.min.js",
   "description": "Add .component() support for Angular 1.2+",
@@ -5,0 +6,0 @@ "author": "@toddmotto",

README.md

@@ -58,3 +58,3 @@ # angular-component.js
 ```
-npm install --save toddmotto/angular-component
+npm install --save angular-component
 ```
@@ -85,3 +85,5 @@
 
+- 0.0.2
+  - Bugfix isolate scope when `bindings` is omitted, short-circuit if .component() is already supported
 - 0.0.1
   - Initial release

src/angular-component.js

@@ -17,2 +17,6 @@ (function () {
 
+    if (hijacked.component) {
+      return hijacked;
+    }
+
     function component(name, options) {
@@ -37,3 +41,3 @@
           controller: options.controller || angular.noop,
-          controllerAs: identifierForController(options.controller) || options.controllerAs || name,
+          controllerAs: identifierForController(options.controller) || options.controllerAs || '$ctrl',
           template: makeInjectable(
@@ -44,7 +48,3 @@ !options.template && !options.templateUrl ? '' : options.template
           transclude: options.transclude === undefined ? true : options.transclude,
-          scope: (
-            options.isolate === false ?
-            true :
-            options.bindings
-          ),
+          scope: {},
           bindToController: !!options.bindings,
@@ -51,0 +51,0 @@ restrict: options.restrict || 'E'

No alert changes

Improved metrics

Total package byte prevSize

11270

increased by2.06%

Number of downloads

2032

increased by9.42%

Number of package files

12

increased by9.09%

Lines of code

173

increased by3.59%

Number of lines in readme file

88

increased by2.33%

No dependency changes