angular-esri-map - npm Package Compare versions

Comparing version 1.0.0-beta.5 to 1.0.0-rc.1

bower.json

 {
   "name": "angular-esri-map",
-  "version": "v1.0.0-beta.5",
+  "version": "1.0.0-rc.1",
   "homepage": "https://github.com/Esri/angular-esri-map",
   "authors": [
     "Javier Abadía <[e-mail]> (https://github.com/jabadia)",
+    "Dave Bouwman <[e-mail]> (https://github.com/dbouwman)",
     "Patrick Arlt <[e-mail]> (http://patrickarlt.com)",
     "Matt Priour <[e-mail]> (https://github.com/mpriour)",
+    "Jacob Wasilkowski <[e-mail]> (https://github.com/jwasil)",
     "Tom Wayson <[e-mail]> (http://tomwayson.com)"
@@ -10,0 +12,0 @@ ],

CHANGELOG.md

@@ -8,4 +8,34 @@ # Change Log
 
-Coming soon...
+## [v1.0.0-rc.1]
 
+### Added
+
+Added support for defining and using a custom basemap. [#121](https://github.com/Esri/angular-esri-map/pull/121)
+
+### Changed
+
+Fixed a bug causing the legend to not show after re-loading a route. [#129](https://github.com/Esri/angular-esri-map/pull/129)
+
+Map directive no longer creates an InfoWindow from map options infoWindow property. [#116](https://github.com/Esri/angular-esri-map/pull/116)
+
+Update map and layer directives to use controllerAs and bindToController instead of injecting $socpe into controllers. [#123](https://github.com/Esri/angular-esri-map/pull/123)
+
+Refactored shared code out of directives and into controllers and services. [#108](https://github.com/Esri/angular-esri-map/issues/108)
+
+Moved services out of the esri.map module and into an esri.core module that can be used stand-alone. [#69](https://github.com/Esri/angular-esri-map/issues/69)
+
+### Documentation
+
+Added additional example pages for dynamic map services and custom basemap. [#124](https://github.com/Esri/angular-esri-map/issues/124)
+
+Added an API section to the documentation pages generated by ngDocs. [#99](https://github.com/Esri/angular-esri-map/issues/99)
+
+### Tests
+
+Added additional e2e tests for dynamic map services and legend. [#115](https://github.com/Esri/angular-esri-map/issues/115) and [#139](https://github.com/Esri/angular-esri-map/issues/139)
+
+Added unit tests for esri.core services using Karma [#30](https://github.com/Esri/angular-esri-map/issues/30) and [#146](https://github.com/Esri/angular-esri-map/issues/146)
+
+Replaced jshint with eslint for automated linting and code style enforcement [#138](https://github.com/Esri/angular-esri-map/issues/138)
+
 ## [v1.0.0-beta.5]
@@ -132,4 +162,5 @@
 
-[unreleased]: https://github.com/Esri/angular-esri-map/compare/v1.0.0-beta.5...HEAD
-[v1.0.0-beta.4]: https://github.com/Esri/angular-esri-map/compare/v1.0.0-beta.4...v1.0.0-beta.4
+[unreleased]: https://github.com/Esri/angular-esri-map/compare/v1.0.0-rc.1...HEAD
+[v1.0.0-rc.1]: https://github.com/Esri/angular-esri-map/compare/v1.0.0-beta.5...v1.0.0-rc.1
+[v1.0.0-beta.5]: https://github.com/Esri/angular-esri-map/compare/v1.0.0-beta.4...v1.0.0-beta.5
 [v1.0.0-beta.4]: https://github.com/Esri/angular-esri-map/compare/v0.0.1-beta.3...v1.0.0-beta.4
@@ -136,0 +167,0 @@ [v0.0.1-beta.3]: https://github.com/Esri/angular-esri-map/compare/v0.0.1-beta.2...v0.0.1-beta.3

gulpfile.js

@@ -0,4 +1,6 @@
+/*eslint-env node*/
+/*eslint indent:0*/
 'use strict';
 var gulp = require('gulp');
-var jshint = require('gulp-jshint');
+var eslint = require('gulp-eslint');
 var clean = require('gulp-clean');
@@ -15,35 +17,72 @@ var concat = require('gulp-concat');
 var angularProtractor = require('gulp-angular-protractor');
+var KarmaServer = require('karma').Server;
 
 // source directives and services
 var srcJsFiles = 'src/**/*.js';
+var siteJsFiles = 'site/app/**/*.js';
+var unitTestSpecFiles = 'test/unit/**/*.spec.js';
 
 // lint source javascript files
 gulp.task('lint', function() {
-  return gulp.src(srcJsFiles)
-    .pipe(jshint())
-    .pipe(jshint.reporter('default'));
+  return gulp.src([srcJsFiles, siteJsFiles])
+    // eslint() attaches the lint output to the eslint property
+    // of the file object so it can be used by other modules.
+    .pipe(eslint())
+    // eslint.format() outputs the lint results to the console.
+    // Alternatively use eslint.formatEach() (see Docs).
+    .pipe(eslint.format())
+    // To have the process exit with an error code (1) on
+    // lint error, return the stream and pipe to failOnError last.
+    .pipe(eslint.failOnError());
 });
 
 // clean built copies of javascript files
-// from dist folder and docs
+// from dist folder and site
 gulp.task('clean', function() {
-  return gulp.src(['dist', 'docs/lib'])
+  return gulp.src(['dist', 'site/lib'])
     .pipe(clean({force: true}));
 });
 
+// concatenate and minify core javascript files
+// and copy into dist folder and site
+gulp.task('build-core-js', function() {
+  return gulp.src([
+    'src/core/esri.core.module.js',
+    'src/core/esriLoader.js',
+    'src/core/esriRegistry.js',
+    'src/core/esriMapUtils.js',
+    'src/core/esriLayerUtils.js'])
+    .pipe(concat('angular-esri-core.js'))
+    .pipe(gulp.dest('dist'))
+    .pipe(gulp.dest('site/lib'))
+    .pipe(stripDebug())
+    .pipe(ngAnnotate())
+    .pipe(uglify())
+    .pipe(rename('angular-esri-core.min.js'))
+    .pipe(gulp.dest('dist'))
+    .on('error', gutil.log);
+});
+
 // concatenate and minify source javascript files
-// and copy into dist folder and docs
+// and copy into dist folder and site
 gulp.task('build-js', function() {
   return gulp.src([
-    'src/services/esriLoader.js',
-    'src/services/esriRegistry.js',
-    'src/services/esriMapUtils.js',
-    'src/directives/esriMap.js',
-    'src/directives/esriFeatureLayer.js',
-    'src/directives/esriDynamicMapServiceLayer.js',
-    'src/directives/esriInfoTemplate.js',
-    'src/directives/esriLegend.js'])
+    'src/core/esri.core.module.js',
+    'src/core/esriLoader.js',
+    'src/core/esriRegistry.js',
+    'src/core/esriMapUtils.js',
+    'src/core/esriLayerUtils.js',
+    'src/esri.map.module.js',
+    'src/map/EsriMapController.js',
+    'src/map/esriMap.js',
+    'src/map/esriLegend.js',
+    'src/layers/EsriLayerControllerBase.js',
+    'src/layers/EsriFeatureLayerController.js',
+    'src/layers/esriFeatureLayer.js',
+    'src/layers/EsriDynamicMapServiceLayerController.js',
+    'src/layers/esriDynamicMapServiceLayer.js',
+    'src/layers/esriInfoTemplate.js'])
     .pipe(concat('angular-esri-map.js'))
     .pipe(gulp.dest('dist'))
-    .pipe(gulp.dest('docs/lib'))
+    .pipe(gulp.dest('site/lib'))
     .pipe(stripDebug())
@@ -59,11 +98,11 @@ .pipe(ngAnnotate())
 gulp.task('build', function(callback) {
-  runSequence('lint', 'clean', 'build-js', callback);
+  runSequence('lint', 'clean', 'build-core-js', 'build-js', 'ngdocs', callback);
 });
 
-// serve docs and tests on local web server
-// and reload anytime source code or docs are modified
-gulp.task('serve', ['build'], function() {
+// serve site and tests on local web server
+// and reload anytime source code or site are modified
+gulp.task('serve', ['karma-once', 'build'], function() {
   browserSync({
     server: {
-      baseDir: ['docs', 'test']
+      baseDir: ['site', 'test', 'ngdocs']
     },
@@ -75,3 +114,4 @@ open: true,
 
-  gulp.watch([srcJsFiles,'./docs/**.*.html', './docs/app/**/*.js', './docs/styles/*.css'], ['build', browserSync.reload ]);
+  gulp.watch([srcJsFiles,'./site/**.*.html', siteJsFiles, './site/styles/*.css'], ['build', browserSync.reload ]);
+  gulp.watch([srcJsFiles, unitTestSpecFiles ], [ 'karma-once' ]);
 });
@@ -85,3 +125,3 @@
       routes: {
-        '/lib': 'docs/lib'
+        '/lib': 'site/lib'
       }
@@ -97,3 +137,3 @@ },
 gulp.task('deploy', ['build'], function () {
-  return gulp.src(['./docs/**/*', './test/**/*'])
+  return gulp.src(['./site/**/*', 'ngdocs/**/*', './test/**/*'])
     .pipe(deploy());
@@ -104,3 +144,3 @@ });
 gulp.task('deploy-prod', ['build'], function () {
-  return gulp.src(['./docs/**/*', './test/**/*'])
+  return gulp.src(['./site/**/*', 'ngdocs/**/*', './test/**/*'])
     .pipe(deploy({
@@ -111,3 +151,32 @@ remoteUrl: 'https://github.com/Esri/angular-esri-map.git'
 
-gulp.task('test', ['serve-test'], function() {
+gulp.task('karma-once', function(done) {
+  new KarmaServer({
+    configFile: __dirname + '/test/unit/karma.conf.js',
+    singleRun: true,
+    // if phantom doesn't start, change this port
+    // there's always some live reload listening on 9876
+    // so we're defaulting to 6789
+    port: 6789,
+    browsers: ['PhantomJS']
+  }, done).start();
+});
+
+gulp.task('karma-coverage', function(done) {
+  new KarmaServer({
+    configFile: __dirname + '/test/unit/karma.conf.js',
+    singleRun: true,
+    reporters: ['progress', 'coverage'],
+    preprocessors: {
+      '../../src/**/*.js': ['coverage']
+    }
+  }, done).start();
+});
+
+gulp.task('karma', function(done) {
+  new KarmaServer({
+    configFile: __dirname + '/test/unit/karma.conf.js'
+  }, done).start();
+});
+
+gulp.task('test', ['karma-coverage', 'serve-test'], function() {
   return gulp.src(['./test/e2e/specs/*.js'])
@@ -128,3 +197,21 @@ .pipe(angularProtractor({
 
+gulp.task('ngdocs', [], function () {
+  var gulpDocs = require('gulp-ngdocs');
+  return gulpDocs.sections({
+      api: {
+        glob: ['src/**/*.js'],
+        api: true,
+        title: 'API'
+      }
+    })
+    .pipe(gulpDocs.process({
+      title: 'angular-esri-map',
+      html5Mode: false,
+      navTemplate: 'site/docs-resources/docs-nav-template.html',
+      styles: ['site/docs-resources/docs-main.css']
+    }))
+    .pipe(gulp.dest('ngdocs/docs'));
+});
+
 // Default Task
 gulp.task('default', ['serve']);

package.json

 {
   "name": "angular-esri-map",
-  "version": "v1.0.0-beta.5",
+  "version": "1.0.0-rc.1",
   "description": "A collection of directives to help you use Esri maps and services in your Angular applications",
@@ -8,10 +8,16 @@ "main": "dist/angular-esri-map.js",
   "devDependencies": {
+    "angular": "^1.4.7",
+    "angular-mocks": "^1.4.7",
     "browser-sync": "~1.6.1",
+    "chai": "^3.4.1",
+    "eslint": "^1.9.0",
     "gh-release": "^2.0.1",
     "gulp": "^3.8.9",
+    "gulp-angular-protractor": "~0.0.2",
     "gulp-clean": "~0.3.0",
     "gulp-concat": "~2.2.0",
+    "gulp-eslint": "^1.0.0",
     "gulp-gh-pages": "^0.4.0",
-    "gulp-jshint": "^1.8.5",
     "gulp-ng-annotate": "^0.3.3",
+    "gulp-ngdocs": "^0.2.13",
     "gulp-rename": "~1.2.0",
@@ -21,5 +27,11 @@ "gulp-strip-debug": "~0.3.0",
     "gulp-util": "~2.2.16",
-    "run-sequence": "~0.3.6",
+    "jasmine-core": "^2.3.4",
+    "karma": "^0.13.15",
+    "karma-chrome-launcher": "^0.2.1",
+    "karma-coverage": "^0.5.3",
+    "karma-jasmine": "^0.3.6",
+    "karma-phantomjs-launcher": "^0.2.1",
+    "phantomjs": "^1.9.18",
     "protractor": "~2.2.0",
-    "gulp-angular-protractor": "~0.0.2"
+    "run-sequence": "~0.3.6"
   },
@@ -26,0 +38,0 @@ "repository": {

test/e2e/specs/web-map.js

@@ -18,4 +18,4 @@ 'use strict';
         // should be an instance of the legend dijit
-        helper.getAsyncAttributeValue(legend, 'widgetid').then(function(newValue) {
-            expect(newValue).toEqual('legend');
+        helper.getAsyncAttributeValue(legend, 'widgetid').then(function(value) {
+            expect(value).toEqual('legend');
         });
@@ -22,0 +22,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Manifest confusion

Supply chain risk

This package has inconsistent metadata. This could be malicious or caused by an error when publishing the package.

Found 1 instance in 1 package

Dynamic require

Supply chain risk

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

11541004

increased by110.94%

Number of package files

123

increased by32.26%

Lines of code

3544

increased by63.24%

Number of low supply chain risk alerts

2

decreased by-66.67%

Worsened metrics

Dev dependency count

27

increased by80%

No dependency changes