animated-gif-detector - npm Package Compare versions

Comparing version 0.0.1 to 0.1.0

index.js

@@ -12,13 +12,22 @@ var Writable = require('stream').Writable
 
+var isAnimated = function(buffer, pointer) {
+  var result = false;
+  for (var i = 0; i < buffer.length; i++) {
+    result = pointer == '00' &&
+             buffer.toString('hex', i, i + 1) == '21' &&
+             buffer.toString('hex', i + 1, i + 2) == 'f9';
+    pointer = buffer.toString('hex', i, i + 1);
+    if (result)
+      break;
+  }
+  return { pointer: pointer, animated: result };
+}
+
 AnimatedGifDetector.prototype._write = function(chunk, enc, next) {
-  this.buffer = Buffer.concat([this.buffer, chunk]);
-  var value1, value2;
-  for (var i = this.pointer; i < this.buffer.length; i++) {
-    value1 = this.buffer.toString('hex', i, i + 1);
-    value2 = this.buffer.toString('hex', i + 1, i + 2);
-    // console.log(this.pointer, value1, value2);
-    if (this.pointer == '00' && value1 == '21' && value2 == 'f9')
-      this.emit('animated');
-    this.pointer = value1;
-  }
+  this.buffer = Buffer.concat([this.buffer, chunk])
+    , result = isAnimated(this.buffer, this.pointer)
+  ;
+  if (result.animated)
+    this.emit('animated');
+  this.pointer = result.pointer;
   next();
@@ -28,38 +37,6 @@ };
 AnimatedGifDetector.prototype.sync = function(buffer) {
-  var result = false;
-  for (var i = 0; i < this.buffer.length; i++) {
-    value = this.buffer.toString('hex', i, i + 1);
-    if (pointer == '00' && value == '21') {
-      result = true;
-      break;
-    }
-    pointer = value;
-  }
-  return result;
+  buffer = Buffer.isBuffer(buffer) ? buffer : new Buffer(buffer);
+  return isAnimated(buffer).animated;
 };
 
-
-/*
-var fs = require('fs')
-  , headers = require('./lib/offsets').headers
-
-  , buffer = []
-;
-
-fs.createReadStream('./test/files/GifSample.gif')
-  .on('data', buffer.push.bind(buffer))
-  .on('end', function() {
-    
-    // headers.reduce(function(memo, offset) {
-    //   memo = offset.start + offset.length;
-    //   var value = this.buffer.slice(offset.start, offset.start + offset.length)
-    //                 .toString(offset.encoding)
-    //               ;
-    //   console.log(offset.description, '=>', value);
-    //   return memo;
-    // }, 0);
-  });
-;
-*/
-
 module.exports = AnimatedGifDetector;

package.json

 {
   "name": "animated-gif-detector",
-  "version": "0.0.1",
+  "version": "0.1.0",
   "description": "animated-gif-detector --- Detect animated GIFs from JavaScript buffers.",
@@ -5,0 +5,0 @@ "main": "index.js",

test/index.test.js

@@ -82,3 +82,3 @@ var path = require('path')
   var buffer = fs.readFileSync(filePath);
-  t.notOk(new A().sync(buffer), 'is animated');
+  t.ok(new A().sync(buffer), 'is animated');
   t.end();
@@ -85,0 +85,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

863738

decreased by-0.15%

Number of package files

12

decreased by-7.69%

Lines of code

114

decreased by-20.28%

No dependency changes