apac - npm Package Compare versions

Comparing version 0.0.4 to 0.0.9

lib/OperationHelper.js

@@ -51,5 +51,3 @@ var RSH = require('./RequestSignatureHelper').RequestSignatureHelper,
 
-OperationHelper.prototype.execute = function(operation, params, callback) {
-    if (typeof(operation) === 'undefined') { throw 'Missing operation parameter' }
-    if (typeof(params) === 'undefined') { params = {} }
+OperationHelper.prototype.generateUri = function(operation, params) {
     params = this.generateParams(operation, params);
@@ -61,4 +59,12 @@ var helper = this.getSignatureHelper();
     var uri = this.baseUri + '?' + queryString;
+    return uri;
+}
+
+OperationHelper.prototype.execute = function(operation, params, callback) {
+    if (typeof(operation) === 'undefined') { throw 'Missing operation parameter' }
+    if (typeof(params) === 'undefined') { params = {} }
+    var uri = this.generateUri(operation, params);
     var host = this.endPoint;
     var amazonClient = http.createClient(80, host);
+    var parser = this.parser;
     var request = amazonClient.request('GET', uri, {'host':host});
@@ -69,3 +75,3 @@ request.end();
         response.addListener('data', function(chunk) {
-            responseBody = responseBody + chunk;
+            responseBody += chunk;
         });
@@ -72,0 +78,0 @@ response.addListener('end', function() {

lib/RequestSignatureHelper.js

@@ -1,3 +0,2 @@
-var crypto = require('crypto'),
-    sys = require('sys');
+var crypto = require('crypto');
 
@@ -69,10 +68,6 @@ var RSH = function(params) {
 /**
- * The following characters must not be escaped according to
- * RFC 3986: /^A-Za-z0-9\-_.~/
- * The standard JS escape function does the following wrong:
- * Should escepe: "*+"
- * Shouldn't escape: "~"
+ * Port of PHP rawurlencode().
  */
 RSH.prototype.escape = function(x) {
-    return escape(x).replace(/%7E/g, '~').replace(/\*/g, '%2A').replace(/\+/g, '%2B');
+    return encodeURIComponent(x).replace(/!/g, '%21').replace(/'/g, '%27').replace(/\(/g, '%28').replace(/\)/g, '%29').replace(/\*/g, '%2A');
 };
@@ -79,0 +74,0 @@

package.json

 { "name" : "apac"
 , "description" : "Amazon Product Advertising API Client for Node"
-, "version" : "0.0.4"
+, "version" : "0.0.9"
 , "author" : "Dustin McQuay <[e-mail]>"
 , "repository" :
   { "type" : "git"
-  , "url" : "git://github.com/dmcquay/node-apac.git"
+  , "url" : "git://github.com/joelvh/node-apac.git"
   }
-, "bugs" : { "web" : "http://github.com/dmcquay/node-apac/issues" }
+, "bugs" : { "url" : "http://github.com/dmcquay/node-apac/issues" }
 , "os" : [ "linux", "darwin", "freebsd" ]
@@ -15,3 +15,3 @@ , "directories" : { "lib" : "./lib/" }
   { "vows" : ">=0.5.0"
-  , "xml2js" : "*"
+  , "xml2js" : ">=0.1.7"
   }
@@ -18,0 +18,0 @@ , "engines" : { "node" : ">=0.1.97" }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Non-existent author

Supply chain risk

The package was published by an npm account that no longer exists.

Found 1 instance in 1 package

Wildcard dependency

Quality

Package has a dependency with a floating version range. This can cause issues if the dependency publishes a new major version.

Found 1 instance in 1 package

No bug tracker

Maintenance

Package does not have a linked bug tracker in package.json.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

14671

increased by0.2%

Number of package files

11

increased by10%

Number of low maintenance alerts

1

decreased by-50%

Number of medium quality alerts

1

decreased by-50%

Number of high supply chain risk alerts

0

decreased by-100%

Worsened metrics

Number of medium supply chain risk alerts

3

increased by50%

Dependency changes

• Updatedxml2js@>=0.1.7