apn - npm Package Compare versions

Comparing version 1.7.0 to 1.7.1

ChangeLog.md

 ## Changelog
 
+1.7.1:
+
+* Fixed: #224, always passing a CA value even if no certificates were specified. In this case the TLS library will not use the built in root certificates and will always fail to trust the server certificate.
+* Changed: Socket timeout default has changed for disabled to 1 hour.
+* Documentation fixes
+
 1.7.0:
@@ -4,0 +10,0 @@

lib/connection.js

@@ -44,3 +44,3 @@ var Errors = require('./errors');
  * @config {Number} [maxConnections=1] The maximum number of connections to create for sending messages.
- * @config {Number} [connectionTimeout=0] The duration the socket should stay alive with no activity in milliseconds. 0 = Disabled.
+ * @config {Number} [connectionTimeout=3600000] The duration the socket should stay alive with no activity in milliseconds. 0 = Disabled.
  * @config {Boolean} [buffersNotifications=true] Whether to buffer notifications and resend them after failure.
@@ -69,3 +69,3 @@ * @config {Boolean} [fastMode=false] Whether to aggresively empty the notification buffer while connected.
 		connectTimeout: 10000,
-		connectionTimeout: 0,
+		connectionTimeout: 3600000,
 		connectionRetryLimit: 10,
@@ -72,0 +72,0 @@ buffersNotifications: true,

lib/credentials/load.js

@@ -28,3 +28,3 @@ var fs   = require('fs');
 	if (caPromises.length == 0) {
-		delete caPromises;
+		caPromises = undefined;
 	}
@@ -31,0 +31,0 @@ else {

package.json

 {
   "name": "apn",
   "description": "An interface to the Apple Push Notification service for Node.js",
-  "version": "1.7.0",
+  "version": "1.7.1",
   "author": "Andrew Naylor <[e-mail]>",
@@ -43,2 +43,6 @@ "contributors": [
   },
+  "jshintConfig": {
+    "node": true,
+    "strict": false
+  },
   "engines": {
@@ -45,0 +49,0 @@ "node": ">= 0.6.14"

test/credentials/load.js

@@ -109,2 +109,6 @@ var loadCredentials = require("../../lib/credentials/load");
 
+	it("returns undefined if no CA values are specified", function() {
+		return expect(loadCredentials({ cert: null, key: null, ca: null}).get("ca")).to.eventually.be.undefined;
+	});
+	
 	it("should inclue the passphrase in the resolved value", function() {
@@ -111,0 +115,0 @@ return expect(loadCredentials({ passphrase: "apntest" }).get("passphrase"))

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

232284

increased by0.29%

Number of package files

66

increased by1.54%

Lines of code

3217

increased by0.09%

No dependency changes